Skip to content

Commit 7b620c2

Browse files
lJxDababdeepin-bot[bot]
authored andcommitted
fix: the overflow bug of the stack in deepin-devicemanager
ioctlEnableNetwork-> ioctlOperateNetworkLogicalName, in this function directly to the user input parameter path, strcpy gives ifr.ifr_name a stack overflow Log: overflow bug (strcpy) Bug: https://pms.uniontech.com/bug-view-253863.html
1 parent bc7a51c commit 7b620c2

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • deepin-devicemanager-server/deepin-devicecontrol/src/enablecontrol

deepin-devicemanager-server/deepin-devicecontrol/src/enablecontrol/enableutils.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ bool EnableUtils::ioctlOperateNetworkLogicalName(const QString &logicalName, boo
152152
if (fd < 0)
153153
return false;
154154
struct ifreq ifr;
155-
strcpy(ifr.ifr_name, logicalName.toStdString().c_str());
155+
strncpy(ifr.ifr_name, logicalName.toStdString().c_str(),strlen(ifr.ifr_name));
156156

157157
short flag;
158158
if (enable) {

0 commit comments

Comments
 (0)