fix: [UIE-9888] - update node balancer type for enterprise and remove duplicate nodebalancer rows in VPC subnet table (#13472)

Author: grevanak-akamai

packages/api-v4/.changeset/pr-13472-changed-1773131929522.md

@@ -0,0 +1,5 @@
+---
+"@linode/api-v4": Changed
+---
+
+Update  node balancer type for enterprise from premium_40GB to premium_40gb ([#13472](https://github.com/linode/manager/pull/13472))

packages/api-v4/src/nodebalancers/types.ts

@@ -10,7 +10,7 @@ type UDPStickiness = 'none' | 'session' | 'source_ip';
 
 export type Stickiness = TCPStickiness | UDPStickiness;
 
-type NodeBalancerType = 'common' | 'premium' | 'premium_40GB';
+type NodeBalancerType = 'common' | 'premium' | 'premium_40gb';
 
 export interface LKEClusterInfo {
   id: number;

packages/manager/.changeset/pr-13472-fixed-1773071273109.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Fixed
+---
+
+Update node balancer type for enterprise and remove duplicate nodebalancer rows in VPC subnet table ([#13472](https://github.com/linode/manager/pull/13472))

packages/manager/src/features/NodeBalancers/NodeBalancerDetail/NodeBalancerSummary/SummaryPanel.test.tsx

@@ -162,9 +162,9 @@ describe('SummaryPanel', () => {
     expect(typeElement).toBeVisible();
   });
 
-  it('displays type: Enterprise if the nodebalancer is premium_40GB', () => {
+  it('displays type: Enterprise if the nodebalancer is premium_40gb', () => {
     queryMocks.useNodeBalancerQuery.mockReturnValue({
-      data: nodeBalancerFactory.build({ type: 'premium_40GB' }),
+      data: nodeBalancerFactory.build({ type: 'premium_40gb' }),
     });
 
     const { getByText } = renderWithTheme(<SummaryPanel />);

packages/manager/src/features/NodeBalancers/NodeBalancerDetail/NodeBalancerSummary/SummaryPanel.tsx

@@ -112,7 +112,7 @@ export const SummaryPanel = () => {
               <strong>Type: </strong>
               {nodebalancer.type === 'common' && 'Basic'}
               {nodebalancer.type === 'premium' && 'Premium'}
-              {nodebalancer.type === 'premium_40GB' && 'Enterprise'}
+              {nodebalancer.type === 'premium_40gb' && 'Enterprise'}
             </Typography>
           </StyledSection>
           <StyledSection>

packages/manager/src/features/VPCs/VPCDetail/VPCSubnetsTable.tsx

@@ -315,6 +315,13 @@ export const VPCSubnetsTable = (props: Props) => {
 
   const getTableItems = (): TableItem[] => {
     return subnets.data.map((subnet) => {
+      // NodeBalancers can have same VPC subnet as its frontend and backend configuration.
+      // and this can create duplicate entries in the resources count and also in the list of nodebalancers assigned to a subnet.
+      // To avoid this, we are creating a unique list of nodebalancers based on their id.
+      const uniqueNodebalancers = Array.from(
+        new Map(subnet.nodebalancers.map((nb) => [nb.id, nb])).values()
+      );
+
       const OuterTableCells = (
         <>
           <Hidden smDown>
@@ -326,7 +333,7 @@ export const VPCSubnetsTable = (props: Props) => {
           )}
           <Hidden smDown>
             <TableCell>
-              {`${isNodebalancerVPCEnabled ? subnet.linodes.length + subnet.nodebalancers.length : subnet.linodes.length}`}
+              {`${isNodebalancerVPCEnabled ? subnet.linodes.length + uniqueNodebalancers.length : subnet.linodes.length}`}
             </TableCell>
           </Hidden>
           <TableCell actionCell>
@@ -336,7 +343,7 @@ export const VPCSubnetsTable = (props: Props) => {
               handleEdit={handleSubnetEdit}
               handleUnassignLinodes={handleSubnetUnassignLinodes}
               numLinodes={subnet.linodes.length}
-              numNodebalancers={subnet.nodebalancers.length}
+              numNodebalancers={uniqueNodebalancers.length}
               subnet={subnet}
               vpcId={vpcId}
             />
@@ -376,7 +383,7 @@ export const VPCSubnetsTable = (props: Props) => {
               )}
             </TableBody>
           </Table>
-          {isNodebalancerVPCEnabled && subnet.nodebalancers?.length > 0 && (
+          {isNodebalancerVPCEnabled && uniqueNodebalancers.length > 0 && (
             <Table aria-label="NodeBalancers" size="small" striped={false}>
               <TableHead
                 style={{
@@ -386,7 +393,7 @@ export const VPCSubnetsTable = (props: Props) => {
                 {SubnetNodebalancerTableRowHead}
               </TableHead>
               <TableBody>
-                {subnet.nodebalancers.map((nb) => (
+                {uniqueNodebalancers.map((nb) => (
                   <SubnetNodeBalancerRow
                     key={nb.id}
                     nodeBalancerId={nb.id}

packages/utilities/src/factories/nodebalancer.ts

@@ -47,7 +47,7 @@ export const nodeBalancerFactory = Factory.Sync.makeFactory<NodeBalancer>({
   }),
   type: Factory.each((i) => {
     if (i === 1) {
-      return 'premium_40GB';
+      return 'premium_40gb';
     }
     if (i % 2 === 0) {
       return 'premium';