Skip to content

Commit 63871a3

Browse files
authored
fix: [DPS-42123] - Destination Form: fix tooltips positions (#13574)
1 parent 524b8c9 commit 63871a3

4 files changed

Lines changed: 13 additions & 8 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@linode/manager": Fixed
3+
---
4+
5+
Destination Form: adjust tooltips' icons positions for Akamai Object Storage destination ([#13574](https://github.com/linode/manager/pull/13574))

packages/manager/src/features/Delivery/Shared/DestinationAkamaiObjectStorageDetailsForm.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -212,12 +212,12 @@ export const DestinationAkamaiObjectStorageDetailsForm = ({
212212
'data-pendo-id': `${pendoPageId}Host`,
213213
}}
214214
label="Endpoint"
215+
labelTooltipText="The Object Storage service endpoint associated with your bucket's region"
215216
onBlur={field.onBlur}
216217
onChange={(value) => {
217218
field.onChange(value);
218219
}}
219220
placeholder="https://us-ord-1.linodeobjects.com"
220-
tooltipText="The Object Storage service endpoint associated with your bucket's region"
221221
value={field.value}
222222
/>
223223
)}
@@ -233,9 +233,9 @@ export const DestinationAkamaiObjectStorageDetailsForm = ({
233233
'data-pendo-id': `${pendoPageId}Access Key ID`,
234234
}}
235235
label="Access Key ID"
236+
labelTooltipText="The access key identifier used for authentication"
236237
onBlur={field.onBlur}
237238
onChange={(value) => field.onChange(value)}
238-
tooltipText="The access key identifier used for authentication"
239239
value={field.value}
240240
/>
241241
)}
@@ -251,9 +251,9 @@ export const DestinationAkamaiObjectStorageDetailsForm = ({
251251
'data-pendo-id': `${pendoPageId}Secret Access Key`,
252252
}}
253253
label="Secret Access Key"
254+
labelTooltipText="The confidential security credential used with Access Key ID to access Object Storage"
254255
onBlur={field.onBlur}
255256
onChange={(value) => field.onChange(value)}
256-
tooltipText="The confidential security credential used with Access Key ID to access Object Storage"
257257
value={field.value}
258258
/>
259259
)}
@@ -278,12 +278,12 @@ export const DestinationAkamaiObjectStorageDetailsForm = ({
278278
'data-pendo-id': `${pendoPageId}Log Path Prefix`,
279279
}}
280280
label="Log Path Prefix"
281+
labelTooltipText="The path prefix used for organizing uploaded objects"
281282
onBlur={field.onBlur}
282283
onChange={(value) => field.onChange(value)}
283284
optional
284285
placeholder="Prefix for log storage path"
285286
sx={{ maxWidth: 416 }}
286-
tooltipText="The path prefix used for organizing uploaded objects"
287287
value={field.value}
288288
/>
289289
)}

packages/manager/src/features/Delivery/Shared/PathSample.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ export const PathSample = (props: PathSampleProps) => {
9292
<InputLabel>
9393
Sample Destination Object Name
9494
<TooltipIcon
95+
labelTooltipIconSize="small"
9596
status="info"
9697
sxTooltipIcon={sxTooltipIcon}
9798
text={

packages/manager/src/features/Delivery/Streams/StreamForm/Delivery/StreamFormDelivery.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -289,8 +289,7 @@ export const StreamFormDelivery = (props: StreamFormDeliveryProps) => {
289289
inputProps: {
290290
'data-pendo-id': `Logs Delivery Streams ${capitalizedMode}-Destination Name`,
291291
},
292-
tooltipPosition: 'right',
293-
tooltipText:
292+
labelTooltipText:
294293
'Select an existing destination from the list or create a new one by entering a name and clicking Create.',
295294
}}
296295
value={field.value ? { label: field.value } : null}
@@ -306,7 +305,7 @@ export const StreamFormDelivery = (props: StreamFormDeliveryProps) => {
306305
mode={mode}
307306
/>
308307
)}
309-
{selectedDestinations?.[0] && (
308+
{findDestination(selectedDestinations?.[0])?.details && (
310309
<DestinationAkamaiObjectStorageDetailsSummary
311310
{...(findDestination(selectedDestinations[0])
312311
?.details as AkamaiObjectStorageDetails)}
@@ -324,7 +323,7 @@ export const StreamFormDelivery = (props: StreamFormDeliveryProps) => {
324323
mode={mode}
325324
/>
326325
)}
327-
{selectedDestinations?.[0] && (
326+
{findDestination(selectedDestinations?.[0])?.details && (
328327
<DestinationCustomHTTPSDetailsSummary
329328
{...(findDestination(selectedDestinations[0])
330329
?.details as CustomHTTPSDetails)}

0 commit comments

Comments
 (0)