upgrade checkout action, fix build_link

Author: leonhma

.github/workflows/ci.yml

@@ -7,11 +7,12 @@ on:
 
 jobs:
   build:
-    name: build
     runs-on: ubuntu-latest
+    env:
+      BUILD_LINK: https://github.com/leonhma/obsidian-functionplot/actions/runs/${{ github.run_id }}
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       - uses: actions/setup-node@v3
         with:
@@ -31,7 +32,7 @@ jobs:
       - name: upload dist
         uses: actions/upload-artifact@v3.1.0
         with:
-          name: dist
+          name: obsidian-functionplot
           path: |
             manifest.json
             main.js
@@ -40,7 +41,7 @@ jobs:
     runs-on: ubuntu-latest
     name: test
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       - uses: actions/setup-node@v3
         with:
@@ -56,9 +57,9 @@ jobs:
 
   lint:
     runs-on: ubuntu-latest
-    name: lint:prod
+    name: lint
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       - uses: actions/setup-node@v3
         with:

.github/workflows/release.yml

@@ -10,6 +10,8 @@ permissions:
 jobs:
   release:
     runs-on: ubuntu-latest
+    env:
+      BUILD_LINK: https://github.com/leonhma/obsidian-functionplot/releases/tag/${{ github.event.release.tag_name }}
 
     steps:
       - name: Setup Node.js environment
@@ -18,7 +20,7 @@ jobs:
           node-version: 18
 
       - name: Checkout
-        uses: actions/checkout@v2.4.2
+        uses: actions/checkout@v3
 
       - name: Install
         run: |
@@ -42,7 +44,7 @@ jobs:
       # build now, so that no side-effects when build fails and release get deleted
       - name: Build
         run: |
-          pnpm run build:release
+          pnpm run build:prod
           mkdir obsidian-functionplot
           cp main.js manifest.json styles.css obsidian-functionplot
           zip -r obsidian-functionplot.zip obsidian-functionplot

.gitignore

@@ -3,6 +3,7 @@ main.js
 !*/**/main.js
 data.json
 package-lock.json
+yarn.lock
 .nyc_output
 coverage
 .yarn

package.json

@@ -7,7 +7,6 @@
   "license": "MIT",
   "private": true,
   "scripts": {
-    "build:release": "pnpm exec webpack --env production --env includeReleaseLink",
     "build:prod": "pnpm exec webpack --env production",
     "build": "pnpm exec webpack",
     "watch": "pnpm exec webpack --watch",

src/__tests__/utils.test.ts

@@ -5,10 +5,7 @@ const { execSync } = require("child_process");
 
 module.exports = (env) => {
   const isProd = env.production === true;
-  console.log("isProd", isProd);
   const manifest = JSON.parse(readFileSync("manifest.json", "utf8"));
-  const isCI = process.env.CI === "true";
-  console.log("isCI", isCI);
 
   return {
     mode: isProd ? "production" : "development",
@@ -69,11 +66,7 @@ module.exports = (env) => {
             ? manifest.version
             : `${execSync("git rev-parse --short HEAD").toString().trim()}+`
         ),
-        BUILD_LINK: JSON.stringify(
-          env.includeReleaseLink === true
-            ? `https://github.com/leonhma/obsidian-functionplot/releases/tag/${manifest.version}`
-            : ""
-        ),
+        BUILD_LINK: JSON.stringify(process.env.BUILD_LINK || ""),
       }),
     ],
     resolve: {