delete release on error during build

Author: leonhma

.github/release-notes.js

@@ -0,0 +1,13 @@
+const { readFileSync, writeFileSync, existsSync } = require("fs");
+
+const [name, body] = process.argv.slice(2);
+
+let releaseNotes = "";
+
+if (existsSync("./release-notes.md")) {
+  releaseNotes = readFileSync("./release-notes.md", "utf8");
+}
+
+releaseNotes = `## ${name}\n\n${body}\n\n${releaseNotes}`;
+
+writeFileSync("./release-notes.md", releaseNotes);

.github/version-bump.mjs .github/version-bump.js.github/version-bump.mjs renamed to .github/version-bump.js

@@ -1,4 +1,4 @@
-import { readFileSync, writeFileSync } from "fs";
+const { readFileSync, writeFileSync } = require("fs");
 
 const version = process.argv[2];
 

.github/workflows/release.yml

@@ -19,14 +19,28 @@ jobs:
 
       - name: Checkout
         uses: actions/checkout@v2.4.2
-        with:
-          ref: master
 
-      - name: Install packages
-        run: yarn install
+      - name: Install
+        run: |
+          sudo apt-get -y install moreutils
+          yarn install
+
+      - name: Lint
+        run: yarn lint
+
+      - name: Test
+        run: yarn test
 
       - name: Run version-bump
-        run: node .github/version-bump.mjs ${{ github.event.release.tag_name }}
+        run: node .github/version-bump.js ${{ github.event.release.tag_name }}
+
+      # build release notes
+      - name: Update release notes
+        run: node .github/release-notes.js ${{ github.event.release.tag_name }} ${{ github.event.release.body }}
+
+      # build now, so that no side-effects when build fails and release get deleted
+      - name: Build
+        run: yarn build:prod
 
       - name: Commit and push changes
         run: |
@@ -37,11 +51,16 @@ jobs:
           git commit -m "chore(versions): index minAppVersion for latest release"
           git push origin master
 
-      - name: Build
-        run: yarn build:prod
-
       - name: Upload assets to a Release
         uses: AButler/upload-release-assets@v2.0
         with:
           repo-token: ${{ github.token }}
           files: "main.js;manifest.json"
+
+      - uses: actions/github-script@v4
+        if: failure()
+        with:
+          github-token: ${{secrets.GITHUB_TOKEN}}
+          script: |
+            const { owner, repo } = context.repo
+            await github.repos.deleteRelease({ owner, repo, release_id: context.payload.release.id })

package.json

@@ -7,8 +7,10 @@
   "license": "MIT",
   "private": true,
   "scripts": {
-    "build:prod": "yarn lint -c .eslintrc.prod.json && webpack --env=production",
-    "build": "yarn lint && webpack",
+    "build:prod": "webpack --env=production",
+    "build:dev": "webpack",
+    "build": "yarn build:dev",
+    "lint:prod": "yarn eslint -c .eslintrc.prod.json .",
     "test": "jest",
     "format": "yarn prettier --write .",
     "lint": "yarn eslint -c .eslintrc.json .",

release-notes.md

@@ -0,0 +1,7 @@
+## 2.0.0
+
+A new release. Yehoo!
+
+## 2.0.0
+
+A new release. Yehoo!

src/common/types.ts

@@ -12,7 +12,9 @@ export type rendererType = "interactive" | "image";
 export type chartType = Chart & EventEmitter;
 
 //Custom utility type:
-export type DeepNonNullable<T> = { [K in keyof T]: DeepNonNullable<NonNullable<T[K]>> };
+export type DeepNonNullable<T> = {
+  [K in keyof T]: DeepNonNullable<NonNullable<T[K]>>;
+};
 
 export interface FunctionInputs {
   id: string | null;