remove errors.As-related changes

Author: PeterIvanov

error_113.go

@@ -2,30 +2,6 @@
 
 package errorx
 
-import "reflect"
-
-// todo add errorx.As()?
-// todo make another 'go error type' for passing into errors.As()?
-// todo when fixed, add tests for wrap/decorate etc.
-// As checks if target is of the same type as current error and, if true, sets target to this error value.
-// NB: Call to errors.As() converts any type of errorx error to any other type,
-// therefore such calls are currently unsafe for errorx errors and will likely break semantics.
-// Note than calls to errors.Is() do not suffer from the same issue.
-func (e *Error) As(target interface{}) bool {
-	targetError, ok := target.(*error)
-	if !ok {
-		return false
-	}
-
-	if !e.Is(*targetError) {
-		return false
-	}
-
-	targetVal := reflect.ValueOf(target)
-	targetVal.Elem().Set(reflect.ValueOf(e))
-	return true
-}
-
 // Is returns true if and only if target is errorx error that passes errorx type check against current error.
 // This behaviour is exactly the same as that of IsOfType().
 // See also: errors.Is()

error_113_test.go

@@ -4,7 +4,6 @@ package errorx
 
 import (
 	"errors"
-	"fmt"
 	"io"
 	"testing"
 
@@ -103,46 +102,3 @@ func TestErrorIs(t *testing.T) {
 	})
 }
 
-func TestErrorAs(t *testing.T) {
-	t.Run("Trivial", func(t *testing.T) {
-		err := fooReturnsError()
-		target := testType.NewWithNoMessage()
-		require.True(t, errors.As(err, &target))
-		require.EqualValues(t, "whoops", target.Message())
-		output := fmt.Sprintf("%+v", target)
-		require.Contains(t, output, "fooReturnsError", output)
-	})
-
-	// Current errors.As allows no customization in this behaviour; if go types are assignable, here we go
-	t.Run("NegativeBroken", func(t *testing.T) {
-		err := fooReturnsError()
-		target := testTypeBar1.NewWithNoMessage()
-		require.True(t, errors.As(err, &target))
-		require.EqualValues(t, "whoops", target.Message())
-		require.True(t, IsOfType(target, testType))
-		require.False(t, IsOfType(target, testTypeBar1))
-	})
-
-	t.Run("Negative", func(t *testing.T) {
-		err := io.EOF
-		target := testTypeBar1.NewWithNoMessage()
-		require.False(t, errors.As(err, &target))
-	})
-
-	t.Run("DecorateForeign", func(t *testing.T) {
-		err := Decorate(myErr("test"),"")
-		var target myErr
-		require.True(t, errors.As(err, &target))
-		require.EqualValues(t, "test", target.Error())
-	})
-}
-
-func fooReturnsError() error {
-	return testType.New("whoops")
-}
-
-type myErr string
-
-func (e myErr) Error() string {
-	return string(e)
-}