Fix deprecation warnings

Author: jchristgit

lib/crow/worker.ex

@@ -17,15 +17,15 @@ defmodule Crow.Worker do
   def handle_continue(:send_banner, conn) do
     {:ok, {ip, port}} = :inet.peername(conn)
     {:ok, hostname} = :inet.gethostname()
-    :ok = :gen_tcp.send(conn, '# munin node at #{hostname}\n')
+    :ok = :gen_tcp.send(conn, ~c"# munin node at #{hostname}\n")
     Logger.debug("accepted connection from #{:inet.ntoa(ip)}:#{port}.")
     {:noreply, conn}
   end
 
   @doc false
   @impl true
   def handle_info({:tcp, sock, "cap" <> _rest}, state) do
-    :ok = :gen_tcp.send(sock, 'cap\n')
+    :ok = :gen_tcp.send(sock, ~c"cap\n")
     {:noreply, state}
   end
 
@@ -35,13 +35,13 @@ defmodule Crow.Worker do
         {plugin, options} ->
           options
           |> plugin.config()
-          |> Stream.intersperse('\n')
+          |> Stream.intersperse(~c"\n")
           |> Enum.to_list()
           |> :lists.concat()
-          |> :lists.append('\n.\n')
+          |> :lists.append(~c"\n.\n")
 
         nil ->
-          '# unknown plugin\n'
+          ~c"# unknown plugin\n"
       end
 
     :ok = :gen_tcp.send(sock, response)
@@ -55,13 +55,13 @@ defmodule Crow.Worker do
         {plugin, options} ->
           options
           |> plugin.values()
-          |> Stream.intersperse('\n')
+          |> Stream.intersperse(~c"\n")
           |> Enum.to_list()
           |> :lists.concat()
-          |> :lists.append('\n.\n')
+          |> :lists.append(~c"\n.\n")
 
         nil ->
-          '# unknown plugin\n'
+          ~c"# unknown plugin\n"
       end
 
     :ok = :gen_tcp.send(sock, response)
@@ -73,23 +73,23 @@ defmodule Crow.Worker do
     plugin_line =
       Config.list()
       |> Stream.map(fn {plugin, options} -> plugin.name(options) end)
-      |> Stream.intersperse(' ')
+      |> Stream.intersperse(~c" ")
       |> Enum.to_list()
       |> :lists.concat()
-      |> :lists.append('\n')
+      |> :lists.append(~c"\n")
 
     :ok = :gen_tcp.send(sock, plugin_line)
     {:noreply, state}
   end
 
   def handle_info({:tcp, sock, "nodes\n"}, state) do
     {:ok, hostname} = :inet.gethostname()
-    :ok = :gen_tcp.send(sock, '#{hostname}\n.\n')
+    :ok = :gen_tcp.send(sock, ~c"#{hostname}\n.\n")
     {:noreply, state}
   end
 
   def handle_info({:tcp, sock, "version\n"}, state) do
-    :ok = :gen_tcp.send(sock, 'crow node version #{@version}\n')
+    :ok = :gen_tcp.send(sock, ~c"crow node version #{@version}\n")
     {:noreply, state}
   end
 
@@ -104,7 +104,7 @@ defmodule Crow.Worker do
     :ok =
       :gen_tcp.send(
         sock,
-        '# unknown command. try cap, config, fetch, list, nodes, version, quit\n'
+        ~c"# unknown command. try cap, config, fetch, list, nodes, version, quit\n"
       )
 
     {:noreply, state}

test/crow/worker_test.exs

@@ -2,9 +2,9 @@ defmodule Crow.WorkerTest do
   use ExUnit.Case
 
   defmodule TestPlugin do
-    def name(_options), do: 'custom_name'
-    def config(_options), do: ['graph_title fizz buzz']
-    def values(_options), do: ['foo.value 3']
+    def name(_options), do: ~c"custom_name"
+    def config(_options), do: [~c"graph_title fizz buzz"]
+    def values(_options), do: [~c"foo.value 3"]
   end
 
   setup_all do
@@ -30,45 +30,45 @@ defmodule Crow.WorkerTest do
 
   describe "cap command" do
     test "displays no capabilities", %{socket: socket} do
-      :ok = :gen_tcp.send(socket, 'cap\n')
+      :ok = :gen_tcp.send(socket, ~c"cap\n")
       assert_receive {:tcp, ^socket, "cap\n"}
     end
   end
 
   describe "config command" do
     test "displays configuration for known plugins", %{socket: socket} do
-      :ok = :gen_tcp.send(socket, 'config custom_name\n')
+      :ok = :gen_tcp.send(socket, ~c"config custom_name\n")
       assert_receive {:tcp, ^socket, "graph_title fizz buzz\n.\n"}
     end
 
     test "displays unknown plugin for unknown plugins", %{socket: socket} do
-      :ok = :gen_tcp.send(socket, 'config totally_not_a_plugin\n')
+      :ok = :gen_tcp.send(socket, ~c"config totally_not_a_plugin\n")
       assert_receive {:tcp, ^socket, "# unknown plugin\n"}
     end
   end
 
   describe "fetch command" do
     test "displays values for known plugins", %{socket: socket} do
-      :ok = :gen_tcp.send(socket, 'fetch custom_name\n')
+      :ok = :gen_tcp.send(socket, ~c"fetch custom_name\n")
       assert_receive {:tcp, ^socket, "foo.value 3\n.\n"}
     end
 
     test "displays unknown plugin for unknown plugins", %{socket: socket} do
-      :ok = :gen_tcp.send(socket, 'fetch totally_not_a_plugin\n')
+      :ok = :gen_tcp.send(socket, ~c"fetch totally_not_a_plugin\n")
       assert_receive {:tcp, ^socket, "# unknown plugin\n"}
     end
   end
 
   describe "list command" do
     test "displays the configured test plugin", %{socket: socket} do
-      :ok = :gen_tcp.send(socket, 'list\n')
+      :ok = :gen_tcp.send(socket, ~c"list\n")
       assert_receive {:tcp, ^socket, "custom_name\n"}
     end
   end
 
   describe "nodes command" do
     test "displays the local node hostname", %{socket: socket} do
-      :ok = :gen_tcp.send(socket, 'nodes\n')
+      :ok = :gen_tcp.send(socket, ~c"nodes\n")
       {:ok, hostname} = :inet.gethostname()
       expected_message = "#{hostname}\n.\n"
       assert_receive {:tcp, ^socket, ^expected_message}
@@ -77,22 +77,22 @@ defmodule Crow.WorkerTest do
 
   describe "version command" do
     test "displays the current version", %{socket: socket} do
-      :ok = :gen_tcp.send(socket, 'version\n')
+      :ok = :gen_tcp.send(socket, ~c"version\n")
       expected_message = "crow node version #{Mix.Project.config()[:version]}\n"
       assert_receive {:tcp, ^socket, ^expected_message}
     end
   end
 
   describe "quit command" do
     test "closes the connection", %{socket: socket} do
-      :ok = :gen_tcp.send(socket, 'quit\n')
+      :ok = :gen_tcp.send(socket, ~c"quit\n")
       assert_receive {:tcp_closed, ^socket}
     end
   end
 
   describe "unknown commands" do
     test "display help", %{socket: socket} do
-      :ok = :gen_tcp.send(socket, 'totally_not_a_command\n')
+      :ok = :gen_tcp.send(socket, ~c"totally_not_a_command\n")
 
       assert_receive {:tcp, ^socket,
                       "# unknown command. try cap, config, fetch, list, nodes, version, quit\n"}