fix(macos): cache CoreFoundation init failure

Author: ShresthSamyak

mpv.py

@@ -36,6 +36,7 @@
 
 _core_foundation = None
 _cf_runloop_default_mode = None
+_core_foundation_init_failed = False
 if os.name == 'nt':
     # Note: mpv-2.dll with API version 2 corresponds to mpv v0.35.0. Most things should work with the fallback, too.
     names = ['mpv-2.dll', 'libmpv-2.dll', 'mpv-1.dll']
@@ -1056,7 +1057,13 @@ def _wait_for_future(self, result, timeout):
 
             global _core_foundation
             global _cf_runloop_default_mode
+            global _core_foundation_init_failed
+            
             start_time = time.monotonic()
+            
+            if _core_foundation_init_failed:
+                return result.result(timeout)
+            
             try:
                 if _core_foundation is None or _cf_runloop_default_mode is None:
                     core_foundation_path = ctypes.util.find_library('CoreFoundation')
@@ -1087,6 +1094,7 @@ def _wait_for_future(self, result, timeout):
             except ShutdownError:
                 raise
             except Exception as e:
+                _core_foundation_init_failed = True
                 # Fallback if CoreFoundation loading fails: use standard waiting behavior
                 warn(f"Failed to load CoreFoundation for mpv macOS event loop: {e}", RuntimeWarning)
                 if timeout is not None:

tests/test_mpv.py

@@ -1016,8 +1016,10 @@ def test_macos_wait_for_future(self):
             # Reset globals from mpv module to force re-initialization
             orig_cf = mpv._core_foundation
             orig_mode = mpv._cf_runloop_default_mode
+            orig_cf_failed = mpv._core_foundation_init_failed
             mpv._core_foundation = None
             mpv._cf_runloop_default_mode = None
+            mpv._core_foundation_init_failed = False
 
             def resolve_future():
                 time.sleep(0.1)
@@ -1059,8 +1061,10 @@ def test_macos_wait_for_future_timeout(self):
 
             orig_cf = mpv._core_foundation
             orig_mode = mpv._cf_runloop_default_mode
+            orig_cf_failed = mpv._core_foundation_init_failed
             mpv._core_foundation = None
             mpv._cf_runloop_default_mode = None
+            mpv._core_foundation_init_failed = False
 
             from concurrent.futures import TimeoutError
             try:
@@ -1071,6 +1075,7 @@ def test_macos_wait_for_future_timeout(self):
             finally:
                 mpv._core_foundation = orig_cf
                 mpv._cf_runloop_default_mode = orig_mode
+                mpv._core_foundation_init_failed = orig_cf_failed
 
     @mock.patch('sys.platform', 'darwin')
     def test_macos_wait_for_future_fallback(self):
@@ -1091,8 +1096,10 @@ def test_macos_wait_for_future_fallback(self):
 
             orig_cf = mpv._core_foundation
             orig_mode = mpv._cf_runloop_default_mode
+            orig_cf_failed = mpv._core_foundation_init_failed
             mpv._core_foundation = None
             mpv._cf_runloop_default_mode = None
+            mpv._core_foundation_init_failed = False
 
             def resolve_future():
                 time.sleep(0.1)
@@ -1112,3 +1119,4 @@ def resolve_future():
                 thread.join(timeout=1.0)
                 mpv._core_foundation = orig_cf
                 mpv._cf_runloop_default_mode = orig_mode
+                mpv._core_foundation_init_failed = orig_cf_failed