Allow json method to be called multiple times

Author: jeobrien

lib/user-data.js

@@ -17,7 +17,9 @@ export default class UserData {
   json() {
     const verificationSecret = this.getVerificationSecret();
     const identifier = this.getIdentifier();
-    this.setUserHash(verificationSecret, identifier);
+    if (this.settings.user_hash === undefined) {
+      this.setUserHash(verificationSecret, identifier);
+    }
     return this.escapedSettings(this.settings);
   }
   getVerificationSecret() {
@@ -41,6 +43,7 @@ export default class UserData {
       secretKey: verificationSecret,
       identifier
     });
+
     this.settings.user_hash = userHash;
   }
   escapedSettings(settings) {

package.json

@@ -19,8 +19,9 @@
   ],
   "dependencies": {
     "bluebird": "^3.3.4",
+    "htmlencode": "^0.0.4",
     "request": "^2.83.0",
-    "htmlencode": "^0.0.4"
+    "sinon": "^4.1.3"
   },
   "devDependencies": {
     "babel-core": "^6.7.4",

test/user-data.js

@@ -1,5 +1,6 @@
 import UserData from '../lib/user-data';
 import assert from 'assert';
+import sinon from 'sinon';
 
 describe('userData', () => {
   it('should be able to grab the verification secret', () => {
@@ -110,6 +111,20 @@ describe('userData', () => {
     assert.equal(Object.keys(result).indexOf(settings.verificationSecret), -1);
   });
 
+  it('should skip setUserHash if user_hash is already defined', () => {
+    const settings = {
+      verificationSecret: 'abc123',
+      app_id: 'xyz789',
+      user_id: 1
+    };
+    const userData = new UserData(settings);
+    const setUserHash = sinon.spy(userData, 'setUserHash');
+    userData.json();
+    userData.json();
+    setUserHash.restore();
+    sinon.assert.calledOnce(setUserHash);
+  });
+
   it('should return the userData', () => {
     const settings = {
       verificationSecret: 'abc123',