feat: allow ID searches for taxa/autocomplete (#501)

Part of WEB-574

Author: jotamayo97

lib/controllers/v1/taxa_controller.js

@@ -182,6 +182,7 @@ TaxaController.autocomplete = async req => {
   req.query.page = 1;
   // Make sure we don't show things that don't match all query tokens
   const inverseFilters = [];
+  const options = {};
   const filters = [
     {
       nested: {
@@ -197,6 +198,14 @@ TaxaController.autocomplete = async req => {
       }
     }
   ];
+
+  const isID = Number.isInteger( Number( q ) );
+
+  if ( isID ) {
+    options.filters = [];
+    options.filters.push( { terms: { id: [q] } } );
+  }
+
   if ( isActive !== null ) {
     filters.push( esClient.termFilter( "is_active", isActive ) );
   }
@@ -435,7 +444,7 @@ TaxaController.autocomplete = async req => {
     size: req.query.per_page
   };
 
-  const response = await TaxaController.searchQuery( req );
+  const response = await TaxaController.searchQuery( req, options );
   if ( response && response.results && exactResults ) {
     const exactResultIDs = _.map( exactResults, "id" );
     response.results = _.reject( response.results, r => _.includes( exactResultIDs, r.id ) );

lib/views/swagger_v1.yml.ejs

@@ -2909,12 +2909,12 @@ parameters:
     type: string
     in: query
     required: true
-    description: Name must begin with this value
+    description: Search by name (must start with this value) or by ID (exact match).
   autocomplete_q_not_required:
     name: q
     type: string
     in: query
-    description: Name must begin with this value
+    description: Search by name (must start with this value) or by ID (exact match).
   autocomplete_project_id:
     name: project_id
     type: integer

test/integration/v1/taxa.js

@@ -29,6 +29,19 @@ describe( "Taxa", ( ) => {
         .expect( 200, done );
     } );
 
+    it( "returns the correct taxon when searching by id", function ( done ) {
+      request( this.app ).get( "/v1/taxa/autocomplete?q=110" )
+        .expect( res => {
+          expect( res.body.page ).to.eq( 1 );
+          expect( res.body.per_page ).to.eq( 10 );
+          expect( res.body.total_results ).to.eq( 1 );
+          expect( res.body.results.length ).to.eq( 1 );
+          expect( res.body.results[0].id ).to.eq( 110 );
+          expect( res.body.results[0].name ).to.eq( "Mollusca" );
+        } ).expect( "Content-Type", /json/ )
+        .expect( 200, done );
+    } );
+
     it( "searches japanese characters", function ( done ) {
       request( this.app ).get( `/v1/taxa/autocomplete?q=${querystring.escape( "眼紋疏廣蠟蟬" )}` )
         .expect( res => {