refactor: set no_html to true when creating identifications

Author: pleary

lib/controllers/v1/identifications_controller.js

@@ -12,6 +12,8 @@ const InaturalistAPI = require( "../../inaturalist_api" );
 
 const IdentificationsController = class IdentificationsController {
   static async create( req ) {
+    req.body ||= { };
+    req.body.no_html = true;
     const response = await InaturalistAPI.iNatJSWrap( identifications.create, req );
     const arr = [{ identification_id: response.id }];
     const localeOpts = util.localeOpts( req );

test/integration/v1/identifications.js

@@ -2,6 +2,9 @@ const { expect } = require( "chai" );
 const request = require( "supertest" );
 const fs = require( "fs" );
 const _ = require( "lodash" );
+const jwt = require( "jsonwebtoken" );
+const nock = require( "nock" );
+const config = require( "../../../config" );
 
 const fixtures = JSON.parse( fs.readFileSync( "schema/fixtures.js" ) );
 
@@ -64,6 +67,28 @@ describe( "Identifications", ( ) => {
     } );
   } );
 
+  describe( "create", ( ) => {
+    it( "sets `no_html` to true for all passthrough requests", function ( done ) {
+      const token = jwt.sign( { user_id: 1 },
+        config.jwtSecret || "secret",
+        { algorithm: "HS512" } );
+      nock( "http://localhost:3000" )
+        .post( "/identifications", body => {
+          expect( body.no_html ).to.eq( true );
+          return body;
+        } )
+        .reply( 200, [] );
+      request( this.app ).post( "/v1/identifications", {
+        identification: {
+          observation_id: 1
+        }
+      } )
+        .set( "Authorization", token )
+        .expect( "Content-Type", /json/ )
+        .expect( 200, done );
+    } );
+  } );
+
   describe( "details", ( ) => {
     it( "never returns email or IP for user in identification", function ( done ) {
       request( this.app ).get( "/v1/identifications/2023092501" )