Skip to content

Commit 1928ba5

Browse files
committed
Add version 3.4.0
1 parent e953310 commit 1928ba5

6 files changed

Lines changed: 37 additions & 20 deletions

File tree

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
1+
## [3.4.0]
2+
3+
### Changed
4+
5+
* [react-native-photoeditorsdk] Raised minimum PhotoEditor Build SDK for Android version to 35
6+
* [react-native-photoeditorsdk] Raised Kotlin version to 2.1 and KSP to 2.1.0-1.0.28
7+
* [react-native-videoeditorsdk] Raised minimum PhotoEditor Build SDK for Android version to 35
8+
* [react-native-videoeditorsdk] Raised Kotlin version to 2.1 and KSP to 2.1.0-1.0.28
9+
10+
111
## [3.3.0]
212

313
### Changed

README.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,11 @@ In order to use this module with the Expo CLI you can make use of our integrated
7272
"ui:filter",
7373
"assets:filter-basic"
7474
],
75-
"buildToolsVersion": "34.0.0",
75+
"buildToolsVersion": "35.0.0",
7676
"minSdkVersion": "21",
77-
"compileSdkVersion": "34",
78-
"targetSdkVersion": "34",
79-
"kotlinGradlePluginVersion": "1.8.0"
77+
"compileSdkVersion": "35",
78+
"targetSdkVersion": "35",
79+
"kotlinGradlePluginVersion": "2.1.0"
8080
}
8181
}
8282
]
@@ -139,8 +139,8 @@ For older React Native versions autolinking is not available and VideoEditor SDK
139139
maven { url "https://artifactory.img.ly/artifactory/imgly" }
140140
}
141141
dependencies {
142-
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.0"
143-
classpath 'com.google.devtools.ksp:com.google.devtools.ksp.gradle.plugin:1.8.0-1.0.9' // KSP version is depending on your Kotlin version.
142+
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:2.1.0"
143+
classpath 'com.google.devtools.ksp:com.google.devtools.ksp.gradle.plugin:2.1.0-1.0.28' // KSP version is depending on your Kotlin version.
144144
classpath 'ly.img.android.sdk:plugin:10.9.0'
145145
}
146146
}
@@ -160,18 +160,18 @@ For older React Native versions autolinking is not available and VideoEditor SDK
160160
}
161161
```
162162

163-
3. In the same file, you will need to modify the `minSdkVersion` to at least `21`. We also recommend to update the `buildToolsVersion` to `34.0.0` or higher as well as the `compileSdkVersion` to `34` or higher but this is not mandatory:
163+
3. In the same file, you will need to modify the `minSdkVersion` to at least `21`. We also recommend to update the `buildToolsVersion` to `35.0.0` or higher as well as the `compileSdkVersion` to `35` or higher but this is not mandatory:
164164

165165
```diff
166166
buildscript {
167167
ext {
168168
- buildToolsVersion = "30.0.2"
169-
+ buildToolsVersion = "34.0.0"
169+
+ buildToolsVersion = "35.0.0"
170170
- minSdkVersion = 19
171171
+ minSdkVersion = 21
172-
- compileSdkVersion = 34
173-
+ compileSdkVersion = 34
174-
targetSdkVersion = 34
172+
- compileSdkVersion = 30
173+
+ compileSdkVersion = 35
174+
targetSdkVersion = 35
175175
}
176176
}
177177
```

android/build.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,12 @@ task checkVersion {
4040
preBuild.dependsOn checkVersion
4141

4242
android {
43-
compileSdkVersion safeExtGet('compileSdkVersion', 34)
44-
buildToolsVersion safeExtGet('buildToolsVersion', '34.0.0')
43+
compileSdkVersion safeExtGet('compileSdkVersion', 35)
44+
buildToolsVersion safeExtGet('buildToolsVersion', '35.0.0')
4545

4646
defaultConfig {
4747
minSdkVersion safeExtGet('minSdkVersion', 21)
48-
targetSdkVersion safeExtGet('targetSdkVersion', 34)
48+
targetSdkVersion safeExtGet('targetSdkVersion', 35)
4949
versionCode 1
5050
versionName "1.0"
5151
}

android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-all.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.5-all.zip

android/src/main/java/ly/img/react_native/vesdk/RNVideoEditorSDKModule.kt

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -182,12 +182,14 @@ class RNVideoEditorSDKModule(reactContext: ReactApplicationContext) : ReactConte
182182
}
183183
}
184184

185-
override fun onNewIntent(intent: Intent?) {
185+
override fun onNewIntent(intent: Intent) {
186186
}
187187

188188
@ReactMethod
189189
fun present(video: String, config: ReadableMap?, serialization: String?, promise: Promise) {
190-
val configuration = ConfigLoader.readFrom(config?.toHashMap() ?: mapOf())
190+
val rawConfig: Map<String, Any?> = config?.toHashMap() ?: emptyMap()
191+
val cleanConfig: Map<String, Any> = rawConfig.filterValues { it != null }.mapValues { it.value as Any }
192+
val configuration = ConfigLoader.readFrom(cleanConfig)
191193
val serializationEnabled = configuration.export?.serialization?.enabled == true
192194
val exportVideoSegments = configuration.export?.video?.segments == true
193195
val createTemporaryFiles = serializationEnabled || exportVideoSegments
@@ -211,7 +213,12 @@ class RNVideoEditorSDKModule(reactContext: ReactApplicationContext) : ReactConte
211213
val videoArray = deserializeVideoParts(videos)
212214
var source = resolveSize(size)
213215

214-
val configuration = ConfigLoader.readFrom(config?.toHashMap() ?: mapOf())
216+
val rawConfig: Map<String, Any?> = config?.toHashMap() ?: emptyMap()
217+
val cleanConfig: MutableMap<String, Any> = mutableMapOf()
218+
for ((key, value) in rawConfig) {
219+
if (value != null) cleanConfig[key] = value
220+
}
221+
val configuration = ConfigLoader.readFrom(cleanConfig)
215222
val serializationEnabled = configuration.export?.serialization?.enabled == true
216223
val exportVideoSegments = configuration.export?.video?.segments == true
217224
val createTemporaryFiles = serializationEnabled || exportVideoSegments

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "react-native-videoeditorsdk",
33
"title": "React Native module for VideoEditor SDK",
4-
"version": "3.3.0",
4+
"version": "3.4.0",
55
"description": "A React Native module for VideoEditor SDK. Integrate the video editor into your own HTML5, iOS or Android app - in minutes!",
66
"main": "index.js",
77
"typings": "index.d.ts",
@@ -35,6 +35,6 @@
3535
"react-native": ">=0.60.0 <1.0.x"
3636
},
3737
"dependencies": {
38-
"react-native-imglysdk": "3.3.0"
38+
"react-native-imglysdk": "3.4.0"
3939
}
4040
}

0 commit comments

Comments
 (0)