fix clippy lints

Author: ibraheemdev

.github/workflows/check.yml

@@ -57,6 +57,7 @@ jobs:
       - name: cargo clippy
         uses: giraffate/clippy-action@v1
         with:
+          clippy_flags: --workspace --all-targets --all-features -- -Dclippy::all
           reporter: 'github-pr-check'
           github_token: ${{ secrets.GITHUB_TOKEN }}
   semver:

examples/hyper.rs

@@ -96,7 +96,7 @@ async fn main() {
                 )
                 .await
             {
-                println!("Error serving connection: {:?}", err);
+                println!("Error serving connection: {err:?}");
             }
         });
     }

src/error.rs

@@ -117,7 +117,7 @@ impl MergeError {
 impl fmt::Display for MergeError {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         for error in self.0.iter() {
-            writeln!(f, "{}", error)?;
+            writeln!(f, "{error}")?;
         }
 
         Ok(())

src/lib.rs

@@ -123,7 +123,13 @@ by the number of children with registered values, increasing the chance of choos
 As it turns out, this method of routing is extremely fast. See the [benchmark results](https://github.com/ibraheemdev/matchit?tab=readme-ov-file#benchmarks) for details.
 */
 
-#![deny(rust_2018_idioms, clippy::all)]
+#![deny(
+    missing_debug_implementations,
+    missing_docs,
+    dead_code,
+    unsafe_op_in_unsafe_fn,
+    rustdoc::broken_intra_doc_links
+)]
 
 mod error;
 mod escape;

src/params.rs

@@ -27,6 +27,15 @@ impl<'k, 'v> Param<'k, 'v> {
     }
 }
 
+impl<'k, 'v> fmt::Debug for Param<'k, 'v> {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        f.debug_struct("Param")
+            .field("key", &self.key_str())
+            .field("value", &self.value_str())
+            .finish()
+    }
+}
+
 /// A list of parameters returned by a route match.
 ///
 /// ```rust
@@ -174,6 +183,7 @@ impl fmt::Debug for Params<'_, '_> {
 }
 
 /// An iterator over the keys and values of a route's [parameters](crate::Params).
+#[derive(Debug)]
 pub struct ParamsIter<'ps, 'k, 'v> {
     kind: ParamsIterKind<'ps, 'k, 'v>,
 }
@@ -188,6 +198,7 @@ impl<'ps, 'k, 'v> ParamsIter<'ps, 'k, 'v> {
     }
 }
 
+#[derive(Debug)]
 enum ParamsIterKind<'ps, 'k, 'v> {
     Small(iter::Take<slice::Iter<'ps, Param<'k, 'v>>>),
     Large(slice::Iter<'ps, Param<'k, 'v>>),

src/router.rs

@@ -132,6 +132,7 @@ impl<T> Router<T> {
         self.root.remove(path.into())
     }
 
+    /// Test helper that ensures route priorities are consistent.
     #[cfg(feature = "__test_helpers")]
     pub fn check_priorities(&self) -> Result<u32, (u32, u32)> {
         self.root.check_priorities()

tests/match.rs

@@ -63,6 +63,7 @@ fn overlapping_param_backtracking() {
 
 struct MatchTest {
     routes: Vec<&'static str>,
+    #[allow(clippy::type_complexity)]
     matches: Vec<(
         &'static str,
         &'static str,
@@ -88,8 +89,8 @@ impl MatchTest {
                     let got = x.params.iter().collect::<Vec<_>>();
                     assert_eq!(params.unwrap(), got);
 
-                    router.at_mut(path).unwrap().value.push_str("Z");
-                    assert!(router.at(path).unwrap().value.contains("Z"));
+                    router.at_mut(path).unwrap().value.push('Z');
+                    assert!(router.at(path).unwrap().value.contains('Z'));
                     router.at_mut(path).unwrap().value.pop();
                 }
                 Err(err) => {

tests/merge.rs

@@ -32,7 +32,7 @@ fn merge_conflict() {
     let errors = root.merge(child).unwrap_err();
 
     assert_eq!(
-        errors.get(0),
+        errors.first(),
         Some(&InsertError::Conflict {
             with: "/foo".into()
         })

tests/remove.rs

@@ -33,7 +33,7 @@ impl RemoveTest {
         }
 
         for route in self.remaining {
-            assert!(matches!(router.at(route), Ok(_)), "remaining {route}");
+            assert!(router.at(route).is_ok(), "remaining {route}");
         }
     }
 }