Fix panic in GetEQProfileV2 and improve error handling (#18)

* Fix refactor2

* Fix panic in GetEQProfileV2 and handle errors properly

- Add error checking before type assertion to prevent nil interface panic
- Change DeskModeSetting from int to float32 to match API response
- Handle and display errors in eq_profile command instead of ignoring them

Author: hilli

.gitignore

@@ -4,4 +4,6 @@ bin
 share
 fyne-cross
 dist/
-completions/
+completions/
+research
+

cmd/kefw2/cmd/eq_profile.go

@@ -35,7 +35,11 @@ var eqProfileCmd = &cobra.Command{
 	Args:  cobra.MaximumNArgs(1),
 	Run: func(cmd *cobra.Command, _ []string) {
 		ctx := cmd.Context()
-		eqProfile, _ := currentSpeaker.GetEQProfileV2(ctx)
+		eqProfile, err := currentSpeaker.GetEQProfileV2(ctx)
+		if err != nil {
+			fmt.Fprintf(cmd.ErrOrStderr(), "Error getting EQ profile: %v\n", err)
+			return
+		}
 		fmt.Println(eqProfile)
 	},
 }

kefw2/eqprofilev2.go

@@ -13,7 +13,7 @@ type EQProfileV2 struct {
 	Balance            int     `json:"balance"`            // Left/right balance (-10 to +10)
 	BassExtension      string  `json:"bassExtension"`      // Bass extension mode: "less", "standard", or "more"
 	DeskMode           bool    `json:"deskMode"`           // Whether desk mode is enabled
-	DeskModeSetting    int     `json:"deskModeSetting"`    // Desk mode compensation level
+	DeskModeSetting    float32 `json:"deskModeSetting"`    // Desk mode compensation level
 	HighPassMode       bool    `json:"highPassMode"`       // Whether high-pass filter is enabled (for use with subwoofer)
 	HighPassModeFreq   int     `json:"highPassModeFreq"`   // High-pass filter frequency in Hz
 	IsExpertMode       bool    `json:"isExpertMode"`       // Whether expert mode is enabled
@@ -38,7 +38,14 @@ type EQProfileV2 struct {
 // Each source can have its own EQ profile settings.
 func (s *KEFSpeaker) GetEQProfileV2(ctx context.Context) (EQProfileV2, error) {
 	eqProfile, err := JSONUnmarshalValue(s.getData(ctx, "kef:eqProfile/v2"))
-	return eqProfile.(EQProfileV2), err
+	if err != nil {
+		return EQProfileV2{}, err
+	}
+	profile, ok := eqProfile.(EQProfileV2)
+	if !ok {
+		return EQProfileV2{}, ErrUnknownType
+	}
+	return profile, nil
 }
 
 // String returns the EQ profile as a formatted JSON string.

kefw2/http.go

@@ -29,9 +29,10 @@ const (
 
 // Common errors.
 var (
-	ErrConnectionRefused = errors.New("connection refused")
-	ErrConnectionTimeout = errors.New("connection timed out")
-	ErrHostNotFound      = errors.New("host not found")
+	ErrConnectionRefused   = errors.New("connection refused")
+	ErrConnectionTimeout   = errors.New("connection timed out")
+	ErrHostNotFound        = errors.New("host not found")
+	ErrInvalidJSONResponse = errors.New("invalid JSON response")
 )
 
 // KEFPostRequest represents the JSON structure for POST requests to the KEF API.