Fix: Store URI and MimeType in track index for playback (#23)

* Fix: Store URI and MimeType in track index for playback

The track index was missing the audio file URI and MIME type,
which are required by the KEF speaker to play tracks. This caused
'upnp search' results to fail when playing or adding to queue,
while 'upnp browse' worked correctly (as it fetched full track data).

Changes:
- Add URI and MimeType fields to IndexedTrack struct
- Store these fields when building the index
- Include them when converting IndexedTrack back to ContentItem
- Bump index version to 2 (old indexes are auto-invalidated)
- Update CHANGELOG.md for v0.2.3

Users need to run 'kefw2 upnp index --rebuild' once after this update.

* Fix linting issues: godot, unused params, gosec, and more

- Add periods to all doc comments (godot)
- Rename unused function parameters to _ (unused-parameter)
- Use stricter file permissions 0750/0600 (gosec)
- Convert if-else chains to switch statements (staticcheck)
- Use http.NewRequestWithContext (noctx)
- Fix ineffective assignments (ineffassign)
- Preallocate slices where applicable (prealloc)
- Extract repeated strings to constants (goconst)
- Use assignment operators x += y (assignOp)
- Fix deprecated comment format (deprecatedComment)
- Fix spelling: Cancelled -> Canceled (misspell)

Reduces linting issues from 64 to 8 (only gocyclo warnings remain,
which are acceptable for TUI Update functions).

* Use CHANGELOG.md for GitHub release notes

Extract version-specific notes from CHANGELOG.md instead of
auto-generating from commit messages. The workflow now:
- Extracts the matching version section from CHANGELOG.md
- Strips the version header (GitHub shows the tag separately)
- Falls back to a link if no entry is found

Author: hilli

.github/workflows/release.yaml

@@ -20,11 +20,39 @@ jobs:
         with:
           go-version: '1.24'
           check-latest: true
+      - name: Extract release notes from CHANGELOG.md
+        run: |
+          # Strip 'v' prefix from tag to match CHANGELOG format
+          VERSION="${GITHUB_REF_NAME#v}"
+          echo "Extracting release notes for version: $VERSION"
+          
+          # Extract section for this version (from ## [x.y.z] to next ## [ or EOF)
+          # Skip the first line (version header) since GitHub shows the tag separately
+          awk -v ver="$VERSION" '
+            /^## \[/ {
+              if (found) exit
+              if ($0 ~ "\\[" ver "\\]") { found=1; next }
+            }
+            found { print }
+          ' CHANGELOG.md > /tmp/release-notes.md
+          
+          # Remove leading blank lines
+          sed -i '/./,$!d' /tmp/release-notes.md
+          
+          # Check if we found anything
+          if [ ! -s /tmp/release-notes.md ]; then
+            echo "Warning: No changelog entry found for version $VERSION"
+            echo "See [CHANGELOG.md](https://github.com/hilli/go-kef-w2/blob/main/CHANGELOG.md) for details." > /tmp/release-notes.md
+          fi
+          
+          echo "--- Release notes ---"
+          cat /tmp/release-notes.md
+          echo "--- End release notes ---"
       - name: Release
         uses: goreleaser/goreleaser-action@v6
         with:
           version: latest
-          args: release --clean
+          args: release --clean --release-notes=/tmp/release-notes.md
         env:
           GITHUB_TOKEN: ${{ secrets.PACKAGES_TOKEN }}
           MASTODON_CLIENT_ID: ${{ secrets.MASTODON_CLIENT_ID }}

.goreleaser.yaml

@@ -150,8 +150,4 @@ announce:
     server: https://mastodon.social
 
 changelog:
-  sort: asc
-  filters:
-    exclude:
-      - "^docs:"
-      - "^test:"
+  disable: true

CHANGELOG.md

@@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.2.3] - 2025-02-04
+
+### Fixed
+
+- Fixed playback from `upnp search` results - tracks now play and add to queue correctly
+  - The search index was missing audio file URIs required for playback
+  - Index version bumped to v2; run `kefw2 upnp index --rebuild` after updating
+
 ## [0.2.2] - 2025-02-03
 
 ### Added
@@ -358,7 +366,8 @@ Implemented by: `Source`, `SpeakerStatus`, `CableMode`
 
 7. **Update player ID field access**: If you access `playId.SystemMemberId`, change it to `playId.SystemMemberID`.
 
-[Unreleased]: https://github.com/hilli/go-kef-w2/compare/v0.2.2...HEAD
+[Unreleased]: https://github.com/hilli/go-kef-w2/compare/v0.2.3...HEAD
+[0.2.3]: https://github.com/hilli/go-kef-w2/compare/v0.2.2...v0.2.3
 [0.2.2]: https://github.com/hilli/go-kef-w2/compare/v0.2.1...v0.2.2
 [0.2.1]: https://github.com/hilli/go-kef-w2/compare/v0.2.0...v0.2.1
 [0.2.0]: https://github.com/hilli/go-kef-w2/compare/v0.1.0...v0.2.0

cmd/kefw2/cmd/browser_styles.go

@@ -23,7 +23,7 @@ package cmd
 
 import "github.com/charmbracelet/lipgloss"
 
-// ServiceType represents the type of content service (radio, podcast, upnp)
+// ServiceType represents the type of content service (radio, podcast, upnp).
 type ServiceType string
 
 const (
@@ -32,14 +32,14 @@ const (
 	ServiceUPnP    ServiceType = "upnp"
 )
 
-// ServiceColors defines the color scheme for each service type
+// ServiceColors defines the color scheme for each service type.
 var ServiceColors = map[ServiceType]lipgloss.Color{
 	ServiceRadio:   lipgloss.Color("39"),  // Blue for radio
 	ServicePodcast: lipgloss.Color("207"), // Pink/magenta for podcast
 	ServiceUPnP:    lipgloss.Color("214"), // Orange for UPnP
 }
 
-// BrowserStyles holds styled renderers for the content browser TUI
+// BrowserStyles holds styled renderers for the content browser TUI.
 type BrowserStyles struct {
 	Title    lipgloss.Style
 	Search   lipgloss.Style
@@ -50,7 +50,7 @@ type BrowserStyles struct {
 	Dimmed   lipgloss.Style
 }
 
-// NewBrowserStyles creates a new set of browser styles for the given service type
+// NewBrowserStyles creates a new set of browser styles for the given service type.
 func NewBrowserStyles(service ServiceType) BrowserStyles {
 	color := ServiceColors[service]
 	if color == "" {
@@ -87,11 +87,11 @@ func NewBrowserStyles(service ServiceType) BrowserStyles {
 	}
 }
 
-// Common styles used across all services
+// Common styles used across all services.
 var (
-	// containerSuffix is shown after container names
+	// containerSuffix is shown after container names.
 	containerSuffix = "/"
 
-	// maxVisibleItems is the number of items visible in the picker at once
+	// maxVisibleItems is the number of items visible in the picker at once.
 	maxVisibleItems = 15
 )

cmd/kefw2/cmd/cache.go

@@ -33,7 +33,7 @@ import (
 	"github.com/spf13/viper"
 )
 
-// CachedItem represents a cached content item for completion
+// CachedItem represents a cached content item for completion.
 type CachedItem struct {
 	Title       string `json:"title"`
 	Path        string `json:"path"`         // Actual API path
@@ -42,24 +42,24 @@ type CachedItem struct {
 	Description string `json:"description"`  // Optional description
 }
 
-// CacheEntry represents a cached response for a browse path
+// CacheEntry represents a cached response for a browse path.
 type CacheEntry struct {
 	Items     []CachedItem `json:"items"`
 	FetchedAt time.Time    `json:"fetched_at"`
 }
 
-// BrowseCache provides caching for hierarchical path completion
+// BrowseCache provides caching for hierarchical path completion.
 type BrowseCache struct {
 	cacheDir string
 	entries  map[string]*CacheEntry
 	mu       sync.RWMutex
 	dirty    bool // Track if cache needs saving
 }
 
-// Global cache instance
+// Global cache instance.
 var browseCache *BrowseCache
 
-// NewBrowseCache creates a new browse cache
+// NewBrowseCache creates a new browse cache.
 func NewBrowseCache() (*BrowseCache, error) {
 	cacheDir, err := os.UserCacheDir()
 	if err != nil {
@@ -69,7 +69,7 @@ func NewBrowseCache() (*BrowseCache, error) {
 	cacheDir = filepath.Join(cacheDir, "kefw2")
 
 	// Create cache directory if it doesn't exist
-	if err := os.MkdirAll(cacheDir, 0755); err != nil {
+	if err := os.MkdirAll(cacheDir, 0750); err != nil {
 		return nil, fmt.Errorf("failed to create cache directory: %w", err)
 	}
 
@@ -84,7 +84,7 @@ func NewBrowseCache() (*BrowseCache, error) {
 	return cache, nil
 }
 
-// InitCache initializes the global browse cache
+// InitCache initializes the global browse cache.
 func InitCache() {
 	var err error
 	browseCache, err = NewBrowseCache()
@@ -97,18 +97,18 @@ func InitCache() {
 	}
 }
 
-// cacheFilePath returns the path to the cache file
+// cacheFilePath returns the path to the cache file.
 func (c *BrowseCache) cacheFilePath() string {
 	return filepath.Join(c.cacheDir, "browse_cache.json")
 }
 
-// IsEnabled returns whether caching is enabled
+// IsEnabled returns whether caching is enabled.
 func (c *BrowseCache) IsEnabled() bool {
 	return viper.GetBool("cache.enabled")
 }
 
-// GetTTL returns the TTL for a given service type
-// Defaults are set in root.go initConfig(): default=300, radio=300, podcast=300, upnp=60
+// GetTTL returns the TTL for a given service type.
+// Defaults are set in root.go initConfig(): default=300, radio=300, podcast=300, upnp=60.
 func (c *BrowseCache) GetTTL(service string) time.Duration {
 	key := fmt.Sprintf("cache.ttl_%s", service)
 	seconds := viper.GetInt(key)
@@ -122,7 +122,7 @@ func (c *BrowseCache) GetTTL(service string) time.Duration {
 	return time.Duration(seconds) * time.Second
 }
 
-// Get retrieves items from cache if valid
+// Get retrieves items from cache if valid.
 func (c *BrowseCache) Get(path string, service string) ([]CachedItem, bool) {
 	if !c.IsEnabled() {
 		return nil, false
@@ -146,7 +146,7 @@ func (c *BrowseCache) Get(path string, service string) ([]CachedItem, bool) {
 	return entry.Items, true
 }
 
-// Set stores items in cache
+// Set stores items in cache.
 func (c *BrowseCache) Set(path string, service string, items []CachedItem) {
 	if !c.IsEnabled() {
 		return
@@ -163,7 +163,7 @@ func (c *BrowseCache) Set(path string, service string, items []CachedItem) {
 	c.dirty = true
 }
 
-// Clear removes all cached data
+// Clear removes all cached data.
 func (c *BrowseCache) Clear() error {
 	c.mu.Lock()
 	defer c.mu.Unlock()
@@ -175,7 +175,7 @@ func (c *BrowseCache) Clear() error {
 	return os.Remove(c.cacheFilePath())
 }
 
-// Status returns cache statistics
+// Status returns cache statistics.
 func (c *BrowseCache) Status() (entries int, size int64, oldestAge time.Duration) {
 	c.mu.RLock()
 	defer c.mu.RUnlock()
@@ -201,7 +201,7 @@ func (c *BrowseCache) Status() (entries int, size int64, oldestAge time.Duration
 	return
 }
 
-// Load loads cache from disk
+// Load loads cache from disk.
 func (c *BrowseCache) Load() error {
 	c.mu.Lock()
 	defer c.mu.Unlock()
@@ -223,7 +223,7 @@ func (c *BrowseCache) Load() error {
 	return nil
 }
 
-// Save persists cache to disk
+// Save persists cache to disk.
 func (c *BrowseCache) Save() error {
 	c.mu.Lock()
 	defer c.mu.Unlock()
@@ -246,20 +246,20 @@ func (c *BrowseCache) Save() error {
 		return err
 	}
 
-	if err := os.WriteFile(c.cacheFilePath(), data, 0644); err != nil {
+	if err := os.WriteFile(c.cacheFilePath(), data, 0600); err != nil {
 		return err
 	}
 
 	c.dirty = false
 	return nil
 }
 
-// CacheDir returns the cache directory path
+// CacheDir returns the cache directory path.
 func (c *BrowseCache) CacheDir() string {
 	return c.cacheDir
 }
 
-// FindItemByTitle finds a cached item by its title within a parent path
+// FindItemByTitle finds a cached item by its title within a parent path.
 func (c *BrowseCache) FindItemByTitle(parentPath, service, title string) (*CachedItem, bool) {
 	items, ok := c.Get(parentPath, service)
 	if !ok {
@@ -274,8 +274,8 @@ func (c *BrowseCache) FindItemByTitle(parentPath, service, title string) (*Cache
 	return nil, false
 }
 
-// ResolveDisplayPath resolves a display path (title-based) to an API path
-// Returns the API path and the last item, or empty string if not found
+// ResolveDisplayPath resolves a display path (title-based) to an API path.
+// Returns the API path and the last item, or empty string if not found.
 func (c *BrowseCache) ResolveDisplayPath(displayPath, service string) (string, *CachedItem, bool) {
 	if displayPath == "" {
 		return "", nil, true // Empty path = top level, no API path needed
@@ -318,7 +318,7 @@ func (c *BrowseCache) ResolveDisplayPath(displayPath, service string) (string, *
 // Cache Command
 // ============================================
 
-// cacheCmd represents the cache command
+// cacheCmd represents the cache command.
 var cacheCmd = &cobra.Command{
 	Use:   "cache",
 	Short: "Manage browse cache for tab completion",
@@ -328,11 +328,11 @@ The cache stores browse results to speed up tab completion.
 Cache location: ~/.cache/kefw2/`,
 }
 
-// cacheClearCmd clears the cache
+// cacheClearCmd clears the cache.
 var cacheClearCmd = &cobra.Command{
 	Use:   "clear",
 	Short: "Clear all cached browse data",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		if browseCache == nil {
 			errorPrinter.Println("Cache not initialized")
 			return
@@ -345,11 +345,11 @@ var cacheClearCmd = &cobra.Command{
 	},
 }
 
-// cacheStatusCmd shows cache status
+// cacheStatusCmd shows cache status.
 var cacheStatusCmd = &cobra.Command{
 	Use:   "status",
 	Short: "Show cache statistics",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		// Get cache directory
 		cacheDir, err := os.UserCacheDir()
 		if err != nil {
@@ -361,7 +361,7 @@ var cacheStatusCmd = &cobra.Command{
 		rowsCachePath := filepath.Join(cacheDir, "rows_cache.json")
 		if info, err := os.Stat(rowsCachePath); err == nil {
 			// Read and parse the cache file to count entries
-			data, readErr := os.ReadFile(rowsCachePath)
+			data, readErr := os.ReadFile(rowsCachePath) //nolint:gosec // Path is constructed from user's cache dir
 			var entryCount int
 			var oldestAge time.Duration
 			if readErr == nil {
@@ -422,7 +422,7 @@ var cacheStatusCmd = &cobra.Command{
 	},
 }
 
-// formatBytes formats bytes as human-readable string
+// formatBytes formats bytes as human-readable string.
 func formatBytes(bytes int64) string {
 	const unit = 1024
 	if bytes < unit {