[TASK] Add further test to make sure view helper is rendered

helhum · helhum · commit 5ffe41a1f026 · 2018-11-02T13:30:16.000+01:00
diff --git a/.travis.yml b/.travis.yml
@@ -23,7 +23,7 @@ before_install:
   - phpenv config-rm xdebug.ini
 
 install:
-  - composer require typo3/cms=$TYPO3_VERSION
+  - composer require typo3/minimal=$TYPO3_VERSION
   - export TYPO3_PATH_WEB="$PWD/.Build/Web"
 
 script:
diff --git a/Tests/Functional/Fixtures/Frontend/Basic.ts b/Tests/Functional/Fixtures/Frontend/Basic.ts
@@ -30,6 +30,10 @@ lib.link {
 lib.fluid = FLUIDTEMPLATE
 lib.fluid.file = EXT:typoscript_rendering/Tests/Functional/Fixtures/Frontend/Template.html
 
+lib.viewHelper = FLUIDTEMPLATE
+lib.viewHelper.file = EXT:typoscript_rendering/Tests/Functional/Fixtures/Frontend/ViewHelperTemplate.html
+tt_content.typoscriptrendering_plugintest.20 = TEXT
+
 page = PAGE
 page {
 	10 = TEXT
diff --git a/Tests/Functional/Fixtures/Frontend/Template.html b/Tests/Functional/Fixtures/Frontend/Template.html
@@ -1 +1,5 @@
-<f:link.email email="info@helhum.io" />
+<html xmlns="http://www.w3.org/1999/xhtml"
+			xmlns:f="http://typo3.org/ns/TYPO3/Fluid/ViewHelpers"
+			data-namespace-typo3-fluid="true">
+<f:link.email email="info@helhum.io" />
+</html>
diff --git a/Tests/Functional/Fixtures/Frontend/ViewHelperTemplate.html b/Tests/Functional/Fixtures/Frontend/ViewHelperTemplate.html
@@ -0,0 +1,6 @@
+<html xmlns="http://www.w3.org/1999/xhtml"
+			xmlns:f="http://typo3.org/ns/TYPO3/Fluid/ViewHelpers"
+			xmlns:t="http://typo3.org/ns/Helhum/TyposcriptRendering/ViewHelpers"
+			data-namespace-typo3-fluid="true">
+<t:uri.ajaxAction controller="Foo" pluginName="pluginTest" extensionName="TyposcriptRendering" contextRecord="currentPage"/>
+</html>
diff --git a/Tests/Functional/RenderingTest.php b/Tests/Functional/RenderingTest.php
@@ -22,7 +22,7 @@ public function urlGeneratedRespectAbsRefPrefixAndLinkVarsAndTarget()
     {
         $requestArguments = ['url' => $this->getRenderUrl(1, 1, 'lib.link')];
         $expectedContent = '<a href="/index.php?id=1&amp;L=1" target="_blank">link</a>';
-        $this->assertSame($expectedContent, $this->fetchFrontendResponse($requestArguments)->getContent());
+        $this->assertSame($expectedContent, trim($this->fetchFrontendResponse($requestArguments)->getContent()));
     }
 
     /**
@@ -32,6 +32,16 @@ public function emailViewHelperWorksAlsoWithSpamProtection()
     {
         $requestArguments = ['url' => $this->getRenderUrl(1, 1, 'lib.fluid')];
         $expectedContent = '<a href="javascript:linkTo_UnCryptMailto(\'ocknvq,kphqBjgnjwo0kq\');">info(AT)helhum(DOT)io</a>';
-        $this->assertSame($expectedContent, $this->fetchFrontendResponse($requestArguments)->getContent());
+        $this->assertSame($expectedContent, trim($this->fetchFrontendResponse($requestArguments)->getContent()));
+    }
+
+    /**
+     * @test
+     */
+    public function viewHelperOutputsUri()
+    {
+        $requestArguments = ['url' => $this->getRenderUrl(1, 1, 'lib.viewHelper')];
+        $expectedContent = '/index.php?id=1&amp;L=1&amp;tx_typoscriptrendering%5Bcontext%5D=%7B%22record%22%3A%22pages_1%22%2C%22path%22%3A%22tt_content.typoscriptrendering_plugintest.20%22%7D&amp;tx_typoscriptrendering_plugintest%5Bcontroller%5D=Foo&amp;cHash=';
+        $this->assertSame(0, strpos(trim($this->fetchFrontendResponse($requestArguments)->getContent()), $expectedContent));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ public function urlGeneratedRespectAbsRefPrefixAndLinkVarsAndTarget()`
`22`	`22`	`{`
`23`	`23`	`$requestArguments = ['url' => $this->getRenderUrl(1, 1, 'lib.link')];`
`24`	`24`	`$expectedContent = '<a href="/index.php?id=1&L=1" target="_blank">link</a>';`
`25`		`- $this->assertSame($expectedContent, $this->fetchFrontendResponse($requestArguments)->getContent());`
	`25`	`+ $this->assertSame($expectedContent, trim($this->fetchFrontendResponse($requestArguments)->getContent()));`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`/**`
`@@ -32,6 +32,16 @@ public function emailViewHelperWorksAlsoWithSpamProtection()`
`32`	`32`	`{`
`33`	`33`	`$requestArguments = ['url' => $this->getRenderUrl(1, 1, 'lib.fluid')];`
`34`	`34`	`$expectedContent = '<a href="javascript:linkTo_UnCryptMailto(\'ocknvq,kphqBjgnjwo0kq\');">info(AT)helhum(DOT)io</a>';`
`35`		`- $this->assertSame($expectedContent, $this->fetchFrontendResponse($requestArguments)->getContent());`
	`35`	`+ $this->assertSame($expectedContent, trim($this->fetchFrontendResponse($requestArguments)->getContent()));`
	`36`	`+ }`
	`37`	`+`
	`38`	`+ /**`
	`39`	`+ * @test`
	`40`	`+ */`
	`41`	`+ public function viewHelperOutputsUri()`
	`42`	`+ {`
	`43`	`+ $requestArguments = ['url' => $this->getRenderUrl(1, 1, 'lib.viewHelper')];`
	`44`	`+ $expectedContent = '/index.php?id=1&L=1&tx_typoscriptrendering%5Bcontext%5D=%7B%22record%22%3A%22pages_1%22%2C%22path%22%3A%22tt_content.typoscriptrendering_plugintest.20%22%7D&tx_typoscriptrendering_plugintest%5Bcontroller%5D=Foo&cHash=';`
	`45`	`+ $this->assertSame(0, strpos(trim($this->fetchFrontendResponse($requestArguments)->getContent()), $expectedContent));`
`36`	`46`	`}`
`37`	`47`	`}`