[Bug]: `finalize_round` endpoint bypasses DAO finalization logic (missing close_date, audit log)

[userAdityaa]

Description:

The finalize_round endpoint at admin_endpoints.py sets rnd.status = FINALIZED_STATUS directly on the ORM object instead of calling the proper DAO methods (finalize_rating_round or finalize_ranking_round). This means:

• close_date is never set on the round
• Update status to finalized
• No audit log entry is created

Steps to Reproduce:

1. Create a campaign, add a round, activate it, and complete all voting
2. Finalize the round via the endpoint
3. Check the round's close_date in the database, it is NULL
4. Check the audit log, no finalize_round entry exists

Expected Behavior

Finalizing a round should perform all required finalization actions, including:

• Set close_date to the current timestamp
• Create an audit log entry for the finalization action
• For ranking rounds: create a RoundResultsSummary
• For rating rounds: store the final_threshold in the configuration

Actual Behavior

Only the status field is changed. All other finalization side-effects are skipped.

[lgelauff]

The bug is real, but the scope is narrower than described.

finalize_round is a standalone "close this round" action — it is not responsible for computing the advancing group or storing the threshold. Those are determined at the point of creating the next round via advance_round, where the coordinator selects a threshold and the advancing entries are calculated. The final_threshold stored in the closing round's config is a side effect of that decision, not something finalize_round should set. In fact, the threshold is more associated with starting the next round, than closing the current: if we just close, no threshold is needed.

The actual fix needed is:

• Set close_date
• Update status to finalized
• Write an audit log entry (to be verified)

No threshold logic, no result summaries. Those belong in advance_round and finalize_campaign respectively, where they already live.

[ayushshukla1807]

Got it, that scope makes sense for result summaries and thresholds handling. My PR #466 routes it directly to coord_dao.finalize_round to catch the close_date properly. Appreciate the heads up!