test(settings): isolate settings writes from local settings.json

Author: grinev

tests/helpers/test-environment.ts

@@ -1,10 +1,34 @@
+import fs from "node:fs";
+import os from "node:os";
+import path from "node:path";
+
+function getDefaultTestHome(): string {
+  const workerId = process.env.VITEST_WORKER_ID || "0";
+  const preferredPath = path.join(process.cwd(), ".tmp", "test-home", `${process.pid}-${workerId}`);
+
+  try {
+    fs.mkdirSync(preferredPath, { recursive: true });
+    return preferredPath;
+  } catch {
+    const fallbackPath = path.join(
+      os.tmpdir(),
+      "opencode-telegram-bot",
+      "test-home",
+      `${process.pid}-${workerId}`,
+    );
+    fs.mkdirSync(fallbackPath, { recursive: true });
+    return fallbackPath;
+  }
+}
+
 const TEST_ENV_DEFAULTS: Record<string, string> = {
   TELEGRAM_BOT_TOKEN: "test-telegram-token",
   TELEGRAM_ALLOWED_USER_ID: "123456789",
   OPENCODE_API_URL: "http://localhost:4096",
   OPENCODE_MODEL_PROVIDER: "test-provider",
   OPENCODE_MODEL_ID: "test-model",
   LOG_LEVEL: "error",
+  OPENCODE_TELEGRAM_HOME: getDefaultTestHome(),
 };
 
 export function ensureTestEnvironment(): void {

tests/summary/aggregator.test.ts

@@ -1,12 +1,26 @@
 import { beforeEach, describe, expect, it, vi } from "vitest";
 import type { Event } from "@opencode-ai/sdk/v2";
 import { summaryAggregator } from "../../src/summary/aggregator.js";
-import { __resetSettingsForTests, setCurrentProject } from "../../src/settings/manager.js";
+
+const mocked = vi.hoisted(() => ({
+  getCurrentProjectMock: vi.fn(),
+}));
+
+vi.mock("../../src/settings/manager.js", async () => {
+  const actual = await vi.importActual<typeof import("../../src/settings/manager.js")>(
+    "../../src/settings/manager.js",
+  );
+
+  return {
+    ...actual,
+    getCurrentProject: mocked.getCurrentProjectMock,
+  };
+});
 
 describe("summary/aggregator", () => {
   beforeEach(() => {
-    __resetSettingsForTests();
-    setCurrentProject({ id: "p1", worktree: "D:/repo", name: "repo" });
+    mocked.getCurrentProjectMock.mockReset();
+    mocked.getCurrentProjectMock.mockReturnValue({ id: "p1", worktree: "D:/repo", name: "repo" });
     summaryAggregator.clear();
     summaryAggregator.setOnCleared(() => {});
     summaryAggregator.setOnTool(() => {});

tests/summary/formatter.test.ts

@@ -1,11 +1,25 @@
-import { beforeEach, describe, expect, it } from "vitest";
+import { beforeEach, describe, expect, it, vi } from "vitest";
 import { formatSummary, formatToolInfo, prepareCodeFile } from "../../src/summary/formatter.js";
-import { __resetSettingsForTests, setCurrentProject } from "../../src/settings/manager.js";
+
+const mocked = vi.hoisted(() => ({
+  getCurrentProjectMock: vi.fn(),
+}));
+
+vi.mock("../../src/settings/manager.js", async () => {
+  const actual = await vi.importActual<typeof import("../../src/settings/manager.js")>(
+    "../../src/settings/manager.js",
+  );
+
+  return {
+    ...actual,
+    getCurrentProject: mocked.getCurrentProjectMock,
+  };
+});
 
 describe("summary/formatter", () => {
   beforeEach(() => {
-    __resetSettingsForTests();
-    setCurrentProject({ id: "p1", worktree: "D:/repo", name: "repo" });
+    mocked.getCurrentProjectMock.mockReset();
+    mocked.getCurrentProjectMock.mockReturnValue({ id: "p1", worktree: "D:/repo", name: "repo" });
   });
 
   it("formats summary text and splits long output", () => {