fix(bot): send silent model replies and notify on final footer

Author: grinev

src/bot/index.ts

@@ -780,7 +780,6 @@ async function ensureEventSubscription(directory: string): Promise<void> {
               elapsedMs: Date.now() - completedRun.startedAt,
             }),
             {
-              disable_notification: true,
               ...(keyboard ? { reply_markup: keyboard } : {}),
             },
           );

src/bot/utils/finalize-assistant-response.ts

@@ -16,7 +16,12 @@ interface FinalizeAssistantResponseOptions {
   sendText: (
     text: string,
     rawFallbackText: string | undefined,
-    options: { reply_markup: unknown } | undefined,
+    options:
+      | {
+          reply_markup?: unknown;
+          disable_notification?: boolean;
+        }
+      | undefined,
     format: TelegramTextFormat,
   ) => Promise<void>;
 }
@@ -36,9 +41,12 @@ export async function finalizeAssistantResponse({
 }: FinalizeAssistantResponseOptions): Promise<boolean> {
   const keyboard = getReplyKeyboard();
   const replyOptions = keyboard ? { reply_markup: keyboard } : undefined;
-  const streamSendOptions = {
+  const silentReplyOptions = {
     disable_notification: true,
     ...(replyOptions ?? {}),
+  };
+  const streamSendOptions = {
+    ...silentReplyOptions,
   } as StreamingMessagePayload["sendOptions"];
 
   const preparedStreamPayload = prepareStreamingPayload(messageText);
@@ -69,7 +77,7 @@ export async function finalizeAssistantResponse({
   for (let partIndex = 0; partIndex < parts.length; partIndex++) {
     const part = parts[partIndex];
     const rawFallbackText = rawParts[partIndex];
-    await sendText(part, rawFallbackText, replyOptions, format);
+    await sendText(part, rawFallbackText, silentReplyOptions, format);
   }
 
   return false;

tests/bot/utils/finalize-assistant-response.test.ts

@@ -36,14 +36,14 @@ describe("bot/utils/finalize-assistant-response", () => {
       1,
       "part 1",
       "part 1",
-      { reply_markup: keyboard },
+      { disable_notification: true, reply_markup: keyboard },
       "markdown_v2",
     );
     expect(sendText).toHaveBeenNthCalledWith(
       2,
       "part 2",
       "part 2",
-      { reply_markup: keyboard },
+      { disable_notification: true, reply_markup: keyboard },
       "markdown_v2",
     );
   });
@@ -104,6 +104,6 @@ describe("bot/utils/finalize-assistant-response", () => {
     });
 
     expect(sendText).toHaveBeenCalledTimes(1);
-    expect(sendText).toHaveBeenCalledWith("reply", "reply", undefined, "raw");
+    expect(sendText).toHaveBeenCalledWith("reply", "reply", { disable_notification: true }, "raw");
   });
 });