Merge pull request #2 from spotandjake/spotandjake-412

feat!: Update cmake to `4.1.2`

Author: ospencer

.clang-format

@@ -1,5 +1,5 @@
 ---
-# This configuration requires clang-format version 15 exactly.
+# This configuration requires clang-format version 18 exactly.
 BasedOnStyle: Mozilla
 AlignOperands: false
 AllowShortFunctionsOnASingleLine: InlineOnly
@@ -16,6 +16,7 @@ BraceWrapping:
 BreakBeforeBraces: Custom
 ColumnLimit: 79
 IndentPPDirectives: AfterHash
+QualifierAlignment: Right
 SortUsingDeclarations: false
 SpaceAfterTemplateKeyword: true
 IncludeBlocks: Regroup

.clang-tidy

@@ -2,33 +2,52 @@
 Checks: "-*,\
 bugprone-*,\
 -bugprone-assignment-in-if-condition,\
+-bugprone-crtp-constructor-accessibility,\
 -bugprone-easily-swappable-parameters,\
+-bugprone-empty-catch,\
 -bugprone-implicit-widening-of-multiplication-result,\
+-bugprone-inc-dec-in-conditions,\
 -bugprone-macro-parentheses,\
--bugprone-misplaced-widening-cast,\
+-bugprone-multi-level-implicit-pointer-conversion,\
 -bugprone-narrowing-conversions,\
+-bugprone-return-const-ref-from-parameter,\
+-bugprone-suspicious-stringview-data-usage,\
+-bugprone-switch-missing-default-case,\
 -bugprone-too-small-loop-variable,\
 -bugprone-unchecked-optional-access,\
+-bugprone-unused-local-non-trivial-variable,\
+-bugprone-unused-return-value,\
+-bugprone-use-after-move,\
 misc-*,\
 -misc-confusable-identifiers,\
 -misc-const-correctness,\
--misc-no-recursion,\
+-misc-include-cleaner,\
 -misc-non-private-member-variables-in-classes,\
+-misc-no-recursion,\
 -misc-static-assert,\
 -misc-use-anonymous-namespace,\
+-misc-use-internal-linkage,\
 modernize-*,\
 -modernize-avoid-c-arrays,\
+-modernize-concat-nested-namespaces,\
 -modernize-macro-to-enum,\
 -modernize-return-braced-init-list,\
+-modernize-type-traits,\
 -modernize-use-emplace,\
 -modernize-use-nodiscard,\
 -modernize-use-noexcept,\
 -modernize-use-trailing-return-type,\
 -modernize-use-transparent-functors,\
 performance-*,\
--performance-inefficient-vector-operation,\
+-performance-avoid-endl,\
+-performance-enum-size,\
+-performance-unnecessary-copy-initialization,\
+-performance-unnecessary-value-param,\
 readability-*,\
+-readability-avoid-nested-conditional-operator,\
+-readability-avoid-unconditional-preprocessor-if,\
 -readability-convert-member-functions-to-static,\
+-readability-enum-initial-value,\
 -readability-function-cognitive-complexity,\
 -readability-function-size,\
 -readability-identifier-length,\
@@ -37,12 +56,13 @@ readability-*,\
 -readability-inconsistent-declaration-parameter-name,\
 -readability-magic-numbers,\
 -readability-make-member-function-const,\
+-readability-math-missing-parentheses,\
 -readability-named-parameter,\
--readability-redundant-declaration,\
--readability-redundant-member-init,\
 -readability-simplify-boolean-expr,\
+-readability-static-accessed-through-instance,\
 -readability-suspicious-call-argument,\
 -readability-uppercase-literal-suffix,\
+-readability-use-std-min-max,\
 cmake-*,\
 -cmake-ostringstream-use-cmstrcat,\
 -cmake-string-concatenation-use-cmstrcat,\

.codespellrc

@@ -4,5 +4,59 @@ check-hidden =
 # Disable warnings about binary files
 quiet-level = 2
 builtin = clear,rare,en-GB_to_en-US
-skip = */.git,*/build,*/Copyright.txt,*/CTestCustom.cmake.in,*/doxygen.config,*/Modules/Internal/CPack/NSIS.template.in,*/Source/CursesDialog/form/*,*/Source/kwsys/*,*/Tests/RunCMake/CPack/tests/DMG_SLA/German.*,*/Tests/RunCMake/ParseImplicitData/*.input,*/Tests/StringFileTest/test.utf8,*.pfx,*/Utilities/cm*
-ignore-words-list = aci,ags,ake,ans,ba,ccompiler,cconfiguration,certi,conly,dependees,dne,dum,earch,ect,filetest,fo,helpfull,hiden,isnt,keypair,nd,ned,nin,nknown,ot,pard,seh,ser,te,upto,varn,vas,wee
+
+# Skip paths matching fnmatch glob patterns.
+skip =
+  .git,
+  .typos.toml,
+  build,
+  CONTRIBUTORS.rst,
+  CTestCustom.cmake.in,
+  Modules/Internal/CPack/NSIS.template.in,
+  Source/CursesDialog/form/*,
+  Source/kwsys/*,
+  Tests/RunCMake/CPack/tests/DMG_SLA/German.*,
+  Tests/RunCMake/ParseImplicitData/*.input,
+  Tests/StringFileTest/test.utf8,
+  Utilities/cm*,
+  *.pfx,
+
+# noqa: spellcheck off
+ignore-words-list =
+  abd,
+  aci,
+  ags,
+  ake,
+  ans,
+  ba,
+  ccompiler,
+  cconfiguration,
+  certi,
+  conly,
+  copyin,
+  dependees,
+  dne,
+  dum,
+  earch,
+  ect,
+  filetest,
+  fo,
+  helpfull,
+  hiden,
+  isnt,
+  keypair,
+  nd,
+  ned,
+  nin,
+  nknown,
+  ot,
+  pard,
+  sectionin,
+  seh,
+  ser,
+  te,
+  upto,
+  varn,
+  vas,
+  wee,
+# noqa: spellcheck on

.gitattributes

@@ -1,15 +1,22 @@
 .git*            export-ignore
 .hooks*          export-ignore
+.clang-format    export-ignore
+.clang-tidy      export-ignore
 .codespellrc     export-ignore
 .editorconfig    export-ignore
+.pre-commit-config.yaml export-ignore
+.typos.toml      export-ignore
 
 # Custom attribute to mark sources as using our C code style.
-[attr]our-c-style  whitespace=tab-in-indent  format.clang-format=15
+[attr]our-c-style  whitespace=tab-in-indent  format.clang-format=18
 
 # Custom attribute to mark sources as generated.
 # Do not perform whitespace checks.  Do not format.
 [attr]generated  whitespace=-tab-in-indent,-indent-with-non-tab -format.clang-format
 
+# Custom attribute to mark files as TABs indented.
+[attr]tab-indent whitespace=-tab-in-indent
+
 bootstrap        eol=lf
 configure        eol=lf
 *.[1-9]          eol=lf
@@ -19,9 +26,28 @@ configure        eol=lf
 
 *.bat            eol=crlf
 *.bat.in         eol=crlf
+*.cmd            eol=crlf
 *.sln            eol=crlf
 *.vcproj         eol=crlf
 
+Makefile         tab-indent
+Makefile.in      tab-indent
+NSIS.template.in tab-indent
+coverage.xml.in  tab-indent
+*.F              tab-indent
+*.f              tab-indent
+*.pbxproj.in     tab-indent
+*.plist.in       tab-indent
+*.plist          tab-indent
+*.sln            tab-indent
+*.s              tab-indent
+*.vcproj         tab-indent
+*.vcproj.in      tab-indent
+*.vfproj.in      tab-indent
+*.xib            tab-indent
+*.make           tab-indent
+.hooks-config    tab-indent
+
 *.pfx            -text
 *.png            -text
 *.png.in         -text
@@ -31,8 +57,10 @@ configure        eol=lf
 *.cpp            our-c-style
 *.cu             our-c-style
 *.cxx            our-c-style
+*.H              our-c-style
 *.h              our-c-style
 *.hh             our-c-style
+*.hip            our-c-style
 *.hpp            our-c-style
 *.hxx            our-c-style
 *.notcu          our-c-style

.github/workflows/esy.yml

@@ -0,0 +1,76 @@
+name: Esy
+on:
+  - push
+  - pull_request
+
+jobs:
+  build:
+    name: Build and test
+    runs-on: ${{ matrix.os }}
+
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, macos-latest, windows-latest]
+
+    steps:
+      - name: Setup node.js
+        uses: actions/setup-node@cdca7365b2dadb8aad0a33bc7601856ffabcc48e # v4.3.0
+        with:
+          node-version: "22"
+          check-latest: true
+
+      # Install `esy` to build the project
+      # It also adds `shx` globally for cross-platform shell commands
+      - name: Setup environment
+        run: |
+          npm i -g esy@0.8.0
+          npm i -g shx
+
+      - name: Checkout project
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          submodules: "recursive"
+
+      - name: Install local dependencies
+        run: |
+          esy install
+
+      - name: Esy cache
+        id: esy-cache
+        uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3
+        with:
+          path: _export
+          key: ${{ runner.os }}-esy-${{ hashFiles('esy.lock/index.json') }}
+
+      - name: Import esy cache
+        if: steps.esy-cache.outputs.cache-hit == 'true'
+        run: |
+          esy import-dependencies _export
+          shx rm -rf _export
+
+      # Build the project in release to make sure deps are specified correctly
+      - name: Build release dependencies
+        if: steps.esy-cache.outputs.cache-hit != 'true'
+        run: |
+          esy build-dependencies --release
+
+      - name: Build project in release
+        run: |
+          esy build --release
+
+      # Then build in non-release so we can test
+      - name: Build dependencies
+        if: steps.esy-cache.outputs.cache-hit != 'true'
+        run: |
+          esy build-dependencies
+
+      - name: Build project
+        run: |
+          esy build
+
+      # Re-export dependencies if anything has changed or if it is the first time
+      - name: Build esy cache
+        if: steps.esy-cache.outputs.cache-hit != 'true'
+        run: |
+          esy export-dependencies

.github/workflows/test-build.yml

@@ -1,8 +1,15 @@
+# Help tools that honor '.gitignore' (redundant for Git itself).
+/.git
+
 /CMakeUserPresets.json
 
 # Common build directories
 /build*/
 
+# CI jobs that run in symlinked trees produce these artifacts.
+/real_work/
+/work
+
 # MacOS Finder files.
 .DS_Store
 
@@ -29,6 +36,10 @@
 # Visual Studio build directory
 /out/
 
+# clang-tidy output
+/clang-tidy-fixes.patch
+
+# esy
 Bootstrap.cmk
 _esy
 node_modules