Skip to content

Commit f9c122a

Browse files
authored
chore(datastore): Clean up a few test files with new V3 changes (#12987)
gRPC Transport is the new default so there is no need to explicitly set it.
1 parent 24fb234 commit f9c122a

3 files changed

Lines changed: 13 additions & 40 deletions

File tree

java-datastore/google-cloud-datastore/src/test/java/com/google/cloud/datastore/DatastoreOptionsTest.java

Lines changed: 10 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import com.google.api.gax.grpc.ChannelPoolSettings;
2828
import com.google.api.gax.grpc.InstantiatingGrpcChannelProvider;
2929
import com.google.cloud.NoCredentials;
30-
import com.google.cloud.TransportOptions;
3130
import com.google.cloud.datastore.spi.DatastoreRpcFactory;
3231
import com.google.cloud.datastore.spi.v1.DatastoreRpc;
3332
import com.google.cloud.datastore.v1.DatastoreSettings;
@@ -217,7 +216,6 @@ public void testGrpcDefaultChannelConfigurations() {
217216
.setServiceRpcFactory(datastoreRpcFactory)
218217
.setProjectId(PROJECT_ID)
219218
.setDatabaseId(DATABASE_ID)
220-
.setTransportOptions((TransportOptions) GrpcTransportOptions.newBuilder().build())
221219
.setCredentials(NoCredentials.getInstance())
222220
.setHost("http://localhost:" + PORT)
223221
.build();
@@ -250,7 +248,6 @@ public void testCustomChannelAndCredentials() {
250248
.setServiceRpcFactory(datastoreRpcFactory)
251249
.setProjectId(PROJECT_ID)
252250
.setDatabaseId(DATABASE_ID)
253-
.setTransportOptions((TransportOptions) GrpcTransportOptions.newBuilder().build())
254251
.setChannelProvider(channelProvider)
255252
.setCredentials(NoCredentials.getInstance())
256253
.setHost("http://localhost:" + PORT)
@@ -262,63 +259,50 @@ public void testCustomChannelAndCredentials() {
262259
public void testTransport() {
263260
// default grpc transport
264261
assertThat(options.build().getTransportOptions()).isInstanceOf(GrpcTransportOptions.class);
265-
266-
// custom http transport
267-
DatastoreOptions httpTransportOptions =
262+
DatastoreOptions grpcTransportOptions =
268263
DatastoreOptions.newBuilder()
269-
.setTransportOptions(HttpTransportOptions.newBuilder().build())
270264
.setProjectId(PROJECT_ID)
271265
.setCredentials(NoCredentials.getInstance())
272266
.build();
273-
assertThat(httpTransportOptions.getTransportOptions()).isInstanceOf(HttpTransportOptions.class);
267+
assertThat(grpcTransportOptions.getTransportOptions()).isInstanceOf(GrpcTransportOptions.class);
268+
assertThat(grpcTransportOptions.getTransportChannelProvider())
269+
.isInstanceOf(InstantiatingGrpcChannelProvider.class);
274270

275-
// custom grpc transport
276-
DatastoreOptions grpcTransportOptions =
271+
// custom http transport
272+
DatastoreOptions httpTransportOptions =
277273
DatastoreOptions.newBuilder()
278-
.setTransportOptions((TransportOptions) GrpcTransportOptions.newBuilder().build())
274+
.setTransportOptions(HttpTransportOptions.newBuilder().build())
279275
.setProjectId(PROJECT_ID)
280276
.setCredentials(NoCredentials.getInstance())
281277
.build();
282-
assertThat(grpcTransportOptions.getTransportOptions()).isInstanceOf(GrpcTransportOptions.class);
283-
assertThat(grpcTransportOptions.getTransportChannelProvider())
284-
.isInstanceOf(InstantiatingGrpcChannelProvider.class);
278+
assertThat(httpTransportOptions.getTransportOptions()).isInstanceOf(HttpTransportOptions.class);
285279
}
286280

287281
@Test
288282
public void testHostWithGrpcAndHttp() {
289283
DatastoreOptions grpcTransportOptions =
290284
DatastoreOptions.newBuilder()
291-
.setTransportOptions((TransportOptions) GrpcTransportOptions.newBuilder().build())
292285
.setProjectId(PROJECT_ID)
293286
.setCredentials(NoCredentials.getInstance())
294287
.build();
295288
assertThat(grpcTransportOptions.getHost()).isEqualTo(DatastoreSettings.getDefaultEndpoint());
296-
assertThat(grpcTransportOptions.getHost()).isEqualTo("datastore.googleapis.com:443");
297289

298290
String customHost = "http://localhost:" + PORT;
299291
DatastoreOptions grpcTransportOptionsCustomHost =
300292
DatastoreOptions.newBuilder()
301-
.setTransportOptions((TransportOptions) GrpcTransportOptions.newBuilder().build())
302293
.setHost(customHost)
303294
.setProjectId(PROJECT_ID)
304295
.setCredentials(NoCredentials.getInstance())
305296
.build();
306297
assertThat(grpcTransportOptionsCustomHost.getHost()).isEqualTo(customHost);
307298

308-
DatastoreOptions defaultTransportOptions =
309-
DatastoreOptions.newBuilder()
310-
.setProjectId(PROJECT_ID)
311-
.setCredentials(NoCredentials.getInstance())
312-
.build();
313-
assertThat(defaultTransportOptions.getHost()).isEqualTo(DatastoreSettings.getDefaultEndpoint());
314-
315-
DatastoreOptions httpTransportOptions =
299+
DatastoreOptions httpJsonTransportOptions =
316300
DatastoreOptions.newBuilder()
317301
.setTransportOptions(HttpTransportOptions.newBuilder().build())
318302
.setProjectId(PROJECT_ID)
319303
.setCredentials(NoCredentials.getInstance())
320304
.build();
321-
assertThat(httpTransportOptions.getHost()).isEqualTo(DatastoreFactory.DEFAULT_HOST);
305+
assertThat(httpJsonTransportOptions.getHost()).isEqualTo(DatastoreFactory.DEFAULT_HOST);
322306

323307
DatastoreOptions httpTransportOptionsCustomHost =
324308
DatastoreOptions.newBuilder()

java-datastore/google-cloud-datastore/src/test/java/com/google/cloud/datastore/it/ITDatastoreClientSideMetrics.java

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import com.google.cloud.datastore.Entity;
2828
import com.google.cloud.datastore.Key;
2929
import com.google.cloud.datastore.telemetry.TelemetryConstants;
30-
import com.google.cloud.grpc.GrpcTransportOptions;
3130
import io.opentelemetry.api.common.AttributeKey;
3231
import io.opentelemetry.sdk.OpenTelemetrySdk;
3332
import io.opentelemetry.sdk.metrics.SdkMeterProvider;
@@ -120,13 +119,8 @@ public void setUp() {
120119
.setMetricsEnabled(true)
121120
.setOpenTelemetry(customOtel)
122121
.setExportBuiltinMetricsToGoogleCloudMonitoring(false)
123-
.build());
124-
125-
if (transportOptions instanceof GrpcTransportOptions) {
126-
builder.setTransportOptions(transportOptions);
127-
} else {
128-
builder.setTransportOptions(transportOptions);
129-
}
122+
.build())
123+
.setTransportOptions(transportOptions);
130124

131125
datastore = builder.build().getService();
132126

java-datastore/google-cloud-datastore/src/test/java/com/google/cloud/datastore/testing/RemoteDatastoreHelper.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import com.google.cloud.datastore.Query;
2727
import com.google.cloud.datastore.QueryResults;
2828
import com.google.cloud.datastore.StructuredQuery;
29-
import com.google.cloud.grpc.GrpcTransportOptions;
3029
import com.google.cloud.http.HttpTransportOptions;
3130
import io.opentelemetry.sdk.OpenTelemetrySdk;
3231
import java.time.Duration;
@@ -113,11 +112,7 @@ public static RemoteDatastoreHelper create(
113112
.setDatabaseId(databaseId)
114113
.setNamespace(UUID.randomUUID().toString())
115114
.setRetrySettings(retrySettings());
116-
if (transportOptions instanceof GrpcTransportOptions) {
117-
datastoreOptionBuilder = datastoreOptionBuilder.setTransportOptions(transportOptions);
118-
} else {
119-
datastoreOptionBuilder = datastoreOptionBuilder.setTransportOptions(transportOptions);
120-
}
115+
datastoreOptionBuilder = datastoreOptionBuilder.setTransportOptions(transportOptions);
121116

122117
if (openTelemetrySdk != null) {
123118
datastoreOptionBuilder.setOpenTelemetryOptions(

0 commit comments

Comments
 (0)