Merge pull request #408 from fsprojects/repo-assist/improve-sideeffects-naming-20260425-edfad27e8fbe8b06

[Repo Assist] test: rename SideEffect → SideEffects in Concat, Delay, and Item tests

Author: dsyme

release-notes.txt

@@ -2,6 +2,7 @@
 Release notes:
 
 Unreleased
+    - test: rename `SideEffect` module to `SideEffects` in TaskSeq.Concat.Tests.fs, TaskSeq.Delay.Tests.fs, and TaskSeq.Item.Tests.fs for consistency with the rest of the test suite (50+ files already use the plural form)
     - test: add SideEffects module to TaskSeq.Using.Tests.fs; 7 new tests verify Dispose/DisposeAsync call counts, re-iteration semantics, and early-termination disposal for use and use! CE bindings
     - perf: pairwise, distinctUntilChanged, distinctUntilChangedWith, distinctUntilChangedWithAsync now use explicit enumerator + while! instead of ValueOption tracking + for-in loop, eliminating per-element struct match overhead
     - test: add SideEffects module to TaskSeq.Unfold.Tests.fs, verifying generator call counts, re-iteration behaviour, early-termination via take, and exception propagation

src/FSharp.Control.TaskSeq.Test/TaskSeq.Concat.Tests.fs

@@ -181,7 +181,7 @@ module Immutable =
             |> consumeTaskSeq
         |> should throwAsyncExact typeof<NullReferenceException>
 
-module SideEffect =
+module SideEffects =
     [<Fact>]
     let ``TaskSeq-concat executes side effects of nested (taskseq)`` () =
         let mutable i = 0

src/FSharp.Control.TaskSeq.Test/TaskSeq.Delay.Tests.fs

@@ -30,7 +30,7 @@ module Immutable =
         |> TaskSeq.delay
         |> validateSequence
 
-module SideEffect =
+module SideEffects =
     [<Fact>]
     let ``TaskSeq-delay executes side effects`` () = task {
         let mutable i = 0

src/FSharp.Control.TaskSeq.Test/TaskSeq.Item.Tests.fs

@@ -105,7 +105,7 @@ module Immutable =
         tail |> should equal (Some 10)
     }
 
-module SideEffect =
+module SideEffects =
     [<Theory; ClassData(typeof<TestSideEffectTaskSeq>)>]
     let ``TaskSeq-item prove it searches the whole sequence`` variant = task {
         let ts = Gen.getSeqWithSideEffect variant