Merge remote-tracking branch 'upstream/master' into symtridiag

Author: Mahmood-Sinan

.github/workflows/ci_big_endian.yml

@@ -0,0 +1,68 @@
+name: CI - Big-Endian
+
+on:
+  # Always run on pushes to the main branch
+  push:
+    branches: [master, main]
+  # For PRs, ONLY run if the hash files or this workflow change
+  pull_request:
+    paths:
+      - '.github/workflows/ci_big_endian.yml'
+      - 'src/hash/**'
+      - 'test/hash_functions/**'
+  # Allow manual triggers from the GitHub Actions tab
+  workflow_dispatch:
+
+env:
+  CTEST_TIME_TIMEOUT: "5"  # some failures hang forever
+
+jobs:
+  test-big-endian:
+    runs-on: ubuntu-24.04
+    name: Test on s390x (big-endian)
+    strategy:
+      fail-fast: false
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Build and test on s390x
+        uses: uraimo/run-on-arch-action@v3
+        with:
+          arch: s390x
+          distro: ubuntu24.04
+
+          # Cache Docker image layer in GitHub Package Registry
+          githubToken: ${{ github.token }}
+
+          # Install dependencies (cached in Docker image layer)
+          install: |
+            apt-get update -q -y
+            apt-get install -q -y gfortran gcc g++ cmake python3-pip ninja-build git
+            pip3 install --break-system-packages fypp
+
+          # Build and run big-endian tests
+          run: |
+            echo "=== Architecture Info ==="
+            uname -m
+            echo "Byte order: $(python3 -c 'import sys; print(sys.byteorder)')"
+
+            echo "=== Compiler Version ==="
+            gfortran --version
+
+            echo "=== CMake Configure ==="
+            cmake -G Ninja \
+              -DCMAKE_BUILD_TYPE=Release \
+              -DCMAKE_MAXIMUM_RANK:String=4 \
+              -DFIND_BLAS:STRING=FALSE \
+              -S . -B build
+
+            echo "=== Build (Targeted) ==="
+            cmake --build build --target test_hash_functions --parallel
+
+            echo "=== Run Big-Endian Tests ==="
+            ctest --test-dir build \
+              -R hash_functions \
+              --output-on-failure \
+              --no-tests=error

.github/workflows/fpm-deployment.yml

@@ -46,6 +46,10 @@ jobs:
           python config/fypp_deployment.py --with_xdp --with_qp
           fpm test --profile release --flag '-DWITH_XDP -DWITH_QP'
 
+      - run: | # Tests without xdp and qp
+          python config/fypp_deployment.py
+          fpm test --profile release
+
       # Update and deploy the f90 files generated by github-ci to the `stdlib-fpm` branch.
       - name: Deploy 🚀
         uses: JamesIves/github-pages-deploy-action@4.1.5

CMakeLists.txt

@@ -4,8 +4,8 @@ cmake_minimum_required(VERSION 3.14.0)
 set(CMAKE_USER_MAKE_RULES_OVERRIDE ${CMAKE_CURRENT_SOURCE_DIR}/config/DefaultFlags.cmake)
 
 project(fortran_stdlib
-	LANGUAGES Fortran C
-        DESCRIPTION "Community driven and agreed upon de facto standard library for Fortran"
+  LANGUAGES Fortran C
+  DESCRIPTION "Community driven and agreed upon de facto standard library for Fortran"
 )
 
 # Read version from file
@@ -116,8 +116,19 @@ endif()
 
 # --- find preprocessor
 find_program(FYPP fypp)
-if(NOT FYPP)
-  message(FATAL_ERROR "Preprocessor fypp not found! Please install fypp following the instructions in https://fypp.readthedocs.io/en/stable/fypp.html#installing")
+if(NOT FYPP OR "${FYPP}" MATCHES "NOTFOUND")
+  message(FATAL_ERROR 
+    "\n [stdlib Build Error]: Preprocessor 'fypp' not found!\n"
+    " ------------------------------------------------------------------------\n"
+    " The fypp preprocessor is required to generate Fortran source from templates.\n\n"
+    " Please install fypp following the instructions at https://github.com/aradi/fypp\n\n"
+    " To diagnose your installation, please run the following in your terminal:\n"
+    "   Windows:      'where fypp' and 'where python'\n"
+    "   Linux/macOS:  'which fypp' and 'which python'\n\n"
+    " Ensure the executable is in your PATH or set it manually during configuration:\n"
+    "   cmake -B build -DFYPP_EXECUTABLE=/path/to/fypp\n"
+    " ------------------------------------------------------------------------\n"
+  )
 endif()
 
 # Custom preprocessor flags
@@ -156,4 +167,4 @@ install(EXPORT ${PROJECT_NAME}-targets
 )
 
 # Export a pkg-config file
-include(${PROJECT_SOURCE_DIR}/config/export_pc.cmake)
+include(${PROJECT_SOURCE_DIR}/config/export_pc.cmake)

cmake/stdlib.cmake

@@ -10,6 +10,12 @@
 #
 function(preprocess preproc preprocopts srcext trgext srcfiles trgfiles)
 
+  # Defensive check: Ensure the preprocessor path is valid before defining custom commands.
+  # This prevents "empty command" errors during the build phase.
+  if(NOT preproc OR "${preproc}" MATCHES "NOTFOUND")
+    message(FATAL_ERROR "preprocess function called with invalid preprocessor path: '${preproc}'")
+  endif()
+
   set(_trgfiles)
   foreach(srcfile IN LISTS srcfiles)
     get_filename_component(filename ${srcfile} NAME)
@@ -87,8 +93,8 @@ function(configure_stdlib_target target_name regular_sources_var fypp_files_var
     endif()
 
     set(LIB_MOD_DIR ${CMAKE_CURRENT_BINARY_DIR}/mod_files/${target_name}/)
-    #set(INSTALL_MOD_DIR "${CMAKE_INSTALL_MODULEDIR}/${target_name}")
     set(INSTALL_MOD_DIR "${CMAKE_INSTALL_MODULEDIR}")
+    
     # We need the module directory before we finish the configure stage since the
     # build interface might resolve before the module directory is generated by CMake
     if(NOT EXISTS "${LIB_MOD_DIR}")
@@ -115,7 +121,7 @@ endfunction()
 # Determine if a module will be compiled
 #
 # Defines a CMake function that creates an ON/OFF option for a given stdlib module,
-#sets a compile definition accordingly, and prints its enabled/disabled status.
+# sets a compile definition accordingly, and prints its enabled/disabled status.
 #
 # Args:
 #     module [in]: Name of the module to be compiled
@@ -133,4 +139,4 @@ function(check_modular module)
         add_compile_definitions(STDLIB_${umodule}=0)
     endif()
 
-endfunction()
+endfunction()

doc/specs/index.md

@@ -35,6 +35,7 @@ This is an index/directory of the specifications (specs) for each new module/fea
  - [stats_distributions_uniform](./stdlib_stats_distribution_uniform.html) - Uniform Probability Distribution
  - [stats_distributions_normal](./stdlib_stats_distribution_normal.html) - Normal Probability Distribution
  - [stats_distributions_exponential](./stdlib_stats_distribution_exponential.html) - Exponential Probability Distribution
+ - [stats_distributions_gamma](./stdlib_stats_distribution_gamma.html) - Gamma Probability Distribution
  - [string\_type](./stdlib_string_type.html) - Basic string support
  - [stringlist_type](./stdlib_stringlist_type.html) - 1-Dimensional list of strings
  - [strings](./stdlib_strings.html) - String handling and manipulation routines

doc/specs/stdlib_hash_procedures.md

@@ -394,6 +394,16 @@ generating seeds for `universal_mult_hash`.
 All assume a two's complement sign bit, and no out of
 range checks.
 
+**Endianness note:** Both `pengy_hash` and `spooky_hash` will produce
+different hash values on big-endian processors (e.g., s390x, SPARC,
+PowerPC) compared to little-endian processors (e.g., x86, ARM, RISC-V)
+for the same input bytes. The hash quality is equally good on both
+architectures, but the outputs are not cross-architecture portable.
+Do not use these hashes for cross-architecture verification (e.g.,
+hashing a file on an x86 system and verifying the hash on an IBM
+mainframe). The 32-bit hashes `nmhash32`, `nmhash32x`, and
+`water_hash` produce identical results on all architectures.
+
 The `stdlib_hash_32bit_fnv` and `stdlib_hash_64bit_fnv`
 submodules each provide implementations of the FNV-1 and FNV-1A
 algorithms in the form of two separate overloaded functions: `FNV_1`
@@ -1366,6 +1376,9 @@ performance on long keys. It passes all the SMHasher tests, and has
 no known bad seeds.
 It is a *pure* function for integer arrays, and an *elemental*
 function for character strings.
+Note that `pengy_hash` will produce different hash values on
+big-endian and little-endian processors for the same input. The hash
+quality is equally good on both architectures.
 
 ##### Example