[chore] rayon feature clippy changes

Author: wilhelmagren

src/chunked/arrow_converter.rs

@@ -63,7 +63,7 @@ unsafe impl Send for MasterBuilders {}
 unsafe impl Sync for MasterBuilders {}
 
 impl MasterBuilders {
-    pub fn writer_factory<'a>(&mut self, out_file: &PathBuf) -> ArrowWriter<File> {
+    pub fn writer_factory(&mut self, out_file: &PathBuf) -> ArrowWriter<File> {
         let _out_file = fs::OpenOptions::new()
             .create(true)
             .append(true)
@@ -86,8 +86,8 @@ impl MasterBuilders {
         writer
     }
 
-    pub fn builders_factory<'a>(schema_path: PathBuf, instances: i16) -> Self {
-        let schema = schema::FixedSchema::from_path(schema_path.into()).unwrap();
+    pub fn builders_factory(schema_path: PathBuf, instances: i16) -> Self {
+        let schema = schema::FixedSchema::from_path(schema_path).unwrap();
         let antal_col = schema.num_columns();
         let mut builders: Vec<Vec<Box<dyn ColumnBuilder + Sync + Send>>> = Vec::new();
 

src/chunked/mod.rs

@@ -58,11 +58,11 @@ pub(crate) struct Stats {
 pub(crate) type FnLineBreakLen = fn() -> usize;
 #[allow(dead_code)]
 pub(crate) fn line_break_len_cr() -> usize {
-    1 as usize
+    1_usize
 }
 #[allow(dead_code)]
 pub(crate) fn line_break_len_crlf() -> usize {
-    2 as usize
+    2_usize
 }
 
 pub(crate) type FnFindLastLineBreak<'a> = fn(bytes: &'a [u8]) -> (bool, usize);
@@ -142,6 +142,7 @@ impl<'a, T> Iterator for IterRevolver<'a, T> {
     }
 }
 
+#[allow(dead_code)]
 pub(crate) trait Converter<'a> {
     fn set_line_break_handler(&mut self, fn_line_break: FnFindLastLineBreak<'a>);
     fn get_line_break_handler(&self) -> FnFindLastLineBreak<'a>;
@@ -165,7 +166,7 @@ fn column_length_num_rightaligned(data: &[u8], runes: i16) -> (usize, usize) {
     let stop: usize = min(data.len(), runes as usize);
 
     while counted_runes < runes as usize {
-        let byten = eat.nth(0);
+        let byten = eat.next();
         let bb: u8 = match byten {
             None => {
                 //TODO  we ran out of data,this is an error, fix later.
@@ -174,10 +175,8 @@ fn column_length_num_rightaligned(data: &[u8], runes: i16) -> (usize, usize) {
             Some(b) => *b,
         };
 
-        match bb {
-            48..=57 => return (start, stop),
-            _ => {}
-        };
+        if let 48..=57 = bb { return (start, stop) }
+
         start += 1;
         counted_runes += 1;
     }
@@ -192,7 +191,7 @@ fn column_length_char_rightaligned(data: &[u8], runes: i16) -> (usize, usize) {
     let stop: usize = min(data.len(), runes as usize);
 
     while counted_runes < runes as usize {
-        let byten = eat.nth(0);
+        let byten = eat.next();
         let bb: u8 = match byten {
             None => {
                 //TODO  we ran out of data,this is an error, fix later.

src/chunked/slicer.rs

@@ -124,7 +124,7 @@ impl<'a> Slicer<'a> for OldSlicer<'a> {
 
         match converter.finish() {
             Ok(x) => Result::Ok(Stats {
-                bytes_in: bytes_in,
+                bytes_in,
                 bytes_out: converter.get_finish_bytes_written(),
                 num_rows: x.num_rows,
             }),
@@ -145,9 +145,7 @@ fn residual_to_slice<'a>(
     if 0 != residue_effective_len {
         target_chunk_residue.copy_from_slice(&residue[0..residue_effective_len]);
     }
-    let mut r: Vec<&[u8]> = vec![];
-
-    r.push(target_chunk_residue);
+    let r: Vec<&[u8]> = vec![target_chunk_residue];
     r
 }
 

src/cli.rs

@@ -274,7 +274,7 @@ impl Cli {
                 in_file,
                 out_file,
             } => {
-                let _in_file = fs::File::open(&in_file)?;
+                let _in_file = fs::File::open(in_file)?;
 
                 let mut slicer_instance: Box<dyn Slicer> = Box::new(OldSlicer {
                     fn_find_last_nl: find_last_nl,
@@ -313,7 +313,7 @@ impl Cli {
                 let stats = slicer_instance.slice_and_convert(
                     converter_instance,
                     _in_file,
-                    n_threads as usize,
+                    n_threads,
                 )?;
 
                 info!(

src/converter.rs

@@ -232,7 +232,7 @@ impl Converter {
     fn spawn_convert_threads(
         &mut self,
         buffer: &Vec<u8>,
-        line_breaks: &Vec<usize>,
+        line_breaks: &[usize],
         thread_workloads: &Vec<(usize, usize)>,
     ) -> Result<()> {
         let (sender, receiver) = channel::bounded(self.thread_channel_capacity);