fix: fixes pre v0.3.1 (#15)

Author: jjcfrancisco

README.md

@@ -9,9 +9,7 @@
 FastPFOR library written in Rust. Currently in development.
 
 ## To do:
-- [ ] Remove fast_pack0 function: noop
-- [ ] Implement traits for fastpfor
-- [ ] Change Ok(()) to FastPForResult in fastpfor.rs
+- [ ] Rust wrapper for the [C++ library](https://github.com/fast-pack/FastPFor): try [`cxxbridge`](https://github.com/dtolnay/cxx) or [`bindgen`](https://crates.io/crates/bindgen)
 
 ## License
 

src/bitpacking.rs

@@ -2,7 +2,7 @@
 
 pub fn fast_pack(input: &[i32], inpos: usize, output: &mut [i32], outpos: usize, bit: isize) {
     match bit {
-        0 => fast_pack0(input, inpos, output, outpos),
+        0 => (),
         1 => fast_pack1(input, inpos, output, outpos),
         2 => fast_pack2(input, inpos, output, outpos),
         3 => fast_pack3(input, inpos, output, outpos),
@@ -39,11 +39,6 @@ pub fn fast_pack(input: &[i32], inpos: usize, output: &mut [i32], outpos: usize,
     }
 }
 
-#[expect(unused_variables)]
-fn fast_pack0(input: &[i32], inpos: usize, output: &mut [i32], outpos: usize) {
-    // Nothing
-}
-
 fn fast_pack1(input: &[i32], inpos: usize, output: &mut [i32], outpos: usize) {
     output[0 + outpos] = (input[0 + inpos] >> 0) & 1;
     output[1 + outpos] = (input[0 + inpos] >> 1) & 1;

src/fastpfor.rs

@@ -33,7 +33,7 @@ impl Compressor<i32> for FastPFOR {
         let inlength = helpers::greatest_multiple(input_length, self.block_size as i32);
         if self.block_size == BLOCK_SIZE_256 && inlength == 0 {
             // Return early if there is no data to compress
-            return Ok(());
+            return FastPForResult::Ok(());
         }
         output[output_offset.position() as usize] = inlength;
         output_offset.increment();
@@ -44,7 +44,7 @@ impl Compressor<i32> for FastPFOR {
             let this_size = std::cmp::min(self.page_size, final_inpos - pos);
             self.encode_page(input, input_offset, this_size, output, output_offset);
         }
-        Ok(())
+        FastPForResult::Ok(())
     }
 
     fn uncompress(
@@ -57,7 +57,7 @@ impl Compressor<i32> for FastPFOR {
     ) -> FastPForResult<()> {
         if inlength == 0 {
             // Return early if there is no data to compress
-            return Ok(());
+            return FastPForResult::Ok(());
         }
         let outlength = input[input_offset.position() as usize];
         input_offset.increment();
@@ -68,7 +68,7 @@ impl Compressor<i32> for FastPFOR {
                 std::cmp::min(self.page_size, final_out - output_offset.position() as i32);
             self.decode_page(input, input_offset, output, output_offset, this_size);
         }
-        Ok(())
+        FastPForResult::Ok(())
     }
 }