Skip to content

Commit c80e497

Browse files
yutannihilationCopilotnyurik
authored
chore(deps): Update the FastPFOR C++ library to v0.3.1 (#62)
Currently, the build fails on macOS with this error. It seems something is wrong with this version of FastPFOR's `cmake_modules/simde.cmake`. Fortunately, it seems it's fixed in [the latest release](https://github.com/fast-pack/FastPFOR/releases/tag/v0.3.1). So, this pull request updates the C++ library. (Honestly, I'm not sure what problem this is and why this works now. The only change on the file was that specifying the commit hash of simde's repository (fast-pack/FastPFOR@f7771da)) ``` Building for architecture: arm64 CMake Error at cmake_modules/simde.cmake:9 (add_library): add_library cannot create imported target "simde" because another target with the same name already exists. Call Stack (most recent call first): CMakeLists.txt:47 (include) ``` --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Yuri Astrakhan <YuriAstrakhan@gmail.com>
1 parent d971a22 commit c80e497

2 files changed

Lines changed: 18 additions & 4 deletions

File tree

.github/workflows/ci.yml

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,30 @@ defaults:
1313

1414
jobs:
1515
test:
16-
name: Test
17-
runs-on: ubuntu-latest
16+
name: Test on ${{ matrix.os }}
17+
runs-on: ${{ matrix.os }}
18+
strategy:
19+
fail-fast: true
20+
matrix:
21+
include:
22+
- os: ubuntu-latest
23+
- os: macos-latest
1824
steps:
1925
- uses: actions/checkout@v6
2026
with: { submodules: recursive }
2127
- if: github.event_name != 'release' && github.event_name != 'workflow_dispatch'
2228
uses: Swatinem/rust-cache@v2
2329
- uses: taiki-e/install-action@v2
2430
with: { tool: 'just,cargo-binstall' }
25-
- run: just ci-test
31+
- if: runner.os == 'macOS'
32+
run: brew install simde
33+
- if: runner.os == 'macOS'
34+
run: just ci-test
35+
env:
36+
CXXFLAGS: -I/opt/homebrew/include
37+
CFLAGS: -I/opt/homebrew/include
38+
- if: runner.os == 'Linux'
39+
run: just ci-test
2640

2741
test-nightly:
2842
name: Nightly-specific tests

0 commit comments

Comments
 (0)