chore: 2024 edition, disable vsencoding_codec, minor cleanups (#66)

Author: nyurik

Cargo.toml

@@ -7,7 +7,7 @@ authors = [
     "Yuri Astrakhan <YuriAstrakhan@gmail.com>",
 ]
 repository = "https://github.com/jjcfrancisco/fastpfor"
-edition = "2021"
+edition = "2024"
 license = "MIT OR Apache-2.0"
 keywords = ["fastpfor", "compression"]
 categories = ["compression"]
@@ -42,8 +42,6 @@ criterion = "0.8"
 rand = "0.10.0"
 
 [lints.rust]
-dead_code = "allow"
-unused_assignments = "allow"
 unused_qualifications = "warn"
 missing_docs = "warn"
 
@@ -55,5 +53,4 @@ cast_possible_wrap = "allow"
 cast_sign_loss = "allow"
 missing_errors_doc = "allow"
 missing_panics_doc = "allow"
-must_use_candidate = "allow"
 unreadable_literal = "allow"

benches/fastpfor_benchmark.rs

@@ -5,8 +5,8 @@ use std::hint::black_box;
 use std::io::Cursor;
 use std::num::NonZeroU32;
 
-use criterion::{criterion_group, criterion_main, BenchmarkId, Criterion, Throughput};
-use fastpfor::rust::{FastPFOR, Integer, BLOCK_SIZE_128, BLOCK_SIZE_256, DEFAULT_PAGE_SIZE};
+use criterion::{BenchmarkId, Criterion, Throughput, criterion_group, criterion_main};
+use fastpfor::rust::{BLOCK_SIZE_128, BLOCK_SIZE_256, DEFAULT_PAGE_SIZE, FastPFOR, Integer};
 use rand::rngs::StdRng;
 use rand::{RngExt as _, SeedableRng};
 

build.rs

@@ -3,7 +3,8 @@
 /// Builds the C++ `FastPFOR` library and bridge when the `cpp` feature is enabled.
 #[cfg(feature = "cpp")]
 fn build_fastpfor() {
-    use std::{env, path::Path};
+    use std::env;
+    use std::path::Path;
 
     assert!(
         Path::new("cpp/CMakeLists.txt").exists(),

fuzz/fuzz_targets/common.rs

@@ -1,5 +1,4 @@
-use fastpfor::cpp;
-use fastpfor::rust;
+use fastpfor::{cpp, rust};
 
 pub type BoxedCppCodec = Box<dyn cpp::Codec32>;
 

fuzz/fuzz_targets/rust_compress_oracle.rs

@@ -75,7 +75,11 @@ fuzz_target!(|data: FuzzInput<RustCodec>| {
         compressed_oracle_from_cpp.len()
     );
 
-    for (i, (&rust_val, &cpp_val)) in rust_result.iter().zip(compressed_oracle_from_cpp.iter()).enumerate() {
+    for (i, (&rust_val, &cpp_val)) in rust_result
+        .iter()
+        .zip(compressed_oracle_from_cpp.iter())
+        .enumerate()
+    {
         assert_eq!(
             rust_val, cpp_val,
             "Compressed data mismatch at position {}: Rust={}, C++={}",

fuzz/fuzz_targets/rust_decompress_oracle.rs

@@ -1,6 +1,6 @@
 #![no_main]
 
-use fastpfor::{cpp, rust, CodecToSlice};
+use fastpfor::{CodecToSlice, cpp, rust};
 use libfuzzer_sys::fuzz_target;
 mod common;
 use common::*;

src/cpp/mod.rs

@@ -23,7 +23,7 @@ mod ffi {
         fn fastbinarypacking16_codec() -> UniquePtr<IntegerCODEC>;
         fn fastbinarypacking32_codec() -> UniquePtr<IntegerCODEC>;
         fn BP32_codec() -> UniquePtr<IntegerCODEC>;
-        fn vsencoding_codec() -> UniquePtr<IntegerCODEC>;
+        // fn vsencoding_codec() -> UniquePtr<IntegerCODEC>;
         fn fastpfor128_codec() -> UniquePtr<IntegerCODEC>;
         fn fastpfor256_codec() -> UniquePtr<IntegerCODEC>;
         fn simdfastpfor128_codec() -> UniquePtr<IntegerCODEC>;

src/rust/integer_compression/codec.rs

@@ -1,7 +1,7 @@
 use std::io::Cursor;
 
-use crate::rust::{FastPFOR, FastPForResult, Integer, JustCopy, VariableByte};
 use crate::CodecToSlice;
+use crate::rust::{FastPFOR, FastPForResult, Integer, JustCopy, VariableByte};
 
 /// Type-erased wrapper for compression codecs.
 ///

src/rust/integer_compression/differential/mod.rs

@@ -5,6 +5,7 @@ pub struct Delta;
 
 impl Delta {
     /// Creates a new instance
+    #[must_use]
     pub fn new() -> Delta {
         Delta
     }

src/rust/integer_compression/fastpfor.rs

@@ -148,6 +148,7 @@ impl FastPFOR {
     /// Creates codec with specified page and block sizes.
     ///
     /// Pre-allocates buffers for metadata and exception storage.
+    #[must_use]
     pub fn new(page_size: NonZeroU32, block_size: NonZeroU32) -> FastPFOR {
         let page_size = page_size.get();
         let block_size = block_size.get();