Fix broker sliver leak: always relinquish ticket on close

Move do_relinquish() from except to finally block in both the
BlockedJoin close path and the probe_pending() Closing path so
the Broker is notified regardless of whether the Authority close
RPC succeeds or fails. do_relinquish() is idempotent so the
duplicate call in update_lease(CloseWait) is safe.

Author: kthare10

fabric_cf/actor/core/kernel/reservation_client.py

@@ -759,6 +759,7 @@ def close(self, force: bool = False):
                         self.logger.error(traceback.format_exc())
                         self.transition(prefix="close", state=ReservationStates.Closed,
                                         pending=ReservationPendingStates.None_)
+                    finally:
                         self.do_relinquish()
                 else:
                     self.transition_with_join(prefix="close", state=ReservationStates.Active,
@@ -1272,8 +1273,10 @@ def probe_pending(self):
                 # unreachable, it might be better to retry.
                 self.transition(prefix=self.CLOSE_COMPLETE, state=ReservationStates.Closed,
                                 pending=ReservationPendingStates.None_)
-                # Note: the broker does not have information to ensure we
-                # are not cheating
+            finally:
+                # Always notify the Broker to release ticketed resources.
+                # do_relinquish() is idempotent (guarded by self.relinquished flag),
+                # so it is safe to call here even if update_lease() later calls it again.
                 self.do_relinquish()
 
     def set_policy(self, *, policy: ABCClientPolicy):