Skip to content

Commit f68fa71

Browse files
Fix FinOps CI failures: sql_variant CONCAT and test table count
- CONVERT SERVERPROPERTY results to nvarchar(128) in CONCAT call to avoid implicit sql_variant conversion error (Msg 257) - Update SchemaStatements_MatchTableCount assertion from 24 to 26 for the two new FinOps tables (database_size_stats, server_properties) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 27dc20a commit f68fa71

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

Lite.Tests/DuckDbSchemaTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,8 @@ public void SchemaStatements_MatchTableCount()
136136
foreach (var _ in Schema.GetAllTableStatements())
137137
tableCount++;
138138

139-
/* 24 tables from Schema (schema_version is created separately by DuckDbInitializer) */
140-
Assert.Equal(24, tableCount);
139+
/* 26 tables from Schema (schema_version is created separately by DuckDbInitializer) */
140+
Assert.Equal(26, tableCount);
141141
}
142142

143143
[Fact]

install/53_collect_server_properties.sql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -212,9 +212,9 @@ BEGIN
212212
N'SHA2_256',
213213
CONCAT
214214
(
215-
SERVERPROPERTY(N'Edition'), N'|',
216-
SERVERPROPERTY(N'ProductVersion'), N'|',
217-
SERVERPROPERTY(N'ProductLevel'), N'|',
215+
CONVERT(nvarchar(128), SERVERPROPERTY(N'Edition')), N'|',
216+
CONVERT(nvarchar(128), SERVERPROPERTY(N'ProductVersion')), N'|',
217+
CONVERT(nvarchar(128), SERVERPROPERTY(N'ProductLevel')), N'|',
218218
@engine_edition, N'|',
219219
(SELECT osi.cpu_count FROM sys.dm_os_sys_info AS osi), N'|',
220220
(SELECT osi.physical_memory_kb FROM sys.dm_os_sys_info AS osi), N'|',

0 commit comments

Comments
 (0)