Fix installers reporting SUCCESS when files fail

CLI: treated 1 failure as success in automated mode (intended for
query_snapshots but applied to any failure). Now any failure = not
success.

GUI: had a similar workaround checking for query_snapshots
specifically. Removed — failures should be reported honestly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: erikdarlingdata

Installer/Program.cs

@@ -1132,7 +1132,7 @@ Calculate totals and determine success
             */
             totalSuccessCount = upgradeSuccessCount + installSuccessCount;
             totalFailureCount = upgradeFailureCount + installFailureCount;
-            installationSuccessful = (totalFailureCount == 0) || (totalFailureCount == 1 && automatedMode);
+            installationSuccessful = totalFailureCount == 0;
 
             /*
             Log installation history to database

InstallerGui/Services/InstallationService.cs

@@ -620,10 +620,7 @@ Execute SQL files
 
             result.EndTime = DateTime.Now;
 
-            /*Allow query_snapshots to fail - those views get created eventually*/
-            bool onlyQuerySnapshotsFailed = result.FilesFailed == 1 &&
-                result.Errors.Any(e => e.FileName.Contains("query_snapshots", StringComparison.OrdinalIgnoreCase));
-            result.Success = result.FilesFailed == 0 || onlyQuerySnapshotsFailed;
+            result.Success = result.FilesFailed == 0;
 
             return result;
         }