Skip to content

Commit 822cba0

Browse files
Fix Lite auto-refresh silently skipping every tick (#824), rename CPUs to Logical CPUs (#825)
The timer tick handler set _isRefreshing = true before calling RefreshAllDataAsync, which also checked _isRefreshing and returned immediately — every auto-refresh was a no-op. Removed the redundant guard from the tick handler so RefreshAllDataAsync owns the flag. Renamed "CPUs" to "Logical CPUs" in the FinOps server inventory tab (both Dashboard and Lite) to clarify the relationship with the Cores/Socket column, which shows physical cores. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 31f97ee commit 822cba0

3 files changed

Lines changed: 3 additions & 12 deletions

File tree

Dashboard/Controls/FinOpsContent.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2459,7 +2459,7 @@
24592459
<DataGridTextColumn.Header>
24602460
<StackPanel Orientation="Horizontal">
24612461
<Button Style="{DynamicResource ColumnFilterButtonStyle}" Tag="CpuCount" Click="FinOpsFilter_Click" Margin="0,0,4,0"/>
2462-
<TextBlock Text="CPUs" FontWeight="Bold" VerticalAlignment="Center"/>
2462+
<TextBlock Text="Logical CPUs" FontWeight="Bold" VerticalAlignment="Center"/>
24632463
</StackPanel>
24642464
</DataGridTextColumn.Header>
24652465
<DataGridTextColumn.ElementStyle>

Lite/Controls/FinOpsTab.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2246,7 +2246,7 @@
22462246
<DataGridTextColumn.Header>
22472247
<StackPanel Orientation="Horizontal">
22482248
<Button Style="{DynamicResource ColumnFilterButtonStyle}" Tag="CpuCount" Click="FilterButton_Click" Margin="0,0,4,0"/>
2249-
<TextBlock Text="CPUs" FontWeight="Bold" VerticalAlignment="Center"/>
2249+
<TextBlock Text="Logical CPUs" FontWeight="Bold" VerticalAlignment="Center"/>
22502250
</StackPanel>
22512251
</DataGridTextColumn.Header>
22522252
<DataGridTextColumn.ElementStyle>

Lite/Controls/ServerTab.xaml.cs

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -153,16 +153,7 @@ public ServerTab(ServerConnection server, DuckDbInitializer duckDb, CredentialSe
153153
};
154154
_refreshTimer.Tick += async (s, e) =>
155155
{
156-
if (_isRefreshing) return;
157-
_isRefreshing = true;
158-
try
159-
{
160-
await RefreshAllDataAsync(fullRefresh: false);
161-
}
162-
finally
163-
{
164-
_isRefreshing = false;
165-
}
156+
await RefreshAllDataAsync(fullRefresh: false);
166157
};
167158
_refreshTimer.Start();
168159

0 commit comments

Comments
 (0)