Merge pull request #534 from erikdarlingdata/fix/finops-collector-and-ui-fixes

Fix FinOps collector scheduling and UI bugs

Author: erikdarlingdata

Dashboard/Controls/FinOpsContent.xaml

@@ -431,10 +431,11 @@
 
                 <!-- Empty State -->
                 <TextBlock x:Name="NoUtilizationMessage"
-                           Grid.Row="1" Grid.RowSpan="3"
+                           Grid.Row="1" Grid.RowSpan="4"
                            Text="No utilization data collected yet. Select a server above."
                            FontSize="14" Foreground="{DynamicResource ForegroundMutedBrush}"
-                           HorizontalAlignment="Center" VerticalAlignment="Center"
+                           HorizontalAlignment="Center" VerticalAlignment="Top"
+                           Margin="0,20,0,0"
                            Visibility="Collapsed"/>
             </Grid>
         </TabItem>

Dashboard/Controls/FinOpsContent.xaml.cs

@@ -102,7 +102,13 @@ await Task.WhenAll(
                     LoadDatabaseResourcesAsync(),
                     LoadDatabaseSizesAsync(),
                     LoadApplicationConnectionsAsync(),
-                    LoadServerInventoryAsync()
+                    LoadServerInventoryAsync(),
+                    LoadStorageGrowthAsync(),
+                    LoadIdleDatabasesAsync(),
+                    LoadTempdbSummaryAsync(),
+                    LoadWaitCategorySummaryAsync(),
+                    LoadExpensiveQueriesAsync(),
+                    LoadMemoryGrantEfficiencyAsync()
                 );
             }
             catch (Exception ex)
@@ -133,6 +139,13 @@ private async Task LoadUtilizationAsync()
                     DbSizeChart.ItemsSource = await _databaseService.GetFinOpsDatabaseSizeSummaryAsync();
                     ProvisioningTrendGrid.ItemsSource = await _databaseService.GetFinOpsProvisioningTrendAsync();
                 }
+                else
+                {
+                    TopTotalGrid.ItemsSource = null;
+                    TopAvgGrid.ItemsSource = null;
+                    DbSizeChart.ItemsSource = null;
+                    ProvisioningTrendGrid.ItemsSource = null;
+                }
             }
             catch (Exception ex)
             {

Lite/Controls/FinOpsTab.xaml

@@ -430,10 +430,11 @@
 
                 <!-- Empty State -->
                 <TextBlock x:Name="NoUtilizationMessage"
-                           Grid.Row="1" Grid.RowSpan="3"
+                           Grid.Row="1" Grid.RowSpan="4"
                            Text="No utilization data collected yet. Select a server above."
                            FontSize="14" Foreground="{DynamicResource ForegroundMutedBrush}"
-                           HorizontalAlignment="Center" VerticalAlignment="Center"
+                           HorizontalAlignment="Center" VerticalAlignment="Top"
+                           Margin="0,20,0,0"
                            Visibility="Collapsed"/>
             </Grid>
         </TabItem>

Lite/Controls/FinOpsTab.xaml.cs

@@ -108,10 +108,18 @@ private async System.Threading.Tasks.Task LoadPerServerDataAsync()
         var serverId = GetSelectedServerId();
         if (serverId == 0 || _dataService == null) return;
 
-        await LoadUtilizationAsync(serverId);
-        await LoadDatabaseResourcesAsync(serverId);
-        await LoadApplicationConnectionsAsync(serverId);
-        await LoadDatabaseSizesAsync(serverId);
+        await System.Threading.Tasks.Task.WhenAll(
+            LoadUtilizationAsync(serverId),
+            LoadDatabaseResourcesAsync(serverId),
+            LoadApplicationConnectionsAsync(serverId),
+            LoadDatabaseSizesAsync(serverId),
+            LoadStorageGrowthAsync(serverId),
+            LoadIdleDatabasesAsync(serverId),
+            LoadTempdbSummaryAsync(serverId),
+            LoadWaitCategorySummaryAsync(serverId),
+            LoadExpensiveQueriesAsync(serverId),
+            LoadMemoryGrantEfficiencyAsync(serverId)
+        );
     }
 
     private async System.Threading.Tasks.Task LoadUtilizationAsync(int serverId)
@@ -132,6 +140,13 @@ private async System.Threading.Tasks.Task LoadUtilizationAsync(int serverId)
                 DbSizeChart.ItemsSource = await _dataService.GetDatabaseSizeSummaryAsync(serverId);
                 ProvisioningTrendGrid.ItemsSource = await _dataService.GetProvisioningTrendAsync(serverId);
             }
+            else
+            {
+                TopTotalGrid.ItemsSource = null;
+                TopAvgGrid.ItemsSource = null;
+                DbSizeChart.ItemsSource = null;
+                ProvisioningTrendGrid.ItemsSource = null;
+            }
         }
         catch (Exception ex)
         {

Lite/Services/LocalDataService.FinOps.cs

@@ -476,7 +476,7 @@ LIMIT 1
     s.cpu_count
 FROM cpu_stats c
 CROSS JOIN mem_latest m
-CROSS JOIN server_info s";
+LEFT JOIN server_info s ON true";
 
         command.Parameters.Add(new DuckDBParameter { Value = serverId });
         command.Parameters.Add(new DuckDBParameter { Value = cutoff });

collection_schedule.json

@@ -74,7 +74,9 @@ FROM
     (N'plan_cache_stats_collector', 1, 5, 5, 30, N'Plan cache composition statistics - single-use plans and plan cache bloat detection'),
     (N'session_stats_collector', 1, 1, 2, 30, N'Session and connection statistics - connection leaks and application patterns'),
     (N'waiting_tasks_collector', 1, 1, 2, 30, N'Currently waiting tasks - blocking chains and wait analysis'),
-    (N'running_jobs_collector', 1, 1, 2, 7, N'Currently running SQL Agent jobs with historical duration comparison')
+    (N'running_jobs_collector', 1, 1, 2, 7, N'Currently running SQL Agent jobs with historical duration comparison'),
+    (N'database_size_stats_collector', 1, 60, 10, 90, N'Database file sizes for growth trending and capacity planning'),
+    (N'server_properties_collector', 1, 1440, 5, 365, N'Server edition, licensing, CPU/memory hardware metadata for license audit')
 ) AS v (collector_name, enabled, frequency_minutes, max_duration_minutes, retention_days, description)
 WHERE NOT EXISTS
 (