Fix memory leaks in Lite: delta cache, event handlers, chart helpers (#758) (#760)

- DeltaCalculator: add ClearServer() to free cache when server tab closes
- MainWindow: store event handler delegates so they can be unsubscribed
  on tab close (AlertCountsChanged, ApplyTimeRangeRequested, ManualRefreshRequested)
- ChartHoverHelper: add Dispose() to unsubscribe MouseMove/MouseLeave events
- ServerTab: add DisposeChartHelpers() to clean up all 27 hover helpers
- CloseServerTab now calls all cleanup methods

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: erikdarlingdata

Lite/Controls/ServerTab.xaml.cs

@@ -5243,6 +5243,37 @@ public void StopRefresh()
         _refreshTimer.Stop();
     }
 
+    public void DisposeChartHelpers()
+    {
+        _waitStatsHover?.Dispose();
+        _perfmonHover?.Dispose();
+        _overviewCpuHover?.Dispose();
+        _overviewMemoryHover?.Dispose();
+        _overviewFileIoHover?.Dispose();
+        _overviewWaitStatsHover?.Dispose();
+        _cpuHover?.Dispose();
+        _memoryHover?.Dispose();
+        _tempDbHover?.Dispose();
+        _tempDbFileIoHover?.Dispose();
+        _fileIoReadHover?.Dispose();
+        _fileIoWriteHover?.Dispose();
+        _fileIoReadThroughputHover?.Dispose();
+        _fileIoWriteThroughputHover?.Dispose();
+        _collectorDurationHover?.Dispose();
+        _queryDurationTrendHover?.Dispose();
+        _procDurationTrendHover?.Dispose();
+        _queryStoreDurationTrendHover?.Dispose();
+        _executionCountTrendHover?.Dispose();
+        _lockWaitTrendHover?.Dispose();
+        _blockingTrendHover?.Dispose();
+        _deadlockTrendHover?.Dispose();
+        _memoryClerksHover?.Dispose();
+        _memoryGrantSizingHover?.Dispose();
+        _memoryGrantActivityHover?.Dispose();
+        _currentWaitsDurationHover?.Dispose();
+        _currentWaitsBlockedHover?.Dispose();
+    }
+
     /* ========== Column Filtering ========== */
 
     private void InitializeFilterManagers()

Lite/Helpers/ChartHoverHelper.cs

@@ -56,6 +56,14 @@ public ChartHoverHelper(ScottPlot.WPF.WpfPlot chart, string unit)
 
     public string Unit { get => _unit; set => _unit = value; }
 
+    public void Dispose()
+    {
+        _chart.MouseMove -= OnMouseMove;
+        _chart.MouseLeave -= OnMouseLeave;
+        _popup.IsOpen = false;
+        _scatters.Clear();
+    }
+
     public void Clear() => _scatters.Clear();
 
     public void Add(ScottPlot.Plottables.Scatter scatter, string label) =>

Lite/MainWindow.xaml.cs

@@ -36,6 +36,7 @@ public partial class MainWindow : Window
     private CancellationTokenSource? _backgroundCts;
     private SystemTrayService? _trayService;
     private readonly Dictionary<string, TabItem> _openServerTabs = new();
+    private readonly Dictionary<string, (Action<int, int, DateTime?> AlertCounts, Action<int> ApplyTimeRange, Func<Task> ManualRefresh)> _tabEventHandlers = new();
     private readonly Dictionary<string, bool> _previousConnectionStates = new();
     private readonly Dictionary<string, bool> _previousCollectorErrorStates = new();
     private readonly Dictionary<string, DateTime> _lastCpuAlert = new();
@@ -530,15 +531,13 @@ private async void ConnectToServer(ServerConnection server)
             Content = serverTab
         };
 
-        /* Subscribe to alert counts for badge updates */
+        /* Subscribe to events — store handlers so we can unsubscribe on tab close */
         var serverId = server.Id;
-        serverTab.AlertCountsChanged += (blockingCount, deadlockCount, latestEventTime) =>
+        Action<int, int, DateTime?> alertHandler = (blockingCount, deadlockCount, latestEventTime) =>
         {
             Dispatcher.Invoke(() => UpdateTabBadge(tabHeader, serverId, blockingCount, deadlockCount, latestEventTime));
         };
-
-        /* Subscribe to "Apply to All" time range propagation */
-        serverTab.ApplyTimeRangeRequested += (selectedIndex) =>
+        Action<int> timeRangeHandler = (selectedIndex) =>
         {
             Dispatcher.Invoke(() =>
             {
@@ -551,9 +550,7 @@ private async void ConnectToServer(ServerConnection server)
                 }
             });
         };
-
-        /* Re-collect on-load data (config, trace flags) when refresh button is clicked */
-        serverTab.ManualRefreshRequested += async () =>
+        Func<Task> refreshHandler = async () =>
         {
             if (_collectorService != null)
             {
@@ -572,6 +569,11 @@ private async void ConnectToServer(ServerConnection server)
             }
         };
 
+        serverTab.AlertCountsChanged += alertHandler;
+        serverTab.ApplyTimeRangeRequested += timeRangeHandler;
+        serverTab.ManualRefreshRequested += refreshHandler;
+        _tabEventHandlers[server.Id] = (alertHandler, timeRangeHandler, refreshHandler);
+
         _openServerTabs[server.Id] = tabItem;
         ServerTabControl.Items.Add(tabItem);
         ServerTabControl.SelectedItem = tabItem;
@@ -793,7 +795,20 @@ private void CloseServerTab(string serverId)
         {
             if (tab.Content is ServerTab serverTab)
             {
+                /* Unsubscribe event handlers to prevent memory leaks */
+                if (_tabEventHandlers.TryGetValue(serverId, out var handlers))
+                {
+                    serverTab.AlertCountsChanged -= handlers.AlertCounts;
+                    serverTab.ApplyTimeRangeRequested -= handlers.ApplyTimeRange;
+                    serverTab.ManualRefreshRequested -= handlers.ManualRefresh;
+                    _tabEventHandlers.Remove(serverId);
+                }
+
                 serverTab.StopRefresh();
+                serverTab.DisposeChartHelpers();
+
+                /* Clear delta cache for this server to free memory */
+                _collectorService?.DeltaCalculator?.ClearServer(serverTab.ServerId);
             }
 
             ServerTabControl.Items.Remove(tab);

Lite/Services/DeltaCalculator.cs

@@ -59,6 +59,15 @@ public async Task SeedFromDatabaseAsync(DuckDbInitializer duckDb)
         }
     }
 
+    /// <summary>
+    /// Removes all cached entries for a server (e.g., when the server tab is closed).
+    /// Next collection will re-seed from database if needed.
+    /// </summary>
+    public void ClearServer(int serverId)
+    {
+        _cache.TryRemove(serverId, out _);
+    }
+
     /// <summary>
     /// Calculates the delta between the current value and the previous cached value.
     /// First-ever sighting (no baseline): returns currentValue so single-execution queries appear.

Lite/Services/RemoteCollectorService.cs

@@ -59,6 +59,7 @@ public partial class RemoteCollectorService
     private readonly ScheduleManager _scheduleManager;
     private readonly ILogger<RemoteCollectorService>? _logger;
     private readonly DeltaCalculator _deltaCalculator;
+    public DeltaCalculator DeltaCalculator => _deltaCalculator;
     private static long s_idCounter = DateTime.UtcNow.Ticks;
 
     /// <summary>