Commit 75f477f
committed
Refactor to use proposed Ember Inspector public API
- Replace direct __container__ access with emberInspectorAPI.owner.getContainerInstances()
- Replace all owner.lookup() and container.lookup() calls with emberInspectorAPI.owner.lookup()
- Replace route tree building (150+ lines) with emberInspectorAPI.router.buildRouteTree()
- Replace router internal access with emberInspectorAPI.router.getRouteHandler()
- Add comprehensive API stub in ember_debug/utils/ember-inspector-api.js
- Update EMBER_INSPECTOR_API_ANALYSIS.md with Owner/Container/Router APIs
- Add IMPLEMENTATION_COMPARISON.md showing 98% code reduction
Benefits:
- Zero direct private API access
- Zero version-specific code
- 180+ lines eliminated (98% reduction)
- Stable public API that won't break with Ember internals changes1 parent ca8be84 commit 75f477f
3,368 files changed
Lines changed: 784036 additions & 332 deletions
File tree
- .bob
- .bob-errors
- notes
- .idea
- codeStyles
- inspectionProfiles
- ember_debug
- libs
- utils
- test-apps
- classic
- dist
- assets
- ember-welcome-page/images
- panes-3-16-0
- assets
- fonts
- images
- svg
- ember-svg-jar
- favicons
- fonts
- static
- css
- js
- tests
- tests
- node_modules
- .bin
- @babel
- @ember
- @eslint
- @glimmer
- embroider-static-source/node_modules
- .bin
- .embroider
- rewritten-app
- assets
- components
- config
- controllers
- ember-welcome-page/images
- helpers
- models
- panes-3-16-0
- assets
- fonts
- images
- svg
- ember-svg-jar
- favicons
- fonts
- static
- css
- js
- tests
- routes
- services/adapters
- templates
- tests
- ember_debug
- helpers
- integration
- unit
- utils
- rewritten-packages
- @ember
- optional-features.d2f10eea/node_modules
- @ember/optional-features
- render-modifiers.928bd7c5/node_modules
- @ember/render-modifiers
- _app_/modifiers
- modifiers
- test-waiters.983f328c/node_modules
- @ember/test-waiters
- ember-test-waiters
- types
- @embroider
- macros.79d75a90/node_modules
- @embroider/macros
- vendor
- synthesized-styles
- assets
- synthesized-vendor
- vendor
- ember
- loader
- @glimmer
- component.4075d29f/node_modules
- @glimmer/component
- -private
- _app_/component-managers
- tracking.73d78893/node_modules
- @glimmer/tracking
- primitives
- broccoli-asset-rev.5400d347/node_modules
- broccoli-asset-rev
- ember-auto-import.a5063c52/node_modules
- ember-auto-import
- ember-cli-babel.a433d954/node_modules
- ember-cli-babel
- ember-cli-babel.b217992d/node_modules
- ember-cli-babel
- ember-cli-clean-css.df7af2af/node_modules
- ember-cli-clean-css
- ember-cli-dependency-checker.5b87440d/node_modules
- ember-cli-dependency-checker
- ember-cli-htmlbars.3f74fb05/node_modules
- ember-cli-htmlbars
- ember-cli-htmlbars.c5459513/node_modules
- ember-cli-htmlbars
- ember-cli-inject-live-reload.8525f3e8/node_modules
- ember-cli-inject-live-reload
- ember-cli-sri.d3018903/node_modules
- ember-cli-sri
- ember-cli-terser.b3c09a81/node_modules
- ember-cli-terser
- ember-cli-test-loader.717e88ea/node_modules
- ember-cli-test-loader
- _app_/tests
- test-support
- ember-cli-typescript.7eaa4c35/node_modules
- ember-cli-typescript
- ember-cli-typescript.d2d9ead1/node_modules
- ember-cli-typescript
- ember-compatibility-helpers.0ec7a886/node_modules
- ember-compatibility-helpers
- ember-fetch.8ee11e00/node_modules
- ember-fetch
- _fastboot_/instance-initializers
- utils
- vendor
- ember-in-element-polyfill.efdb60d4/node_modules
- ember-in-element-polyfill
- ember-modifier-manager-polyfill.5a255950/node_modules
- ember-modifier-manager-polyfill
- ember-tracked-storage-polyfill.a1c96e28/node_modules
- ember-tracked-storage-polyfill
- ember-try.60fd7ad9/node_modules
- ember-try
- ember-wormhole.c9d79c53/node_modules
- ember-wormhole
- _app_/components
- components
- templates/components
- utils
- loader.js.812852a7/node_modules
- loader.js
- vendor/loader
- .ignored_broccoli-asset-rev
- lib
- .ignored_concurrently
- dist
- bin
- src
- command-parser
- flow-control
- docs
- cli
- node_modules/.bin
- .ignored_ember-auto-import
- .github/workflows
- babel-plugin
- config
- js
- node_modules/.bin
- .ignored_ember-cli-babel
- lib
- node_modules/.bin
- .ignored_ember-cli-clean-css
- .dependabot
- addon-config
- config
- node-tests
- .ignored_ember-cli-dependency-checker
- .github/workflows
- lib
- utils
- node_modules/.bin
- .ignored_ember-cli-htmlbars
- lib
- node_modules/.bin
- .ignored_ember-cli-inject-live-reload
- lib
- .ignored_ember-cli-sri
- .ignored_ember-cli-terser
- .github/workflows
- .ignored_ember-cli
- bin
- blueprints
- addon-import
- files/__root__/__path__
- addon
- files
- .github/workflows
- addon-config
- addon
- app
- config
- app
- files
- .github/workflows
- app
- components
- config
- controllers
- helpers
- models
- routes
- styles
- templates
- config
- public
- tests
- helpers
- integration
- unit
- types
- blueprint
- files/blueprints/__name__
- files
- http-mock
- files/server/mocks
- http-proxy
- files/server/proxies
- in-repo-addon
- files/__root__/__name__
- lib
- server
- files/server
- docs/build
- lib
- broccoli
- cli
- commands
- debug
- experiments
- models
- package-info-cache
- per-bundle-addon-cache
- tasks
- server
- middleware
- broccoli-serve-files
- broccoli-watcher
- history-support
- proxy-server
- testem-url-rewriter
- tests-server
- transforms/amd
- utilities
- node_modules/.bin
- tests/helpers
- .ignored_ember-fetch
- .github
- workflows
- addon
- utils
- assets
- config
- fastboot/instance-initializers
- public
- test
- fixtures/dummy
- app
- routes
- styles
- templates
- config
- public
- types
- dummy
- ember-data/types/registries
- utils
- .ignored_ember-in-element-polyfill
- .dependabot
- .github/workflows
- .idea
- inspectionProfiles
- libraries
- addon/helpers
- app/helpers
- config
- lib
- .ignored_ember-load-initializers
- dist
- .ignored_ember-modifier
- blueprints
- modifier-test
- mocha-files/__root__/integration/__collection__
- qunit-files/__root__/integration/__collection__
- modifier
- files/__root__/__collection__
- declarations
- -private
- class-based
- function-based
- dist
- -private
- .ignored_ember-page-title
- declarations
- helpers
- services
- test-support
- dist
- _app_
- helpers
- services
- helpers
- services
- test-support
- .ignored_ember-qunit
- dist
- node_modules/.bin
- types
- .ignored_ember-resolver
- addon
- string
- utils
- .ignored_ember-sinon-qunit
- declarations
- test-support
- dist
- test-support
- node_modules/.bin
- .ignored_ember-source
- blueprints-js
- acceptance-test
- qunit-files/tests/acceptance
- qunit-rfc-232-files/tests/acceptance
- component-addon/files/__root__/__path__
- component-class-addon/files/__root__/__path__
- component-class/files/__root__/__path__
- component-test
- qunit-files/__root__/__testType__/__path__
- qunit-rfc-232-files/__root__/__testType__/__path__
- component/files/__root__
- __path__
- __templatepath__
- controller-test
- qunit-files/__root__/__testType__/__path__
- qunit-rfc-232-files/__root__/__testType__/__path__
- controller/files/__root__/__path__
- helper-addon/files/__root__/__path__
- helper-test
- qunit-files/__root__/__testType__/helpers
- qunit-rfc-232-files/__root__/__testType__/helpers
- helper/files/__root__/helpers
- initializer-addon/files/__root__/__path__
- initializer-test
- qunit-files/__root__/__testType__/__path__
- qunit-rfc-232-files/__root__/__testType__/__path__
- initializer/files/__root__/initializers
- instance-initializer-addon/files/__root__/__path__
- instance-initializer-test
- qunit-files/__root__/__testType__/__path__
- qunit-rfc-232-files/__root__/__testType__/__path__
- instance-initializer/files/__root__/instance-initializers
- mixin-test
- qunit-files/__root__/__testType__
- qunit-rfc-232-files/__root__/__testType__
- mixin/files/__root__/mixins
- route-addon/files/__root__
- __path__
- __templatepath__
- route-test
- qunit-files/__root__/__testType__/__path__
- qunit-rfc-232-files/__root__/__testType__/__path__
- route/files/__root__
- __path__
- __templatepath__
- service-test
- qunit-files/__root__/__testType__/__path__
- qunit-rfc-232-files/__root__/__testType__/__path__
- service/files/__root__/__path__
- template/files/__root__/__path__
- util-test
- qunit-files/__root__/__testType__
- qunit-rfc-232-files/__root__/__testType__
- util/files/__root__/utils
- blueprints
- acceptance-test
- qunit-files/tests/acceptance
- qunit-rfc-232-files/tests/acceptance
- component-addon
- files/__root__/__path__
- component-class-addon
- files/__root__/__path__
- component-class
- files/__root__/__path__
- component-test
- qunit-files/__root__/__testType__/__path__
- qunit-rfc-232-files/__root__/__testType__/__path__
- component
- files/__root__
- __path__
- __templatepath__
- controller-test
- qunit-files/__root__/__testType__/__path__
- qunit-rfc-232-files/__root__/__testType__/__path__
- controller
- files/__root__/__path__
- helper-addon
- files/__root__/__path__
- helper-test
- qunit-files/__root__/__testType__/helpers
- qunit-rfc-232-files/__root__/__testType__/helpers
- helper
- files/__root__/helpers
- initializer-addon
- files/__root__/__path__
- initializer-test
- qunit-files/__root__/__testType__/__path__
- qunit-rfc-232-files/__root__/__testType__/__path__
- initializer
- files/__root__/initializers
- instance-initializer-addon
- files/__root__/__path__
- instance-initializer-test
- qunit-files/__root__/__testType__/__path__
- qunit-rfc-232-files/__root__/__testType__/__path__
- instance-initializer
- files/__root__/instance-initializers
- mixin-test
- qunit-files/__root__/__testType__
- qunit-rfc-232-files/__root__/__testType__
- mixin
- files/__root__/mixins
- route-addon
- files/__root__
- __path__
- __templatepath__
- route-test
- qunit-files/__root__/__testType__/__path__
- qunit-rfc-232-files/__root__/__testType__/__path__
- route
- files/__root__
- __path__
- __templatepath__
- service-test
- qunit-files/__root__/__testType__/__path__
- qunit-rfc-232-files/__root__/__testType__/__path__
- service
- files/__root__/__path__
- template
- files/__root__/__path__
- util-test
- qunit-files/__root__/__testType__
- qunit-rfc-232-files/__root__/__testType__
- util
- files/__root__/utils
- dist
- packages
- @ember
- -internals
- browser-environment
- container
- deprecations
- environment
- error-handling
- glimmer
- metal
- meta
- lib
- owner
- routing
- runtime
- lib
- ext
- mixins
- string
- utility-types
- utils
- views
- lib
- compat
- mixins
- system
- views
- application
- lib
- array
- lib
- canary-features
- component
- controller
- debug
- lib
- deprecated-features
- destroyable
- engine
- lib
- enumerable
- helper
- instrumentation
- modifier
- object
- lib/computed
- owner
- renderer
- routing
- lib
- runloop
- service
- template-compilation
- template-factory
- template
- test
- utils
- lib
- version
- @glimmer
- debug
- destroyable
- encoder
- env
- global-context
- manager
- node
- opcode-compiler
- owner
- program
- reference
- runtime
- tracking
- primitives
- util
- validator
- vm
- wire-format
- @simple-dom/document
- backburner.js
- dag-map
- ember-testing
- lib
- adapters
- ext
- helpers
- test
- ember
- route-recognizer
- router_js
- rsvp
- docs
- lib
- node_modules/.bin
- types
- stable
- @ember
- -internals
- browser-environment
- lib
- container
- lib
- deprecations
- environment
- lib
- error-handling
- glimmer
- lib
- component-managers
- components
- helpers
- modifiers
- syntax
- templates
- utils
- views
- metal
- lib
- meta
- lib
- owner
- routing
- runtime
- lib
- ext
- mixins
- string
- utility-types
- utils
- lib
- views
- lib
- compat
- mixins
- system
- views
- application
- lib
- array
- lib
- canary-features
- component
- controller
- debug
- lib
- deprecated-features
- destroyable
- engine
- lib
- enumerable
- helper
- instrumentation
- modifier
- object
- lib/computed
- owner
- renderer
- routing
- lib
- runloop
- -private
- service
- template-compilation
- template-factory
- template
- test
- utils
- lib
- version
- @glimmer/tracking
- primitives
- ember-template-compiler
- lib
- plugins
- system
- ember-testing
- lib
- adapters
- ext
- helpers
- test
- ember
- loader/lib
- .ignored_ember-template-lint
- bin
- lib
- -private
- config
- formatters
- helpers
- rules
- node_modules/.bin
- .ignored_ember-try
- lib
- commands
- dependency-manager-adapters
- tasks
- utils
- node_modules/.bin
- .ignored_ember-welcome-page
- dist
- _app_/components
- components
- images
- .ignored_ember-wormhole
- addon
- components
- templates/components
- utils
- app/components
- config
- .ignored_loader.js
- dist/loader
- .ignored_qunit-dom
- dist
- es
- assertions
- helpers
- .ignored_qunit
- bin
- node_modules/.bin
- qunit
- src/cli
- .ignored_tracked-built-ins
- declarations
- -private
- dist
- -private
- .ignored_webpack
- bin
- hot
- lib
- asset
- async-modules
- cache
- config
- container
- css
- debug
- dependencies
- electron
- errors
- esm
- hmr
- ids
- javascript
- json
- library
- logging
- node
- optimize
- performance
- prefetch
- rules
- runtime
- schemes
- serialization
- sharing
- stats
- util
- hash
- wasm-async
- wasm-sync
- wasm
- webworker
- web
- node_modules/.bin
- schemas
- plugins
- asset
- container
- css
- debug
- ids
- optimize
- schemes
- sharing
- @babel
- .ignored_core
- lib
- config
- files
- helpers
- validation
- errors
- gensync-utils
- parser
- util
- tools
- transformation
- file
- util
- vendor
- node_modules/.bin
- src
- config
- files
- .ignored_eslint-parser
- lib
- convert
- utils
- worker
- node_modules/.bin
- .ignored_plugin-proposal-decorators
- lib
- @ember
- .ignored_optional-features
- .github/workflows
- commands
- config
- features
- node_modules/.bin
- .ignored_render-modifiers
- addon/modifiers
- app/modifiers
- types
- modifiers
- .ignored_string
- declarations
- dist
- .ignored_test-helpers
- declarations
- -internal
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments