Merge pull request #2736 from johanrd/fix/template-no-yield-only-filter-comments

fix: ignore comment + whitespace nodes in template-no-yield-only

Author: NullVoxPopuli

lib/rules/template-no-yield-only.js

@@ -1,3 +1,11 @@
+function isEmptyNode(node) {
+  return (
+    node.type === 'GlimmerMustacheCommentStatement' ||
+    node.type === 'GlimmerCommentStatement' ||
+    (node.type === 'GlimmerTextNode' && !node.chars.trim())
+  );
+}
+
 function isYieldOnly(node) {
   return (
     node.type === 'GlimmerMustacheStatement' &&
@@ -44,7 +52,8 @@ module.exports = {
             ? node.body[0].children
             : node.body;
 
-        if (templateNodes.length === 1 && isYieldOnly(templateNodes[0])) {
+        const nonEmptyNodes = templateNodes.filter((n) => !isEmptyNode(n));
+        if (nonEmptyNodes.length === 1 && isYieldOnly(nonEmptyNodes[0])) {
           isOnlyYield = true;
         }
       },

tests/lib/rules/template-no-yield-only.js

@@ -30,6 +30,16 @@ const invalidHbs = [
     output: null,
     errors: [{ messageId: 'noYieldOnly' }],
   },
+  {
+    code: '{{!-- long-form comment --}}{{yield}}',
+    output: null,
+    errors: [{ messageId: 'noYieldOnly' }],
+  },
+  {
+    code: '<!-- html comment -->{{yield}}',
+    output: null,
+    errors: [{ messageId: 'noYieldOnly' }],
+  },
 ];
 
 function wrapTemplate(entry) {