Fix #640: Use async XMLHttpRequests in workbench

Signed-off-by: James Leigh <james.leigh@ontotext.com>

Author: James Leigh

core/http/workbench/src/main/webapp/scripts/create.js

@@ -24,7 +24,6 @@ function checkOverwrite() {
     var id = workbench.create.id.val();
     $.ajax({
         url: '../' + id + '/info',
-        async: false,
         success: function () {
             submit = confirm('WARNING: You are about to overwrite the ' +
                 'configuration of an existing repository!');
@@ -33,15 +32,17 @@ function checkOverwrite() {
             500: function () {
                 submit = true;
             }
-        }
+        },
+		complete : function(xhr, status) {
+            if (submit && !id.match(/^[a-z0-9._-]+$/)) {
+                submit = confirm('WARNING: There are potentially incompatible ' +
+                    'characters in the repository id.');
+            }
+            if (submit) {
+                $("form[action='create']").submit();
+            }
+		}
     });
-    if (submit && !id.match(/^[a-z0-9._-]+$/)) {
-        submit = confirm('WARNING: There are potentially incompatible ' +
-            'characters in the repository id.');
-    }
-    if (submit) {
-        $("form[action='create']").submit();
-    }
 }
 
 workbench.addLoad(function createPageLoaded() {

core/http/workbench/src/main/webapp/scripts/delete.js

@@ -10,15 +10,14 @@
  * DeleteServlet whether the given ID has been proxied, giving a chance to back
  * out if it is.
  */
-function checkIsSafeToDelete() {
+function checkIsSafeToDelete(event) {
 	var id = $('#id').val();
 	var submitForm = false;
     var feedback = $('#delete-feedback');
 	$
 			.ajax({
 				dataType : 'json',
 				url : 'delete',
-				async : false,
 				timeout : 5000,
 				data : {
 					checkSafe : id
@@ -41,7 +40,10 @@ function checkIsSafeToDelete() {
 					if (!submitForm) {
 						submitForm = confirm('WARNING: You are about to delete a repository that has been proxied by another repository!');
 					}
+                    if (submitForm) {
+                        $(event.target).closest('form')[0].submit();
+                    }
 				}
 			});
-	return submitForm;
+	return false;
 }

core/http/workbench/src/main/webapp/scripts/ts/create.ts

@@ -12,7 +12,7 @@
 	<xsl:include href="template.xsl" />
 
 	<xsl:template match="sparql:sparql">
-		<form action="delete" method="post" onsubmit="return checkIsSafeToDelete();">
+		<form action="delete" method="post" onsubmit="checkIsSafeToDelete(event);">
 			<table class="dataentry">
 				<tbody>
 					<tr>