GH-0000 Fix SHACL template defaults

Author: hmottestad

core/repository/api/src/main/resources/org/eclipse/rdf4j/repository/config/memory-shacl.ttl

@@ -12,16 +12,16 @@
         config:sail.impl [
             config:sail.type "rdf4j:ShaclSail" ;
             config:shacl.parallelValidation {%Parallel validation|true|false%} ;
-            config:shacl.logValidationPlans {%Log validation plans|true|false%} ;
-            config:shacl.logValidationViolations {%Log validation violations|true|false%} ;
+            config:shacl.logValidationPlans {%Log validation plans|false|true%} ;
+            config:shacl.logValidationViolations {%Log validation violations|false|true%} ;
             config:shacl.validationEnabled {%Validation enabled|true|false%} ;
             config:shacl.cacheSelectNodes {%Cache select nodes|true|false%} ;
-            config:shacl.globalLogValidationExecution {%Global log validation execution|true|false%} ;
+            config:shacl.globalLogValidationExecution {%Global log validation execution|false|true%} ;
             config:shacl.rdfsSubClassReasoning {%RDFS subclass reasoning|true|false%} ;
-            config:shacl.performanceLogging {%Performance logging|true|false%} ;
+            config:shacl.performanceLogging {%Performance logging|false|true%} ;
             config:shacl.serializableValidation {%Serializable validation|true|false%} ;
-            config:shacl.eclipseRdf4jShaclExtensions {%Eclipse RDF4J SHACL extensions|true|false%} ;
-            config:shacl.dashDataShapes {%DASH data shapes|true|false%} ;
+            config:shacl.eclipseRdf4jShaclExtensions {%Eclipse RDF4J SHACL extensions|false|true%} ;
+            config:shacl.dashDataShapes {%DASH data shapes|false|true%} ;
             config:shacl.validationResultsLimitTotal {%Validation results limit total|1000000%} ;
             config:shacl.validationResultsLimitPerConstraint {%Validation results limit per constraint|1000%} ;
             config:shacl.transactionalValidationLimit {%Transactional validation limit|500000%} ;

core/repository/api/src/main/resources/org/eclipse/rdf4j/repository/config/native-shacl.ttl

@@ -13,16 +13,16 @@
         config:sail.impl [
             config:sail.type "rdf4j:ShaclSail" ;
             config:shacl.parallelValidation {%Parallel validation|true|false%} ;
-            config:shacl.logValidationPlans {%Log validation plans|true|false%} ;
-            config:shacl.logValidationViolations {%Log validation violations|true|false%} ;
+            config:shacl.logValidationPlans {%Log validation plans|false|true%} ;
+            config:shacl.logValidationViolations {%Log validation violations|false|true%} ;
             config:shacl.validationEnabled {%Validation enabled|true|false%} ;
             config:shacl.cacheSelectNodes {%Cache select nodes|true|false%} ;
-            config:shacl.globalLogValidationExecution {%Global log validation execution|true|false%} ;
+            config:shacl.globalLogValidationExecution {%Global log validation execution|false|true%} ;
             config:shacl.rdfsSubClassReasoning {%RDFS subclass reasoning|true|false%} ;
-            config:shacl.performanceLogging {%Performance logging|true|false%} ;
+            config:shacl.performanceLogging {%Performance logging|false|true%} ;
             config:shacl.serializableValidation {%Serializable validation|true|false%} ;
-            config:shacl.eclipseRdf4jShaclExtensions {%Eclipse RDF4J SHACL extensions|true|false%} ;
-            config:shacl.dashDataShapes {%DASH data shapes|true|false%} ;
+            config:shacl.eclipseRdf4jShaclExtensions {%Eclipse RDF4J SHACL extensions|false|true%} ;
+            config:shacl.dashDataShapes {%DASH data shapes|false|true%} ;
             config:shacl.validationResultsLimitTotal {%Validation results limit total|1000000%} ;
             config:shacl.validationResultsLimitPerConstraint {%Validation results limit per constraint|1000%} ;
             config:shacl.transactionalValidationLimit {%Transactional validation limit|500000%} ;

tools/workbench/src/test/java/org/eclipse/rdf4j/workbench/commands/CreateServletTest.java

@@ -130,6 +130,9 @@ public void testShaclTemplatesExposeAllOptions() throws IOException {
 			assertThat(nativeTemplate).contains("{%" + option + "|");
 		}
 
+		assertShaclDefaultsMatchConfig(memoryTemplate);
+		assertShaclDefaultsMatchConfig(nativeTemplate);
+
 		assertShaclInputsPresent(Paths.get("src/main/webapp/transformations/create-memory-shacl.xsl"));
 		assertShaclInputsPresent(Paths.get("src/main/webapp/transformations/create-native-shacl.xsl"));
 	}
@@ -152,6 +155,15 @@ public void testShaclTemplatesExposeAllOptions() throws IOException {
 			"Shapes graphs"
 	};
 
+	private static final String[] SHACL_FALSE_DEFAULTS = {
+			"Log validation plans",
+			"Log validation violations",
+			"Global log validation execution",
+			"Performance logging",
+			"Eclipse RDF4J SHACL extensions",
+			"DASH data shapes"
+	};
+
 	private static String readConfigTemplate(String resource) throws IOException {
 		try (InputStream input = RepositoryConfig.class.getResourceAsStream(resource)) {
 			assertThat(input).as(resource).isNotNull();
@@ -165,4 +177,10 @@ private static void assertShaclInputsPresent(Path path) throws IOException {
 			assertThat(xsl).contains("name=\"" + option + "\"");
 		}
 	}
+
+	private static void assertShaclDefaultsMatchConfig(String template) {
+		for (String option : SHACL_FALSE_DEFAULTS) {
+			assertThat(template).contains("{%" + option + "|false|true%}");
+		}
+	}
 }