Skip to content

Commit 75cf8e9

Browse files
authored
Merge main into develop (#5737)
2 parents d874f67 + a32c67a commit 75cf8e9

2 files changed

Lines changed: 16 additions & 5 deletions

File tree

AGENTS.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,19 +101,19 @@ Always keep untracked artifacts!
101101
**Yes:** **Routine D (ExecPlans)**. Use an ExecPlan (as described in .agent/PLANS.md) from design to implementation.
102102
**No:** continue.
103103

104-
3**Does a failing test already exist in this repo that pinpoints the issue?**
104+
3. **Does a failing test already exist in this repo that pinpoints the issue?**
105105
**Yes:** **Routine B (Bugfix using existing failing test).**
106106
**No:** continue.
107107

108-
4**Is the edit strictly behavior‑neutral, local in scope, and clearly hit by existing tests?**
108+
4. **Is the edit strictly behavior‑neutral, local in scope, and clearly hit by existing tests?**
109109
**Yes:** **Routine B (Refactor/micro‑perf/documentation/build).**
110110
**No or unsure:** continue.
111111

112-
4. **Is new externally observable behavior required?**
112+
5. **Is new externally observable behavior required?**
113113
**Yes:** **Routine A (Full TDD)**. Add the smallest failing test first.
114114
**No:** continue.
115115

116-
5. **Is this purely an investigation/design spike with no production code changes?**
116+
6. **Is this purely an investigation/design spike with no production code changes?**
117117
**Yes:** **Routine C (Spike/Investigate).**
118118
**No or unsure:** **Routine A.**
119119

core/repository/sparql/src/main/java/org/eclipse/rdf4j/repository/sparql/federation/RepositoryFederatedService.java

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ public BatchingServiceIteration(CloseableIteration<BindingSet> inputBindings,
8686
// See: https://github.com/eclipse-rdf4j/rdf4j/discussions/5120
8787
// Test case: https://github.com/tkuhn/rdf4j-timeout-test
8888
try {
89-
querySubmissionTask = threadExecutor.submit(this::run);
89+
querySubmissionTask = threadExecutor.submit(wrap(this::run));
9090
} catch (Exception e) {
9191
throw new QueryEvaluationException("Failed to start a thread for batched federated query submission",
9292
e);
@@ -661,4 +661,15 @@ private static void closeQuietly(RepositoryConnection conn) {
661661
logger.debug("Details: ", t);
662662
}
663663
}
664+
665+
/**
666+
* Callback to wrap the runnable prior to passing it to the background Executor. Can be used by specializations to
667+
* apply context.
668+
*
669+
* @param runnable the runnable
670+
* @return the runnable
671+
*/
672+
protected Runnable wrap(Runnable runnable) {
673+
return runnable;
674+
}
664675
}

0 commit comments

Comments
 (0)