GH-4886 don't swallow exceptions and always shutdown repo

Author: hmottestad

testsuites/sparql/src/main/java/org/eclipse/rdf4j/testsuite/query/parser/sparql/manifest/SPARQL11UpdateComplianceTest.java

@@ -207,7 +207,7 @@ public void setUp() throws Exception {
 				}
 			}
 
-			expectedResultRepo = createRepository();
+			expectedResultRepo = new SailRepository(new MemoryStore());
 
 			try (RepositoryConnection conn = expectedResultRepo.getConnection()) {
 				conn.clear();

testsuites/sparql/src/main/java/org/eclipse/rdf4j/testsuite/query/parser/sparql/manifest/SPARQLComplianceTest.java

@@ -67,18 +67,14 @@ public DynamicSparqlComplianceTest(String displayName, String testURI, String na
 			this.name = name;
 		}
 
-		public void test() {
+		public void test() throws Exception {
 			assumeThat(getIgnoredTests().contains(getName())).withFailMessage("test case '%s' is ignored", getName())
 					.isFalse();
 			try {
 				setUp();
 				runTest();
-			} catch (Exception e) {
-				try {
-					tearDown();
-				} catch (Exception e2) {
-
-				}
+			} finally {
+				tearDown();
 			}
 		}
 

testsuites/sparql/src/main/java/org/eclipse/rdf4j/testsuite/sparql/tests/BuiltinFunctionTest.java

@@ -242,9 +242,6 @@ private void testSES2052If1(RepositoryConnection conn) throws Exception {
 				assertNotNull(p);
 				assertEquals(RDF.TYPE, p);
 			}
-		} catch (Exception e) {
-			e.printStackTrace();
-			fail(e.getMessage());
 		}
 	}
 
@@ -266,9 +263,6 @@ private void testSES2052If2(RepositoryConnection conn) throws Exception {
 				assertNotNull(p);
 				assertEquals(RDF.TYPE, p);
 			}
-		} catch (Exception e) {
-			e.printStackTrace();
-			fail(e.getMessage());
 		}
 	}