Skip to content

Commit 5c0a1b3

Browse files
authored
GH-4923 Spaces inserted by PropertyPathBuilder cause problems with AllegroGraph (#4928)
2 parents 7e6e284 + 0722900 commit 5c0a1b3

7 files changed

Lines changed: 16 additions & 15 deletions

File tree

core/sparqlbuilder/src/main/java/org/eclipse/rdf4j/sparqlbuilder/constraint/propertypath/InversePath.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@ public InversePath(PropertyPath path) {
2222
this.path = path;
2323
}
2424

25+
@Override
2526
public String getQueryString() {
26-
return "^ " + path.getQueryString();
27+
return "^" + path.getQueryString();
2728
}
2829
}

core/sparqlbuilder/src/main/java/org/eclipse/rdf4j/sparqlbuilder/constraint/propertypath/InversePredicatePath.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@ public InversePredicatePath(IRI predicate) {
3333

3434
@Override
3535
public String getQueryString() {
36-
return "^ " + predicate.getQueryString();
36+
return "^" + predicate.getQueryString();
3737
}
3838
}

core/sparqlbuilder/src/main/java/org/eclipse/rdf4j/sparqlbuilder/constraint/propertypath/NegatedPropertySet.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,12 @@ public NegatedPropertySet(PredicatePathOrInversePredicatePath... properties) {
3030
@Override
3131
public String getQueryString() {
3232
if (properties.length == 1) {
33-
return "! " + properties[0].getQueryString();
33+
return "!" + properties[0].getQueryString();
3434
} else {
3535
return Arrays
3636
.stream(properties)
3737
.map(QueryElement::getQueryString)
38-
.collect(Collectors.joining(" | ", "! ( ", " )"));
38+
.collect(Collectors.joining(" | ", "!( ", " )"));
3939
}
4040
}
4141
}

core/sparqlbuilder/src/main/java/org/eclipse/rdf4j/sparqlbuilder/constraint/propertypath/OneOrMorePath.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,6 @@ public OneOrMorePath(PropertyPath path) {
2424

2525
@Override
2626
public String getQueryString() {
27-
return path.getQueryString() + " +";
27+
return path.getQueryString() + "+";
2828
}
2929
}

core/sparqlbuilder/src/main/java/org/eclipse/rdf4j/sparqlbuilder/constraint/propertypath/ZeroOrMorePath.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,6 @@ public ZeroOrMorePath(PropertyPath path) {
2424

2525
@Override
2626
public String getQueryString() {
27-
return path.getQueryString() + " *";
27+
return path.getQueryString() + "*";
2828
}
2929
}

core/sparqlbuilder/src/main/java/org/eclipse/rdf4j/sparqlbuilder/constraint/propertypath/ZeroOrOnePath.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,6 @@ public ZeroOrOnePath(PropertyPath path) {
2424

2525
@Override
2626
public String getQueryString() {
27-
return path.getQueryString() + " ?";
27+
return path.getQueryString() + "?";
2828
}
2929
}

core/sparqlbuilder/src/test/java/org/eclipse/rdf4j/sparqlbuilder/constraint/propertypath/builder/PropertyPathTest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ public void testInversePath() {
122122
.path(iri(RDFS.COMMENT))
123123
.inv()
124124
.build();
125-
assertEquals("^ ( <" + RDFS.COMMENT + "> )", p.getQueryString());
125+
assertEquals("^( <" + RDFS.COMMENT + "> )", p.getQueryString());
126126
}
127127

128128
@Test
@@ -131,7 +131,7 @@ public void testOneOrMorePath() {
131131
.path(iri(RDFS.COMMENT))
132132
.oneOrMore()
133133
.build();
134-
assertEquals("<" + RDFS.COMMENT + "> +", p.getQueryString());
134+
assertEquals("<" + RDFS.COMMENT + ">+", p.getQueryString());
135135
}
136136

137137
@Test
@@ -140,7 +140,7 @@ public void testZeroOrMorePath() {
140140
.path(iri(RDFS.COMMENT))
141141
.zeroOrMore()
142142
.build();
143-
assertEquals("<" + RDFS.COMMENT + "> *", p.getQueryString());
143+
assertEquals("<" + RDFS.COMMENT + ">*", p.getQueryString());
144144
}
145145

146146
@Test
@@ -149,7 +149,7 @@ public void testZeroOrOnePath() {
149149
.path(iri(RDFS.COMMENT))
150150
.zeroOrOne()
151151
.build();
152-
assertEquals("<" + RDFS.COMMENT + "> ?", p.getQueryString());
152+
assertEquals("<" + RDFS.COMMENT + ">?", p.getQueryString());
153153
}
154154

155155
@Test
@@ -159,7 +159,7 @@ public void testNegatedPropertySetSingle() {
159159
.negProp()
160160
.pred(iri(RDFS.COMMENT))
161161
.build();
162-
assertEquals("! <" + RDFS.COMMENT + ">", p.getQueryString());
162+
assertEquals("!<" + RDFS.COMMENT + ">", p.getQueryString());
163163
}
164164

165165
@Test
@@ -169,7 +169,7 @@ public void testNegatedPropertySetSingleInverted() {
169169
.negProp()
170170
.invPred(iri(RDFS.COMMENT))
171171
.build();
172-
assertEquals("! ^ <" + RDFS.COMMENT + ">", p.getQueryString());
172+
assertEquals("!^<" + RDFS.COMMENT + ">", p.getQueryString());
173173
}
174174

175175
@Test
@@ -180,7 +180,7 @@ public void testNegatedPropertySetMultipleInverted() {
180180
.invPred(iri(RDFS.COMMENT))
181181
.invPred(iri(RDFS.LABEL))
182182
.build();
183-
assertEquals("! ( ^ <" + RDFS.COMMENT + "> | ^ <" + RDFS.LABEL + "> )", p.getQueryString());
183+
assertEquals("!( ^<" + RDFS.COMMENT + "> | ^<" + RDFS.LABEL + "> )", p.getQueryString());
184184
}
185185

186186
@Test
@@ -193,7 +193,7 @@ public void testNegatedPropertySetMultipleMixed() {
193193
.invPred(iri(RDFS.SUBPROPERTYOF))
194194
.pred(iri(RDFS.COMMENT))
195195
.build();
196-
assertEquals("! ( ^ <" + RDFS.SUBCLASSOF + "> | <" + RDFS.LABEL + "> | ^ <" + RDFS.SUBPROPERTYOF
196+
assertEquals("!( ^<" + RDFS.SUBCLASSOF + "> | <" + RDFS.LABEL + "> | ^<" + RDFS.SUBPROPERTYOF
197197
+ "> | <" + RDFS.COMMENT + "> )", p.getQueryString());
198198
}
199199

0 commit comments

Comments
 (0)