working on new ID based join iterator

Author: hmottestad

core/sail/lmdb/src/main/java/org/eclipse/rdf4j/sail/lmdb/IdBindingInfo.java

@@ -26,6 +26,7 @@
 import org.eclipse.rdf4j.query.algebra.evaluation.ArrayBindingSet;
 import org.eclipse.rdf4j.query.algebra.evaluation.impl.QueryEvaluationContext;
 import org.eclipse.rdf4j.sail.lmdb.join.LmdbIdJoinIterator;
+import org.eclipse.rdf4j.sail.lmdb.join.LmdbIdJoinSettings;
 import org.eclipse.rdf4j.sail.lmdb.model.LmdbValue;
 
 /**
@@ -126,7 +127,7 @@ public boolean applyRecord(long[] record, MutableBindingSet target, ValueStore v
 					// Fallback: resolve and compare
 					Value candidate;
 					try {
-						candidate = valueStore.getLazyValue(id);
+						candidate = LmdbIdJoinSettings.resolveValue(valueStore, id);
 					} catch (IOException ex) {
 						throw new QueryEvaluationException(ex);
 					}
@@ -136,7 +137,7 @@ public boolean applyRecord(long[] record, MutableBindingSet target, ValueStore v
 				} else {
 					Value candidate;
 					try {
-						candidate = valueStore.getLazyValue(id);
+						candidate = LmdbIdJoinSettings.resolveValue(valueStore, id);
 					} catch (IOException ex) {
 						throw new QueryEvaluationException(ex);
 					}
@@ -174,7 +175,7 @@ public boolean applyRecord(long[] record, MutableBindingSet target, ValueStore v
 					// Fallback: resolve candidate and compare
 					Value candidate;
 					try {
-						candidate = valueStore.getLazyValue(id);
+						candidate = LmdbIdJoinSettings.resolveValue(valueStore, id);
 					} catch (IOException ex) {
 						throw new QueryEvaluationException(ex);
 					}
@@ -185,7 +186,7 @@ public boolean applyRecord(long[] record, MutableBindingSet target, ValueStore v
 					// No existing value: resolve once and set via direct setter
 					Value candidate;
 					try {
-						candidate = valueStore.getLazyValue(id);
+						candidate = LmdbIdJoinSettings.resolveValue(valueStore, id);
 					} catch (IOException ex) {
 						throw new QueryEvaluationException(ex);
 					}
@@ -221,7 +222,7 @@ public boolean applyRecord(long[] record, MutableBindingSet target, ValueStore v
 			}
 			Value candidate;
 			try {
-				candidate = valueStore.getLazyValue(id);
+				candidate = LmdbIdJoinSettings.resolveValue(valueStore, id);
 			} catch (IOException ex) {
 				throw new QueryEvaluationException(ex);
 			}

core/sail/lmdb/src/main/java/org/eclipse/rdf4j/sail/lmdb/join/LmdbIdFinalBindingSetIteration.java

@@ -13,7 +13,6 @@
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Collections;
-import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.function.BiConsumer;
@@ -41,7 +40,6 @@ final class LmdbIdFinalBindingSetIteration extends LookAheadIteration<BindingSet
 	private final ValueStore valueStore;
 	private final Map<String, Long> constantBindings;
 	private List<ConstEntry> constantEntries;
-	private Map<String, BiConsumer<Value, MutableBindingSet>> constantSetters;
 
 	LmdbIdFinalBindingSetIteration(RecordIterator input, IdBindingInfo info, QueryEvaluationContext context,
 			BindingSet initial, ValueStore valueStore, Map<String, Long> constantBindings) {
@@ -79,7 +77,7 @@ protected BindingSet getNextElement() throws QueryEvaluationException {
 					}
 					if (!ce.valueResolved) {
 						try {
-							ce.value = valueStore.getLazyValue(ce.id);
+							ce.value = LmdbIdJoinSettings.resolveValue(valueStore, ce.id);
 						} catch (IOException e) {
 							throw new QueryEvaluationException(e);
 						}

core/sail/lmdb/src/main/java/org/eclipse/rdf4j/sail/lmdb/join/LmdbIdJoinIterator.java

@@ -211,7 +211,7 @@ private Value resolveValue(long id, int position, ValueStore valueStore) throws
 				return null;
 			}
 			try {
-				return valueStore.getLazyValue(id);
+				return LmdbIdJoinSettings.resolveValue(valueStore, id);
 			} catch (IOException e) {
 				throw new QueryEvaluationException(e);
 			}

core/sail/lmdb/src/main/java/org/eclipse/rdf4j/sail/lmdb/join/LmdbIdJoinSettings.java

@@ -0,0 +1,49 @@
+/*******************************************************************************
+ * Copyright (c) 2025 Eclipse RDF4J contributors.
+ *
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Distribution License v1.0
+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/org/documents/edl-v10.php.
+ *
+ * SPDX-License-Identifier: BSD-3-Clause
+ *******************************************************************************/
+package org.eclipse.rdf4j.sail.lmdb.join;
+
+import java.io.IOException;
+
+import org.eclipse.rdf4j.model.Value;
+import org.eclipse.rdf4j.sail.lmdb.ValueStore;
+import org.eclipse.rdf4j.sail.lmdb.model.LmdbValue;
+
+/**
+ * Centralizes runtime switches for LMDB ID-based joins.
+ */
+public final class LmdbIdJoinSettings {
+
+	private static final String LAZY_MATERIALIZATION_PROPERTY = "rdf4j.lmdb.idJoin.lazyMaterialization";
+
+	private LmdbIdJoinSettings() {
+		// no instances
+	}
+
+	public static boolean lazyMaterializationEnabled() {
+		String value = System.getProperty(LAZY_MATERIALIZATION_PROPERTY);
+		if (value == null) {
+			return true;
+		}
+		return !("false".equalsIgnoreCase(value) || "0".equals(value) || "off".equalsIgnoreCase(value));
+	}
+
+	public static LmdbValue resolveLmdbValue(ValueStore valueStore, long id) throws IOException {
+		LmdbValue value = valueStore.getLazyValue(id);
+		if (value != null && !lazyMaterializationEnabled()) {
+			value.init();
+		}
+		return value;
+	}
+
+	public static Value resolveValue(ValueStore valueStore, long id) throws IOException {
+		return resolveLmdbValue(valueStore, id);
+	}
+}