Skip to content

Commit bb7cd32

Browse files
authored
Merge pull request #901 from Dalilaroussi/feature/add_J1939_in_frame
support J1939 in fibex as manufacturer extension
2 parents c3e94fb + 5338355 commit bb7cd32

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

src/canmatrix/formats/fibex.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,8 @@ def create_frame_element(parent, frame, prefix=""):
151151
create_sub_element_fx(frame_element, "BYTE-LENGTH", str(frame.size))
152152
if frame.attribute("NmAsrMessage") and frame.attribute("NmAsrMessage").lower() == "yes":
153153
create_sub_element_fx(frame_element, "FRAME-TYPE", "NM")
154+
elif (frame.is_j1939):
155+
create_sub_element_fx(frame_element, "FRAME-TYPE", "J1939")
154156
else:
155157
create_sub_element_fx(frame_element, "FRAME-TYPE", "APPLICATION")
156158

@@ -179,7 +181,7 @@ def create_frame_triggering(parent, frame, prefix=""):
179181
# Frame reference
180182
frame_ref = create_sub_element_fx(frame_triggering, "FRAME-REF")
181183
frame_ref.set("ID-REF", f"{prefix}FRAME_{frame.name}")
182-
184+
183185
# CAN-FD behavior (if applicable)
184186
if frame.is_fd:
185187
create_sub_element_fx(frame_triggering, "CAN-FRAME-TX-BEHAVIOR", "CAN-FD")

0 commit comments

Comments
 (0)