FastDSS: fix subtle issue on ODD.py

PMeira · PMeira · commit 265a039fb746 · 2026-02-12T16:43:26.000-03:00
diff --git a/src/_fastdss.c b/src/_fastdss.c
@@ -836,7 +836,6 @@ static PyObject *AltDSS_PyStrListGetter_call(AltDSS_PyStrListGetterObject *f, Py
         return NULL;
     }
 
-    result = PyList_New(count[0]);
     if (PyErr_Occurred())
     {
         f->dssCFuncs->DSS_Dispose_PPAnsiChar(&cstr_list, count[1]);
@@ -861,6 +860,8 @@ static PyObject *AltDSS_PyStrListGetter_call(AltDSS_PyStrListGetterObject *f, Py
         }
     }
 
+    result = PyList_New(count[0]);
+
     for (i = 0, sptr = cstr_list; i < count[0]; ++i, ++sptr)
     {
         item = (*sptr) ? PyUnicode_FromString(*sptr) : PyUnicode_FromString("");

Original file line number	Diff line number	Diff line change
`@@ -836,7 +836,6 @@ static PyObject AltDSS_PyStrListGetter_call(AltDSS_PyStrListGetterObject f, Py`
`836`	`836`	`return NULL;`
`837`	`837`	`}`
`838`	`838`
`839`		`- result = PyList_New(count[0]);`
`840`	`839`	`if (PyErr_Occurred())`
`841`	`840`	`{`
`842`	`841`	`f->dssCFuncs->DSS_Dispose_PPAnsiChar(&cstr_list, count[1]);`
`@@ -861,6 +860,8 @@ static PyObject AltDSS_PyStrListGetter_call(AltDSS_PyStrListGetterObject f, Py`
`861`	`860`	`}`
`862`	`861`	`}`
`863`	`862`
	`863`	`+ result = PyList_New(count[0]);`
	`864`	`+`
`864`	`865`	`for (i = 0, sptr = cstr_list; i < count[0]; ++i, ++sptr)`
`865`	`866`	`{`
`866`	`867`	`item = (sptr) ? PyUnicode_FromString(sptr) : PyUnicode_FromString("");`