Skip to content

Commit 6ba8464

Browse files
committed
Revert unnecessary changes
1 parent 23b13e1 commit 6ba8464

4 files changed

Lines changed: 8 additions & 26 deletions

File tree

src/coreclr/tools/superpmi/superpmi-shared/methodcontext.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4584,7 +4584,7 @@ void MethodContext::recGetOSRInfo(PatchpointInfo* patchpointInfo, unsigned* ilOf
45844584

45854585
value.index = (DWORD)GetOSRInfo->AddBuffer((const unsigned char*) patchpointInfo, patchpointInfo->PatchpointInfoSize());
45864586
value.ilOffset = *ilOffset;
4587-
4587+
45884588
// use 0 for key
45894589
DWORD key = 0;
45904590
GetOSRInfo->Add(key, value);

src/coreclr/vm/codeman.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1033,7 +1033,7 @@ void IJitManager::EnumMemoryRegions(CLRDataEnumMemoryFlags flags)
10331033

10341034
#endif // #ifdef DACCESS_COMPILE
10351035

1036-
PTR_VOID EECodeInfo::GetUnwindDataBlob(TADDR moduleBase, PTR_RUNTIME_FUNCTION pRuntimeFunction, /* out */ SIZE_T * pSize)
1036+
PTR_VOID GetUnwindDataBlob(TADDR moduleBase, PTR_RUNTIME_FUNCTION pRuntimeFunction, /* out */ SIZE_T * pSize)
10371037
{
10381038
LIMITED_METHOD_CONTRACT;
10391039

@@ -6463,7 +6463,7 @@ GCInfoToken ReadyToRunJitManager::GetGCInfoToken(const METHODTOKEN& MethodToken)
64636463
TADDR baseAddress = JitTokenToModuleBase(MethodToken);
64646464

64656465
SIZE_T nUnwindDataSize;
6466-
PTR_VOID pUnwindData = EECodeInfo::GetUnwindDataBlob(baseAddress, pRuntimeFunction, &nUnwindDataSize);
6466+
PTR_VOID pUnwindData = GetUnwindDataBlob(baseAddress, pRuntimeFunction, &nUnwindDataSize);
64676467

64686468
// GCInfo immediately follows unwind data
64696469
PTR_BYTE gcInfo = dac_cast<PTR_BYTE>(pUnwindData) + nUnwindDataSize;
@@ -6951,7 +6951,7 @@ BOOL ReadyToRunJitManager::LazyIsFunclet(EECodeInfo* pCodeInfo)
69516951
{
69526952
// This maps to a hot entry in the lookup table, so check its unwind info
69536953
SIZE_T unwindSize;
6954-
PTR_VOID pUnwindData = EECodeInfo::GetUnwindDataBlob(pCodeInfo->GetModuleBase(), pCodeInfo->GetFunctionEntry(), &unwindSize);
6954+
PTR_VOID pUnwindData = GetUnwindDataBlob(pCodeInfo->GetModuleBase(), pCodeInfo->GetFunctionEntry(), &unwindSize);
69556955
_ASSERTE(pUnwindData != NULL);
69566956

69576957
#ifdef TARGET_AMD64
@@ -6991,7 +6991,7 @@ BOOL ReadyToRunJitManager::IsFilterFunclet(EECodeInfo * pCodeInfo)
69916991
#else
69926992
// Get address of the personality routine for the function being queried.
69936993
SIZE_T size;
6994-
PTR_VOID pUnwindData = EECodeInfo::GetUnwindDataBlob(pCodeInfo->GetModuleBase(), pCodeInfo->GetFunctionEntry(), &size);
6994+
PTR_VOID pUnwindData = GetUnwindDataBlob(pCodeInfo->GetModuleBase(), pCodeInfo->GetFunctionEntry(), &size);
69956995
_ASSERTE(pUnwindData != NULL);
69966996

69976997
// Personality routine is always the last element of the unwind data
@@ -7002,7 +7002,7 @@ BOOL ReadyToRunJitManager::IsFilterFunclet(EECodeInfo * pCodeInfo)
70027002
if (pInfo->m_nRuntimeFunctions == 0)
70037003
return FALSE;
70047004

7005-
PTR_VOID pFirstUnwindData = EECodeInfo::GetUnwindDataBlob(pCodeInfo->GetModuleBase(), pInfo->m_pRuntimeFunctions, &size);
7005+
PTR_VOID pFirstUnwindData = GetUnwindDataBlob(pCodeInfo->GetModuleBase(), pInfo->m_pRuntimeFunctions, &size);
70067006
_ASSERTE(pFirstUnwindData != NULL);
70077007
DWORD rvaFirstPersonalityRoutine = *(dac_cast<PTR_DWORD>(dac_cast<TADDR>(pFirstUnwindData) + size) - 1);
70087008

@@ -7109,7 +7109,7 @@ void ReadyToRunJitManager::EnumMemoryRegionsForMethodUnwindInfo(CLRDataEnumMemor
71097109
EnumRuntimeFunctionEntriesToFindEntry(pRtf, pReadyToRunInfo->m_pRuntimeFunctions, pReadyToRunInfo->m_nRuntimeFunctions);
71107110

71117111
SIZE_T size;
7112-
PTR_VOID pUnwindData = EECodeInfo::GetUnwindDataBlob(pCodeInfo->GetModuleBase(), pRtf, &size);
7112+
PTR_VOID pUnwindData = GetUnwindDataBlob(pCodeInfo->GetModuleBase(), pRtf, &size);
71137113
if (pUnwindData != NULL)
71147114
DacEnumMemoryRegion(PTR_TO_TADDR(pUnwindData), size);
71157115
}

src/coreclr/vm/codeman.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3105,10 +3105,8 @@ ULONG GetFixedStackSize();
31053105
ULONG GetFixedStackSize();
31063106

31073107
void GetOffsetsFromUnwindInfo(ULONG* pRSPOffset, ULONG* pRBPOffset);
3108-
unsigned GetSizeOfProlog();
31093108
#endif // TARGET_AMD64
31103109

3111-
static PTR_VOID GetUnwindDataBlob(TADDR moduleBase, PTR_RUNTIME_FUNCTION pRuntimeFunction, /* out */ SIZE_T * pSize);
31123110
private:
31133111
PCODE m_codeAddress;
31143112
METHODTOKEN m_methodToken;
@@ -3127,6 +3125,7 @@ ULONG GetFixedStackSize();
31273125
// Simple helper to return a pointer to the UNWIND_INFO given the offset to the unwind info.
31283126
UNWIND_INFO * GetUnwindInfoHelper(ULONG unwindInfoOffset);
31293127
#endif // TARGET_AMD64
3128+
31303129
};
31313130

31323131
#ifdef FEATURE_INTERPRETER

src/coreclr/vm/jitinterface.cpp

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -15687,22 +15687,5 @@ void EECodeInfo::GetOffsetsFromUnwindInfo(ULONG* pRSPOffset, ULONG* pRBPOffset)
1568715687
*pRSPOffset = StackSize + 8; // add 8 for the return address
1568815688
*pRBPOffset = StackOffset;
1568915689
}
15690-
15691-
unsigned EECodeInfo::GetSizeOfProlog()
15692-
{
15693-
LIMITED_METHOD_CONTRACT;
15694-
TADDR moduleBase = GetModuleBase();
15695-
15696-
DWORD unwindInfo = RUNTIME_FUNCTION__GetUnwindInfoAddress(GetFunctionEntry());
15697-
15698-
if ((unwindInfo & RUNTIME_FUNCTION_INDIRECT) != 0)
15699-
{
15700-
unwindInfo = RUNTIME_FUNCTION__GetUnwindInfoAddress(PTR_RUNTIME_FUNCTION(moduleBase + (unwindInfo & ~RUNTIME_FUNCTION_INDIRECT)));
15701-
}
15702-
15703-
UNWIND_INFO * pInfo = GetUnwindInfoHelper(unwindInfo);
15704-
_ASSERTE((pInfo->Flags & UNW_FLAG_CHAININFO) == 0);
15705-
return pInfo->SizeOfProlog;
15706-
}
1570715690
#undef kRBP
1570815691
#endif // defined(TARGET_AMD64)

0 commit comments

Comments
 (0)