Fix methods tagged as Member instead of Method in tooltips (#19507)

Author: Copilot

docs/release-notes/.FSharp.Compiler.Service/11.0.100.md

@@ -34,6 +34,7 @@
 * Fix signature generation: backtick escaping for identifiers containing backticks. ([Issue #15389](https://github.com/dotnet/fsharp/issues/15389), [PR #19586](https://github.com/dotnet/fsharp/pull/19586))
 * Fix signature generation: `private` keyword placement for prefix-style type abbreviations. ([Issue #15560](https://github.com/dotnet/fsharp/issues/15560), [PR #19586](https://github.com/dotnet/fsharp/pull/19586))
 * Fix signature generation: missing `[<Class>]` attribute for types without visible constructors. ([Issue #16531](https://github.com/dotnet/fsharp/issues/16531), [PR #19586](https://github.com/dotnet/fsharp/pull/19586))
+* Fix methods being tagged as `Member` instead of `Method` in tooltips. ([Issue #10540](https://github.com/dotnet/fsharp/issues/10540), [PR #19507](https://github.com/dotnet/fsharp/pull/19507))
 
 ### Added
 

src/Compiler/Checking/NicePrint.fs

@@ -1385,7 +1385,8 @@ module PrintTastMemberOrVals =
                 let resL =
                     if short then tauL
                     else
-                        let nameL = layoutMemberName denv vref niceMethodTypars argInfos tagMember vref.DisplayNameCoreMangled true
+                        let tag = if isNil argInfos then tagMember else tagMethod
+                        let nameL = layoutMemberName denv vref niceMethodTypars argInfos tag vref.DisplayNameCoreMangled true
                         let nameL = if short then nameL else mkInlineL denv vref.Deref nameL
                         stat --- ((nameL  |> addColonL) ^^ tauL)
                 prettyTyparInst, resL

src/Compiler/TypedTree/TypedTreeOps.FreeVars.fs

@@ -1449,7 +1449,22 @@ module internal MemberRepresentation =
                 | SynMemberKind.PropertyGetSet -> tagProperty vref.DisplayName
                 | SynMemberKind.ClassConstructor
                 | SynMemberKind.Constructor -> tagMethod vref.DisplayName
-                | SynMemberKind.Member -> tagMember vref.DisplayName
+                | SynMemberKind.Member ->
+                    match vref.ValReprInfo with
+                    | Some valReprInfo ->
+                        let numArgGroups = valReprInfo.ArgInfos.Length
+
+                        let isMethod =
+                            if memberInfo.MemberFlags.IsInstance then
+                                numArgGroups > 1
+                            else
+                                numArgGroups > 0
+
+                        if isMethod then
+                            tagMethod vref.DisplayName
+                        else
+                            tagMember vref.DisplayName
+                    | None -> tagMember vref.DisplayName
 
         match fullNameOfParentOfValRefAsLayout vref with
         | ValueNone -> wordL n

tests/FSharp.Compiler.Service.Tests/TooltipTests.fs

@@ -388,6 +388,17 @@ let assertAndGetSingleToolTipText items =
     let text,_xml,_remarks = assertAndExtractTooltip items
     text
 
+let getMainDescriptionTags (ToolTipText(items)) =
+    match items with
+    | ToolTipElement.Group [ singleElement ] :: _ -> singleElement.MainDescription
+    | _ -> failwith $"Expected single group in tooltip, got {items}"
+
+let assertNameTagInTooltip expectedTag expectedName (tooltip: ToolTipText) =
+    let tags = getMainDescriptionTags tooltip
+    let found = tags |> Array.exists (fun t -> t.Tag = expectedTag && t.Text = expectedName)
+    let desc = tags |> Array.map (fun t -> sprintf "(%A, %s)" t.Tag t.Text) |> String.concat ", "
+    Assert.True(found, sprintf "Expected tag %A with text '%s' in tooltip, but found: %s" expectedTag expectedName desc)
+
 let normalize (s: string) = s.Replace("\r\n", "\n").Replace("\n\n", "\n")
 
 [<Fact>]
@@ -602,3 +613,196 @@ let normaliz{caret}e' x = x + 1
 """
 
     testXmlDocFallbackToSigFileWhileInImplFile sigSource implSource "Normalize with a prime"
+
+// https://github.com/dotnet/fsharp/issues/10540
+[<Fact>]
+let ``Instance method should be tagged as Method in tooltip`` () =
+    Checker.getTooltip """
+type T() =
+    member x.Metho{caret}d() = ()
+"""
+    |> assertNameTagInTooltip TextTag.Method "Method"
+
+// https://github.com/dotnet/fsharp/issues/10540
+[<Fact>]
+let ``Instance method with parameters should be tagged as Method in tooltip`` () =
+    Checker.getTooltip """
+type T() =
+    member x.Ad{caret}d(a: int, b: int) = a + b
+"""
+    |> assertNameTagInTooltip TextTag.Method "Add"
+
+// https://github.com/dotnet/fsharp/issues/10540
+[<Fact>]
+let ``Static method should be tagged as Method in tooltip`` () =
+    Checker.getTooltip """
+type T() =
+    static member Creat{caret}e() = T()
+"""
+    |> assertNameTagInTooltip TextTag.Method "Create"
+
+// https://github.com/dotnet/fsharp/issues/10540
+[<Fact>]
+let ``Property-like member should be tagged as Property`` () =
+    Checker.getTooltip """
+type T() =
+    member x.Valu{caret}e = 42
+"""
+    |> assertNameTagInTooltip TextTag.Property "Value"
+
+// https://github.com/dotnet/fsharp/issues/10540
+[<Fact>]
+let ``Auto property should be tagged as Property`` () =
+    Checker.getTooltip """
+namespace Foo
+
+type Bar() =
+    member val Fo{caret}o = "bla" with get, set
+"""
+    |> assertNameTagInTooltip TextTag.Property "Foo"
+
+// https://github.com/dotnet/fsharp/issues/10540
+[<Fact>]
+let ``Indexer should be tagged as Property`` () =
+    Checker.getTooltip """
+type T() =
+    member x.Ite{caret}m with get(i: int) = i
+"""
+    |> assertNameTagInTooltip TextTag.Property "Item"
+
+// https://github.com/dotnet/fsharp/issues/10540
+[<Fact>]
+let ``Indexer with getter and setter should be tagged as Property`` () =
+    Checker.getTooltip """
+type T() =
+    let mutable data = [| 0; 1; 2 |]
+    member x.Ite{caret}m
+        with get(i: int) = data.[i]
+        and set (i: int) (v: int) = data.[i] <- v
+"""
+    |> assertNameTagInTooltip TextTag.Property "Item"
+
+// https://github.com/dotnet/fsharp/issues/10540
+[<Fact>]
+let ``Property with explicit getter should be tagged as Property`` () =
+    Checker.getTooltip """
+type T() =
+    member x.Valu{caret}e with get() = 42
+"""
+    |> assertNameTagInTooltip TextTag.Property "Value"
+
+// https://github.com/dotnet/fsharp/issues/10540
+[<Fact>]
+let ``Static property should be tagged as Property`` () =
+    Checker.getTooltip """
+type T() =
+    static member Defaul{caret}t = T()
+"""
+    |> assertNameTagInTooltip TextTag.Property "Default"
+
+// https://github.com/dotnet/fsharp/issues/10540
+[<Fact>]
+let ``Named indexed property with getter should be tagged as Property`` () =
+    Checker.getTooltip """
+type T() =
+    member x.Valu{caret}e with get(key: string) = key
+"""
+    |> assertNameTagInTooltip TextTag.Property "Value"
+
+// https://github.com/dotnet/fsharp/issues/10540
+[<Fact>]
+let ``Named indexed property with getter and setter should be tagged as Property`` () =
+    Checker.getTooltip """
+type T() =
+    let mutable store = Map.empty<string, int>
+    member x.Valu{caret}e
+        with get(key: string) = store.[key]
+        and set (key: string) (v: int) = store <- store.Add(key, v)
+"""
+    |> assertNameTagInTooltip TextTag.Property "Value"
+
+// https://github.com/dotnet/fsharp/issues/10540
+[<Fact>]
+let ``Indexer with setter only (1 arg) should be tagged as Property`` () =
+    Checker.getTooltip """
+type T() =
+    let mutable data = [| 0 |]
+    member x.Ite{caret}m
+        with set (i: int) (v: int) = data.[i] <- v
+"""
+    |> assertNameTagInTooltip TextTag.Property "Item"
+
+// https://github.com/dotnet/fsharp/issues/10540
+[<Fact>]
+let ``Indexer with getter only (2 args) should be tagged as Property`` () =
+    Checker.getTooltip """
+type T() =
+    member x.Ite{caret}m with get (i: int, j: int) = i + j
+"""
+    |> assertNameTagInTooltip TextTag.Property "Item"
+
+// https://github.com/dotnet/fsharp/issues/10540
+[<Fact>]
+let ``Indexer with setter only (2 args) should be tagged as Property`` () =
+    Checker.getTooltip """
+type T() =
+    let store = System.Collections.Generic.Dictionary<int * int, int>()
+    member x.Ite{caret}m
+        with set (i: int, j: int) (v: int) = store[(i, j)] <- v
+"""
+    |> assertNameTagInTooltip TextTag.Property "Item"
+
+// https://github.com/dotnet/fsharp/issues/10540
+[<Fact>]
+let ``Indexer with getter and setter (2 args) should be tagged as Property`` () =
+    Checker.getTooltip """
+type T() =
+    let store = System.Collections.Generic.Dictionary<int * int, int>()
+    member x.Ite{caret}m
+        with get (i: int, j: int) = store[(i, j)]
+        and set (i: int, j: int) (v: int) = store[(i, j)] <- v
+"""
+    |> assertNameTagInTooltip TextTag.Property "Item"
+
+// https://github.com/dotnet/fsharp/issues/10540
+[<Fact>]
+let ``Named indexed property with setter only (1 arg) should be tagged as Property`` () =
+    Checker.getTooltip """
+type T() =
+    let mutable store = Map.empty<string, int>
+    member x.Valu{caret}e
+        with set (key: string) (v: int) = store <- store.Add(key, v)
+"""
+    |> assertNameTagInTooltip TextTag.Property "Value"
+
+// https://github.com/dotnet/fsharp/issues/10540
+[<Fact>]
+let ``Named indexed property with getter only (2 args) should be tagged as Property`` () =
+    Checker.getTooltip """
+type T() =
+    member x.Valu{caret}e with get (a: string, b: string) = a + b
+"""
+    |> assertNameTagInTooltip TextTag.Property "Value"
+
+// https://github.com/dotnet/fsharp/issues/10540
+[<Fact>]
+let ``Named indexed property with setter only (2 args) should be tagged as Property`` () =
+    Checker.getTooltip """
+type T() =
+    let mutable store = Map.empty<string * string, int>
+    member x.Valu{caret}e
+        with set (a: string, b: string) (v: int) = store <- store.Add((a, b), v)
+"""
+    |> assertNameTagInTooltip TextTag.Property "Value"
+
+// https://github.com/dotnet/fsharp/issues/10540
+[<Fact>]
+let ``Named indexed property with getter and setter (2 args) should be tagged as Property`` () =
+    Checker.getTooltip """
+type T() =
+    let mutable store = Map.empty<string * string, int>
+    member x.Valu{caret}e
+        with get (a: string, b: string) = store[(a, b)]
+        and set (a: string, b: string) (v: int) = store <- store.Add((a, b), v)
+"""
+    |> assertNameTagInTooltip TextTag.Property "Value"