Skip to content

Commit 39cadd9

Browse files
T-GroCopilot
andauthored
Use heap dumps (type 2) instead of triage dumps for crash diagnostics (#19607)
Triage dumps (type 3) don't include the managed heap, making it impossible to inspect exception messages and object state. Heap dumps (type 2) include this data while still being much smaller than full dumps (type 4). Only produced on crash — no impact on passing builds. Related: dotnet/sdk#53958 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 76853e0 commit 39cadd9

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

azure-pipelines-PR.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ stages:
232232
- script: eng\CIBuildNoPublish.cmd -compressallmetadata -configuration Release /p:FSharpLangVersion=preview
233233
env:
234234
DOTNET_DbgEnableMiniDump: 1
235-
DOTNET_DbgMiniDumpType: 3 # Triage dump, 1 for mini, 2 for Heap, 3 for triage, 4 for full. Don't use 4 unless you know what you're doing.
235+
DOTNET_DbgMiniDumpType: 2 # 1=mini, 2=heap, 3=triage, 4=full. Heap dumps include managed object data for debugging.
236236
DOTNET_DbgMiniDumpName: $(Build.SourcesDirectory)\artifacts\log\Release\$(Build.BuildId)-%e-%p-%t.dmp
237237
NativeToolsOnMachine: true
238238
displayName: Build
@@ -268,7 +268,7 @@ stages:
268268
- script: eng\CIBuildNoPublish.cmd -compressallmetadata -buildnorealsig -testCoreclr -configuration Release
269269
env:
270270
DOTNET_DbgEnableMiniDump: 1
271-
DOTNET_DbgMiniDumpType: 3 # Triage dump, 1 for mini, 2 for Heap, 3 for triage, 4 for full. Don't use 4 unless you know what you're doing.
271+
DOTNET_DbgMiniDumpType: 2 # 1=mini, 2=heap, 3=triage, 4=full. Heap dumps include managed object data for debugging.
272272
DOTNET_DbgMiniDumpName: $(Build.SourcesDirectory)\artifacts\log\Release\$(Build.BuildId)-%e-%p-%t.dmp
273273
NativeToolsOnMachine: true
274274
displayName: Build
@@ -315,7 +315,7 @@ stages:
315315
env:
316316
FSharp_CacheEvictionImmediate: true
317317
DOTNET_DbgEnableMiniDump: 1
318-
DOTNET_DbgMiniDumpType: 3 # Triage dump, 1 for mini, 2 for Heap, 3 for triage, 4 for full. Don't use 4 unless you know what you're doing.
318+
DOTNET_DbgMiniDumpType: 2 # 1=mini, 2=heap, 3=triage, 4=full. Heap dumps include managed object data for debugging.
319319
DOTNET_DbgMiniDumpName: $(Build.SourcesDirectory)\artifacts\log\Release\$(Build.BuildId)-%e-%p-%t.dmp
320320
NativeToolsOnMachine: true
321321
displayName: Build
@@ -360,7 +360,7 @@ stages:
360360
- script: eng\CIBuildNoPublish.cmd -compressallmetadata -configuration Release /p:AdditionalFscCmdFlags=--strict-indentation+
361361
env:
362362
DOTNET_DbgEnableMiniDump: 1
363-
DOTNET_DbgMiniDumpType: 3 # Triage dump, 1 for mini, 2 for Heap, 3 for triage, 4 for full. Don't use 4 unless you know what you're doing.
363+
DOTNET_DbgMiniDumpType: 2 # 1=mini, 2=heap, 3=triage, 4=full. Heap dumps include managed object data for debugging.
364364
DOTNET_DbgMiniDumpName: $(Build.SourcesDirectory)\artifacts\log\Release\$(Build.BuildId)-%e-%p-%t.dmp
365365
NativeToolsOnMachine: true
366366
displayName: Build
@@ -396,7 +396,7 @@ stages:
396396
- script: eng\CIBuildNoPublish.cmd -compressallmetadata -configuration Release /p:AdditionalFscCmdFlags=--strict-indentation-
397397
env:
398398
DOTNET_DbgEnableMiniDump: 1
399-
DOTNET_DbgMiniDumpType: 3 # Triage dump, 1 for mini, 2 for Heap, 3 for triage, 4 for full. Don't use 4 unless you know what you're doing.
399+
DOTNET_DbgMiniDumpType: 2 # 1=mini, 2=heap, 3=triage, 4=full. Heap dumps include managed object data for debugging.
400400
DOTNET_DbgMiniDumpName: $(Build.SourcesDirectory)\artifacts\log\Release\$(Build.BuildId)-%e-%p-%t.dmp
401401
NativeToolsOnMachine: true
402402
displayName: Build
@@ -463,7 +463,7 @@ stages:
463463
- script: eng\CIBuildNoPublish.cmd -compressallmetadata -configuration $(_configuration) -$(_testKind)
464464
env:
465465
DOTNET_DbgEnableMiniDump: 1
466-
DOTNET_DbgMiniDumpType: 3 # Triage dump, 1 for mini, 2 for Heap, 3 for triage, 4 for full. Don't use 4 unless you know what you're doing.
466+
DOTNET_DbgMiniDumpType: 2 # 1=mini, 2=heap, 3=triage, 4=full. Heap dumps include managed object data for debugging.
467467
DOTNET_DbgMiniDumpName: $(Build.SourcesDirectory)\artifacts\log\$(_configuration)\$(Build.BuildId)-%e-%p-%t.dmp
468468
NativeToolsOnMachine: true
469469
displayName: Build and Test $(_testKind) $(transparentCompiler)
@@ -543,7 +543,7 @@ stages:
543543
buildEnv:
544544
FSharp_CacheEvictionImmediate: true
545545
DOTNET_DbgEnableMiniDump: 1
546-
DOTNET_DbgMiniDumpType: 3
546+
DOTNET_DbgMiniDumpType: 2
547547
DOTNET_DbgMiniDumpName: $(Build.SourcesDirectory)\artifacts\log\Release\$(Build.BuildId)-%e-%p-%t.dmp
548548
NativeToolsOnMachine: true
549549
testRunTitlePrefix: 'WindowsCompressedMetadata testDesktop'

0 commit comments

Comments
 (0)