Change dry-run to push to NuGet Test/QA environment (#4032)

paulmedynski · cheenamalhotra · web-flow · commit 63700736a0e3 · 2026-03-16T11:15:40.000-07:00
* Task 43000: Change dry-run to push to NuGet INT environment

- Updated OneBranch pipelines to use the NuGet Test/QA service instead of the dry run concept.

* Task 43000: Change dry-run to push to NuGet INT environment

- Fixed variable expansion issues.

* Task 43000: Change dry-run to push to NuGet INT environment

- Added doagnostics to release jobs to see what packages will be pushed.

* Task 43000: Change dry-run to push to NuGet INT environment

- Moved NuGet service connection names into release-stages just like the other release environment values.

---------

Co-authored-by: Cheena Malhotra &lt;13396919+cheenamalhotra@users.noreply.github.com&gt;
diff --git a/eng/pipelines/onebranch/jobs/publish-nuget-package-job.yml b/eng/pipelines/onebranch/jobs/publish-nuget-package-job.yml
@@ -52,15 +52,16 @@ parameters:
     type: string
     default: ''
 
-  # When true, lists the package that would be published without actually pushing.
-  - name: isDryRun
-    type: boolean
-    default: false
+  # Optional suffix appended to display names (e.g. ' (NuGet Test)').
+  - name: displaySuffix
+    type: string
+    default: ''
+
 
 # Read more: https://eng.ms/docs/products/onebranch/release/yamlreleasepipelines/pipelinebasics#what-is-a-onebranch-release-yaml-pipeline
 jobs:
   - job: publish_${{ replace(parameters.packageName, '.', '_') }}
-    displayName: Publish ${{ parameters.packageName }}
+    displayName: Publish ${{ parameters.packageName }}${{ parameters.displaySuffix }}
 
     variables:
       - name: ob_outputDirectory
@@ -89,20 +90,26 @@ jobs:
 
       # Artifacts are downloaded via templateContext.inputs per OneBranch requirements.
 
-      - ${{ if eq(parameters.isDryRun, true) }}:
-        - pwsh: |
-            Write-Host "##[section]DRY RUN — The following packages would be published:"
-
-            Get-ChildItem -Path "$(packageToPush)" -ErrorAction SilentlyContinue
-
-            Write-Host "##[warning]DRY RUN — No packages were pushed."
-          displayName: Dry Run — List ${{ parameters.packageName }} packages
-
-      - ${{ else }}:
-        - task: NuGetCommand@2
-          displayName: Push ${{ parameters.packageName }} to NuGet
-          inputs:
-            command: push
-            packagesToPush: $(packageToPush)
-            nuGetFeedType: external
-            publishFeedCredentials: ${{ parameters.nugetServiceConnection }}
+      # Emit details about what is being published.
+      - pwsh: |
+          Write-Host "artifactPath: $(artifactPath)"
+          Write-Host "packageToPush: $(packageToPush)"
+          Get-ChildItem -Path "$(artifactPath)" -Recurse | Format-Table -AutoSize
+          if (Test-Path "$(packageToPush)")
+          {
+            Write-Host "Package found: $(packageToPush)"
+          }
+          else
+          {
+            Write-Error "Package not found: $(packageToPush)"
+          }
+        displayName: Show Package(s) to Push
+
+      # Push the package(s) to NuGet.
+      - task: NuGetCommand@2
+        displayName: Push ${{ parameters.packageName }} to NuGet${{ parameters.displaySuffix }}
+        inputs:
+          command: push
+          packagesToPush: $(packageToPush)
+          nuGetFeedType: external
+          publishFeedCredentials: ${{ parameters.nugetServiceConnection }}
diff --git a/eng/pipelines/onebranch/sqlclient-non-official.yml b/eng/pipelines/onebranch/sqlclient-non-official.yml
@@ -191,12 +191,11 @@ extends:
       - template: /eng/pipelines/onebranch/stages/release-stages.yml@self
         parameters:
           debug: ${{ parameters.debug }}
-          # Non-official pipelines must always be a dry run.
-          isDryRun: true
-          # This is _not_ official pipeline.
+          # Non-official pipelines always push to the NuGet Test feed.
+          releaseToProduction: false
+          # This is _not_ an official pipeline.
           isOfficial: false
           stageNameSuffix: test
-          stageDisplayName: Release Test (Dry Run)
           releaseSqlServerServer: ${{ parameters.releaseSqlServerServer }}
           releaseLogging: ${{ parameters.releaseLogging }}
           releaseAbstractions: ${{ parameters.releaseAbstractions }}
diff --git a/eng/pipelines/onebranch/sqlclient-official.yml b/eng/pipelines/onebranch/sqlclient-official.yml
@@ -33,6 +33,12 @@ parameters:
     type: boolean
     default: false
 
+  # Push packages to NuGet Production (otherwise pushes to NuGet Test).
+  - name: releaseToProduction
+    displayName: Release to NuGet Production
+    type: boolean
+    default: false
+
   # True if this is a preview build.
   - name: isPreview
     displayName: Is this a preview build?
@@ -45,12 +51,6 @@ parameters:
     type: boolean
     default: false
 
-  # Release Dry Run (do not push to NuGet)
-  - name: releaseDryRun
-    displayName: Release Dry Run (do not push to NuGet)
-    type: boolean
-    default: true
-
   # Build parameters — select which packages to build.
 
   # Build the Microsoft.SqlServer.Server package.
@@ -216,14 +216,10 @@ extends:
       - template: /eng/pipelines/onebranch/stages/release-stages.yml@self
         parameters:
           debug: ${{ parameters.debug }}
-          isDryRun: ${{ parameters.releaseDryRun }}
+          releaseToProduction: ${{ parameters.releaseToProduction }}
           # This is an official pipeline.
           isOfficial: true
           stageNameSuffix: production
-          ${{ if eq(parameters.releaseDryRun, true) }}:
-            stageDisplayName: Release Production (Dry Run)
-          ${{ else }}:
-            stageDisplayName: Release Production
           releaseSqlServerServer: ${{ parameters.releaseSqlServerServer }}
           releaseLogging: ${{ parameters.releaseLogging }}
           releaseAbstractions: ${{ parameters.releaseAbstractions }}
diff --git a/eng/pipelines/onebranch/stages/release-stages.yml b/eng/pipelines/onebranch/stages/release-stages.yml
@@ -10,13 +10,17 @@
 #   stages:
 #     - template: /eng/pipelines/onebranch/stages/release-stages.yml@self
 #       parameters:
-#         isOfficial: true   # or false
-#         isDryRun:   true   # or false
+#         isOfficial:          true   # or false
+#         releaseToProduction: false  # or true
 #         ...
 #
 # The isOfficial flag controls release-stage behaviour:
-#   - Official  → Production environment, approval gate, dryRun parameter
-#   - Non-Official → Test environment, dry-run always enforced
+#   - Official  → Production environment, approval gate.
+#   - Non-Official → Test environment.
+#
+# The releaseToProduction flag controls where packages are pushed:
+#   - true  → NuGet Production feed (via NuGetServiceConnectionProd).
+#   - false → NuGet Test feed (via NuGetServiceConnectionTest).
 #
 # This template depends on stages defined by the build-stages.yml template.
 #
@@ -36,33 +40,26 @@ parameters:
   - name: debug
     type: boolean
 
-  # True for this to be a dry-run of the release portion of the pipeline.  A dry run will ask
-  # for approvals and list the packages that would be released.
+  # Controls where packages are pushed during the release stage.
   #
-  # When false, a release will actually push packages to NuGet.
+  # When true, packages are pushed to the NuGet Production feed.
+  # When false (default), packages are pushed to the NuGet Test feed.
   #
-  - name: isDryRun
+  - name: releaseToProduction
     type: boolean
-    default: true
+    default: false
 
   # True for a OneBranch Official pipeline, false for a Non-Official pipeline.
   - name: isOfficial
     type: boolean
 
-  # We must take these names as parameters because they are used in the stage name and display name,
-  # which cannot be computed within the template.
-
-  # The stage name suffix.
+  # The stage name suffix, used in the stage ID (e.g. release_production) and display name.
   - name: stageNameSuffix
     type: string
     values:
       - production
       - test
 
-  # The stage display name.
-  - name: stageDisplayName
-    type: string
-
   # ── Release parameters ─────────────────────────────────────────────────
 
   - name: releaseSqlServerServer
@@ -90,13 +87,19 @@ stages:
   # Compile-time conditional: stage is removed entirely when no release
   # parameters are selected, avoiding OneBranch validation errors.
   #
-  # Official pipeline  → Production environment, approval gate,
-  #                       dryRun controlled by releaseDryRun parameter.
-  # Non-official pipeline → Test/DryRun environment, dryRun always true.
+  # Official pipeline  → Production environment, approval gate.
+  # Non-official pipeline → Test environment.
+  #
+  # releaseToProduction controls NuGet target:
+  #   true  → NuGet Production feed.
+  #   false → NuGet Test feed.
   # ====================================================================
   - ${{ if or(parameters.releaseSqlServerServer, parameters.releaseLogging, parameters.releaseAbstractions, parameters.releaseSqlClient, parameters.releaseAzure, parameters.releaseAKVProvider) }}:
     - stage: release_${{ parameters.stageNameSuffix }}
-      displayName: ${{ parameters.stageDisplayName }}
+      ${{ if eq(parameters.releaseToProduction, true) }}:
+        displayName: Release to NuGet Production
+      ${{ else }}:
+        displayName: Release to NuGet Test
       dependsOn:
         - ${{ if or(parameters.releaseSqlServerServer, parameters.releaseLogging) }}:
           - build_independent
@@ -128,63 +131,80 @@ stages:
         - name: ob_deploymentjob_environment
           value: ${{ variables.onebranchDeploymentEnvironment }}
 
+        # NuGet service connection names used by the release stage to push packages.
+        # These must match the ADO service connections configured with NuGet.org
+        # credentials (API key or federated auth).
+        - name: nugetServiceConnection
+          ${{ if eq(parameters.releaseToProduction, true) }}:
+            # https://sqlclientdrivers.visualstudio.com/ADO.Net/_settings/adminservices?resourceId=ee834e3a-87ad-4e9d-aa19-23711cfe4500
+            value: ADO Nuget Org Connection
+          ${{ else }}:
+            # https://sqlclientdrivers.visualstudio.com/ADO.Net/_settings/adminservices?resourceId=4dd2f6b9-2696-4324-bee5-0b4f9c273098
+            value: ADO Nuget Org Test Connection
+
+        - name: nugetTargetSuffix
+          ${{ if eq(parameters.releaseToProduction, true) }}:
+            value: ' (NuGet Production)'
+          ${{ else }}:
+            value: ' (NuGet Test)'
+
       jobs:
         - ${{ if eq(parameters.releaseSqlServerServer, true) }}:
           - template: /eng/pipelines/onebranch/jobs/publish-nuget-package-job.yml@self
             parameters:
               packageName: Microsoft.SqlServer.Server
               artifactName: drop_build_independent_build_package_SqlServer
               packagePath: Microsoft.SqlServer.Server.$(effectiveSqlServerVersion).nupkg
-              nugetServiceConnection: $(NuGetServiceConnection)
+              nugetServiceConnection: ${{ variables.nugetServiceConnection }}
               isProduction: ${{ parameters.isOfficial }}
-              isDryRun: ${{ parameters.isDryRun }}
+              displaySuffix: ${{ variables.nugetTargetSuffix }}
 
         - ${{ if eq(parameters.releaseLogging, true) }}:
           - template: /eng/pipelines/onebranch/jobs/publish-nuget-package-job.yml@self
             parameters:
               packageName: Microsoft.Data.SqlClient.Internal.Logging
               artifactName: drop_build_independent_build_package_Logging
               packagePath: Microsoft.Data.SqlClient.Internal.Logging.$(effectiveLoggingVersion).nupkg
-              nugetServiceConnection: $(NuGetServiceConnection)
+              nugetServiceConnection: ${{ variables.nugetServiceConnection }}
               isProduction: ${{ parameters.isOfficial }}
-              isDryRun: ${{ parameters.isDryRun }}
+              displaySuffix: ${{ variables.nugetTargetSuffix }}
 
         - ${{ if eq(parameters.releaseAbstractions, true) }}:
           - template: /eng/pipelines/onebranch/jobs/publish-nuget-package-job.yml@self
             parameters:
               packageName: Microsoft.Data.SqlClient.Extensions.Abstractions
               artifactName: drop_build_abstractions_build_package_Abstractions
               packagePath: Microsoft.Data.SqlClient.Extensions.Abstractions.$(effectiveAbstractionsVersion).nupkg
-              nugetServiceConnection: $(NuGetServiceConnection)
+              nugetServiceConnection: ${{ variables.nugetServiceConnection }}
               isProduction: ${{ parameters.isOfficial }}
-              isDryRun: ${{ parameters.isDryRun }}
+              displaySuffix: ${{ variables.nugetTargetSuffix }}
 
         - ${{ if eq(parameters.releaseSqlClient, true) }}:
           - template: /eng/pipelines/onebranch/jobs/publish-nuget-package-job.yml@self
             parameters:
               packageName: Microsoft.Data.SqlClient
               artifactName: drop_build_dependent_build_package_SqlClient
               packagePath: Microsoft.Data.SqlClient.$(effectiveSqlClientVersion).nupkg
-              nugetServiceConnection: $(NuGetServiceConnection)
+              nugetServiceConnection: ${{ variables.nugetServiceConnection }}
               isProduction: ${{ parameters.isOfficial }}
-              isDryRun: ${{ parameters.isDryRun }}
+              displaySuffix: ${{ variables.nugetTargetSuffix }}
 
         - ${{ if eq(parameters.releaseAzure, true) }}:
           - template: /eng/pipelines/onebranch/jobs/publish-nuget-package-job.yml@self
             parameters:
               packageName: Microsoft.Data.SqlClient.Extensions.Azure
               artifactName: drop_build_dependent_build_package_Azure
               packagePath: Microsoft.Data.SqlClient.Extensions.Azure.$(effectiveAzureVersion).nupkg
-              nugetServiceConnection: $(NuGetServiceConnection)
+              nugetServiceConnection: ${{ variables.nugetServiceConnection }}
               isProduction: ${{ parameters.isOfficial }}
-              isDryRun: ${{ parameters.isDryRun }}
+              displaySuffix: ${{ variables.nugetTargetSuffix }}
 
         - ${{ if eq(parameters.releaseAKVProvider, true) }}:
           - template: /eng/pipelines/onebranch/jobs/publish-nuget-package-job.yml@self
             parameters:
               packageName: Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider
               artifactName: drop_build_addons_build_package_AkvProvider
               packagePath: Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.$(effectiveAkvProviderVersion).nupkg
-              nugetServiceConnection: $(NuGetServiceConnection)
+              nugetServiceConnection: ${{ variables.nugetServiceConnection }}
               isProduction: ${{ parameters.isOfficial }}
-              isDryRun: ${{ parameters.isDryRun }}
+              displaySuffix: ${{ variables.nugetTargetSuffix }}
diff --git a/eng/pipelines/onebranch/variables/common-variables.yml b/eng/pipelines/onebranch/variables/common-variables.yml
@@ -180,12 +180,3 @@ variables:
     value: $(SymbolsPublishServer)
   - name: SymbolTokenUri
     value: $(SymbolsPublishTokenUri)
-
-  # ----------------------------------------------------------------------------
-  # Release Variables
-  #
-  # NuGet service connection used by the release stage to push packages.
-  # This should match the name of an ADO service connection configured with
-  # NuGet.org credentials (API key or federated auth).
-  - name: NuGetServiceConnection
-    value: ADO Nuget Org Connection
