perf(identifier): restrict stale-cache guard to UPDATE path in saveIdentifier()

The ContentTypeAPI lookup that resolves a missing base_type was running on every
saveIdentifier() call regardless of whether it was an INSERT or UPDATE. INSERT
callers always provide base_type (set in createNewIdentifier), so the guard was
only ever needed for UPDATE — where a stale cached Identifier loaded before the
backfill ran could write null back over a freshly populated value.

Moving the guard inside the isIdentifier==true branch eliminates the API+DB call
on all INSERT paths, making bulk operations (imports, publishing pipelines) that
create many new identifiers unaffected during the migration window.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: wezell

dotCMS/src/main/java/com/dotmarketing/business/IdentifierFactoryImpl.java

@@ -521,6 +521,23 @@ protected Identifier saveIdentifier(final Identifier id) throws DotDataException
         if (UtilMethods.isSet(id.getId())) {
             if (isIdentifier(id.getId())) {
                 query = "UPDATE identifier set parent_path=?, asset_name=?, host_inode=?, asset_type=?, syspublish_date=?, sysexpire_date=?, owner=?, create_date=?, asset_subtype=?, base_type=? where id=?";
+                // Guard against stale cached Identifiers (loaded before base_type was
+                // denormalized) writing null back and temporarily undoing the backfill.
+                // Only needed on UPDATE — INSERT callers must always supply base_type.
+                if (id.getBaseType() == null && UtilMethods.isSet(id.getAssetSubType())) {
+                    final Integer resolvedBaseType = Try.of(() ->
+                            APILocator.getContentTypeAPI(APILocator.systemUser())
+                                    .find(id.getAssetSubType())
+                                    .baseType()
+                                    .getType())
+                            .onFailure(e -> Logger.warn(IdentifierFactoryImpl.class,
+                                    "Could not resolve base_type for asset_subtype=" + id.getAssetSubType()
+                                    + " on identifier=" + id.getId() + ": " + e.getMessage()))
+                            .getOrNull();
+                    if (resolvedBaseType != null) {
+                        id.setBaseType(resolvedBaseType);
+                    }
+                }
             } else {
                 query = "INSERT INTO identifier (parent_path,asset_name,host_inode,asset_type,syspublish_date,sysexpire_date,owner,create_date,asset_subtype,base_type,id) values (?,?,?,?,?,?,?,?,?,?,?)";
             }
@@ -529,23 +546,6 @@ protected Identifier saveIdentifier(final Identifier id) throws DotDataException
             query = "INSERT INTO identifier (parent_path,asset_name,host_inode,asset_type,syspublish_date,sysexpire_date,owner,create_date,asset_subtype,base_type,id) values (?,?,?,?,?,?,?,?,?,?,?)";
         }
 
-        // Guard against stale cached Identifiers (loaded before base_type was denormalized)
-        // writing null back and temporarily undoing the backfill for this row.
-        if (id.getBaseType() == null && UtilMethods.isSet(id.getAssetSubType())) {
-            final Integer resolvedBaseType = Try.of(() ->
-                    APILocator.getContentTypeAPI(APILocator.systemUser())
-                            .find(id.getAssetSubType())
-                            .baseType()
-                            .getType())
-                    .onFailure(e -> Logger.warn(IdentifierFactoryImpl.class,
-                            "Could not resolve base_type for asset_subtype=" + id.getAssetSubType()
-                            + " on identifier=" + id.getId() + ": " + e.getMessage()))
-                    .getOrNull();
-            if (resolvedBaseType != null) {
-                id.setBaseType(resolvedBaseType);
-            }
-        }
-
         DotConnect dc = new DotConnect();
         dc.setSQL(query);