Comprehensive audit fixes (49 findings) — bump to v2.3.0

Critical bugs fixed:
- AttributeError in set_desiccant_reset/set_cleaning_reset/set_filter_reset/set_manual_feed
  (called .code/.status/.json() on already-parsed dicts)
- power_state now consistently returns bool|None (was returning mixed bool/str from int-typed property)
- Raise ConfigEntryNotReady on transient setup failures (was returning False, blocking retry)
- Fixed duplicate shared pets fetch and isolated owned/shared pet error handling

Architecture refactors:
- Populate Fountain base class: 34 properties moved, ~1042 lines saved across 4 fountain files
- PolarWetFoodFeeder now inherits from Feeder (~159 lines saved, 23 properties deleted)
- Consolidated set_desiccant_cycle/set_cleaning_cycle/set_filter_cycle into set_maintenance_frequency
- Consolidated set_water_mode_intermittent/constant duplicates (kept currently_off guard variant)
- Fix get_device_base_info endpoint (was hitting /device/setting/baseInfo, now /device/device/baseInfo)
- feeding_plan_state now reads from realInfo namespace (was reading stale flat key)
- Migrated 7 platform setup functions to entry.runtime_data
- Removed broken sys.modules lazy-import guards (always evaluated True)

Cleanup:
- Removed dead PetLibroDataCoordinator class (referenced nonexistent method)
- Removed duplicate/unused imports across 5 files
- Modernized typing: List/Dict/Type/Optional → list/dict/type/X|None
- Added docs/MQTT_RESEARCH.md documenting MQTT discovery and certificate generation block

Author: dn5qMDW3

custom_components/petlibro/__init__.py

@@ -3,6 +3,7 @@
 from homeassistant.core import HomeAssistant
 from homeassistant.const import Platform
 from homeassistant.config_entries import ConfigEntry
+from homeassistant.exceptions import ConfigEntryNotReady
 from homeassistant.helpers.device_registry import DeviceEntry
 from .devices import Device
 from .devices.feeders.feeder import Feeder
@@ -95,8 +96,8 @@ async def async_setup_entry(hass: HomeAssistant, entry: PetLibroConfigEntry) ->
         return True
 
     except Exception as err:
-        _LOGGER.error("Failed to set up PetLibro integration: %s", err, exc_info=True)
-        return False
+        _LOGGER.warning("PetLibro setup failed, will retry: %s", err)
+        raise ConfigEntryNotReady(f"PetLibro setup failed: {err}") from err
 
 
 async def async_unload_entry(hass: HomeAssistant, entry: PetLibroConfigEntry) -> bool:

custom_components/petlibro/api.py

@@ -3,7 +3,6 @@
 from dataclasses import dataclass
 from collections.abc import Callable
 from functools import cached_property
-from typing import Optional
 import logging
 from .const import Unit, APIKey as API, VALID_UNIT_TYPES
 from homeassistant.components.binary_sensor import (
@@ -28,7 +27,6 @@
 from .devices.fountains.dockstream_2_smart_cordless_fountain import Dockstream2SmartCordlessFountain
 from .devices.fountains.dockstream_2_smart_fountain import Dockstream2SmartFountain
 from .devices.litterboxes.luma_smart_litter_box import LumaSmartLitterBox
-from .entity import PetLibroEntity, _DeviceT, PetLibroEntityDescription
 
 
 @dataclass(frozen=True)
@@ -37,7 +35,7 @@ class PetLibroBinarySensorEntityDescription(BinarySensorEntityDescription, PetLi
 
     device_class_fn: Callable[[_DeviceT], BinarySensorDeviceClass | None] = lambda _: None
     should_report: Callable[[_DeviceT], bool] = lambda _: True
-    device_class: Optional[BinarySensorDeviceClass] = None
+    device_class: BinarySensorDeviceClass | None = None
     # Optional override for is_on — use when the entity key differs from the device property
     value_fn: Callable | None = None
 

custom_components/petlibro/binary_sensor.py

@@ -184,7 +184,10 @@ async def async_step_init(
         self.translations = await async_get_translations(
             self.hass, self.hass.config.language, "common")
         self.entry = self.config_entry
-        self.hub = self.hass.data[DOMAIN][self.handler]
+        self.hub = getattr(self.entry, "runtime_data", None)
+        if self.hub is None:
+            # Fall back to legacy storage if runtime_data not yet set
+            self.hub = self.hass.data[DOMAIN][self.handler]
         self.api = self.hub.api
         self.member = self.hub.member
         self._data.clear()

custom_components/petlibro/config_flow.py

@@ -38,7 +38,7 @@ async def async_setup_entry(
 ) -> None:
     """Set up Petlibro dates using config entry."""
 
-    hub: PetLibroHub = hass.data[DOMAIN].get(entry.entry_id)
+    hub: PetLibroHub | None = getattr(entry, "runtime_data", None)
 
     if not hub:
         _LOGGER.error("Hub not found for entry: %s", entry.entry_id)

custom_components/petlibro/date.py

@@ -1,7 +1,3 @@
-from typing import Dict, Type
-from .device import Device
-
-from . import Device
 from .device import Device
 from .feeders.feeder import Feeder
 from .feeders.air_smart_feeder import AirSmartFeeder
@@ -17,7 +13,7 @@
 from .litterboxes.litter_box import LitterBox
 from .litterboxes.luma_smart_litter_box import LumaSmartLitterBox
 
-product_name_map : Dict[str, Type[Device]] = {
+product_name_map : dict[str, type[Device]] = {
     "Air Smart Feeder": AirSmartFeeder,
     "Granary Smart Feeder": GranarySmartFeeder,
     "Granary Smart Camera Feeder": GranarySmartCameraFeeder,

custom_components/petlibro/devices/__init__.py

@@ -1,7 +1,6 @@
 # Error Mode - Used for pulling API for new devices. Enable Error Mode and Disable Debug Mode.
 
 from logging import getLogger
-import sys
 from typing import cast
 
 from .event import Event, EVENT_UPDATE
@@ -14,8 +13,7 @@
 class Device(Event):
     def __init__(self, data: dict, hub):
         super().__init__()
-        if "PetLibroHub" not in sys.modules:
-            from ..hub import PetLibroHub
+        from ..hub import PetLibroHub
         self._data: dict = {}
         self.hub: PetLibroHub = hub
         self.api = self.hub.api

custom_components/petlibro/devices/device.py

@@ -25,7 +25,7 @@ async def refresh(self):
             get_feeding_plan_today = await self.api.device_feeding_plan_today_new(self.serial)
             get_work_record = await self.api.get_device_work_record(self.serial)
             feeding_plan_list = (await self.api.device_feeding_plan_list(self.serial)
-                if self._data.get("enableFeedingPlan") else [])
+                if self._data.get("realInfo", {}).get("enableFeedingPlan") else [])
 
             self.update_data({
                 "grainStatus": grain_status or {},

custom_components/petlibro/devices/feeders/air_smart_feeder.py

@@ -1,7 +1,6 @@
 """Generic PETLIBRO feeder"""
 import ast
 from zoneinfo import ZoneInfo
-import aiohttp
 
 from typing import cast
 from logging import getLogger
@@ -205,11 +204,8 @@ def enable_grain_outlet_blocked_notice(self) -> bool:
 
     @property
     def feeding_plan_state(self) -> bool:
-        return bool(self._data.get("enableFeedingPlan", False))
-
-    @property
-    def feeding_plan(self) -> bool:
-        return self._data.get("enableFeedingPlan", False)
+        """Whether the feeding plan is enabled (read from realInfo namespace)."""
+        return bool(self._data.get("realInfo", {}).get("enableFeedingPlan", False))
 
     async def set_feeding_plan(self, value: bool) -> None:
         await self.api.set_feeding_plan(self.serial, value)
@@ -441,7 +437,7 @@ async def set_light_off(self) -> None:
         await self.refresh()
 
     async def set_desiccant_cycle(self, value: float) -> None:
-        await self.api.set_desiccant_cycle(self.serial, value, "changeDesiccantFrequency")
+        await self.api.set_maintenance_frequency(self.serial, "changeDesiccantFrequency", value)
         await self.refresh()
 
     async def set_desiccant_reset(self) -> None:

custom_components/petlibro/devices/feeders/feeder.py

@@ -20,7 +20,7 @@ async def refresh(self):
             get_feeding_plan_today = await self.api.device_feeding_plan_today_new(self.serial)
             get_work_record = await self.api.get_device_work_record(self.serial)
             feeding_plan_list = (await self.api.device_feeding_plan_list(self.serial)
-                if self._data.get("enableFeedingPlan") else [])
+                if self._data.get("realInfo", {}).get("enableFeedingPlan") else [])
 
             self.update_data({
                 "grainStatus": grain_status or {},