Skip to content

Commit 929a23d

Browse files
committed
reset SP defaults for filter name test.
1 parent 1afd935 commit 929a23d

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

tests/tests.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,10 @@ def test_param_checks(pop_and_params):
7070
# this should never raise an error:
7171
w, s = pop.get_spectrum(tage=pop.params["tage"])
7272
# this used to raise an assertion error in the setter:
73-
pop.params["sf_start"] = 2.1
73+
pop.params["sf_start"] = pop.params["tage"] + 0.1
7474
# this also used to raise an assertion error in the setter:
7575
pop.params["imf_type"] = 8
76-
# fix the IMF issue but leave the sf_start error
76+
# fix the invalid IMF but leave the invalid sf_start > tage
7777
pop.params["imf_type"] = 1
7878
try:
7979
# This *should* still raise an AssertionError
@@ -99,10 +99,11 @@ def test_filters():
9999
def test_get_mags(pop_and_params):
100100
"""Basic test for supplying filter names to get_mags"""
101101
pop, params = pop_and_params
102+
_reset_default_params(pop, params)
102103
fuv1 = pop.get_mags(bands=["galex_fuv"])[:, 0]
103104
mags = pop.get_mags()
104-
fuv2 = mags[:, 61]
105-
fuv3 = mags[:, 62]
105+
fuv2 = mags[:, 61] # this should be galex_FUV
106+
fuv3 = mags[:, 62] # this should *not* be galex_FUV
106107
assert np.all(fuv1 == fuv2)
107108
assert np.all(fuv1 != fuv3)
108109

0 commit comments

Comments
 (0)